Skip to content

Conversation

@jfernan2
Copy link
Contributor

PR description:

Backport of #36275 since ReReco of Pilot Test Runs taken in Autumn 2021 will be most likely done in 12_1_X

First version of nanoDQMIO data-Tier with a preliminary content based on requests from subsystems interested in doing ML4DC/DQM with the upcoming ReReco of Pilot Test Runs taken in Autumn 2021

Tested with: runTheMatrix.py -l limited -i all --ibeos --command '--procModifiers=dqmPerLSsaving --customise_commands="process.DQMStore.saveByLumi = cms.untracked.bool(True)"'

up to Harvesting step (excluded) since Harvesting is not defined with perLS saving

@jfernan2
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for CMSSW_12_1_X.

It involves the following packages:

  • DQM/CTPPS (dqm)
  • DQMServices/Core (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @jan-kaspar, @barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a3767/20893/summary.html
COMMIT: 4f7edcd
CMSSW: CMSSW_12_1_X_2021-11-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36308/20893/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor Author

jfernan2 commented Dec 1, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

urgent

  • needed for re-reco of PilotBeam 2021 data

@cmsbuild cmsbuild added the urgent label Dec 1, 2021
@francescobrivio
Copy link
Contributor

@qliphy @perrotta this is another PR needed for the new 12_1_X release for re-reco. It's fully signed and the master PR is merged already.

@perrotta
Copy link
Contributor

perrotta commented Dec 1, 2021

@qliphy @perrotta this is another PR needed for the new 12_1_X release for re-reco. It's fully signed and the master PR is merged already.

This is an identical backport of #36275, and quite likely already good for being backported.
As usual, let it be tested in at least one master IB, and if there are no issue also the backport will get merged

@francescobrivio
Copy link
Contributor

@qliphy @perrotta this is another PR needed for the new 12_1_X release for re-reco. It's fully signed and the master PR is merged already.

This is an identical backport of #36275, and quite likely already good for being backported. As usual, let it be tested in at least one master IB, and if there are no issue also the backport will get merged

sounds a good plan! thanks a lot @perrotta!

@jfernan2
Copy link
Contributor Author

jfernan2 commented Dec 2, 2021

@perrotta since this PR has not been merged yet, would it be possible to add a naive extra line in the configuration file of Monitor Elements to be saved? Tracker has just requested an additional histogram to be saved in the nanoDQMIO data-Tier, the change is innocent, I can update the master version too if needed.
Thanks

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2021

@perrotta since this PR has not been merged yet, would it be possible to add a naive extra line in the configuration file of Monitor Elements to be saved? Tracker has just requested an additional histogram to be saved in the nanoDQMIO data-Tier, the change is innocent, I can update the master version too if needed. Thanks

@jfernan2 yes, please updatesboth this PR and the master

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

Pull request #36308 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Dec 2, 2021

Thanks @perrotta
I have updated this PR, I don't think it makes sense to retrigger the tests since the change won't affect them in any way
For master, since the PR has already been merged, I will create a tiny PR with this minor change
Thank you!

@jfernan2
Copy link
Contributor Author

jfernan2 commented Dec 2, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@jfernan2
Copy link
Contributor Author

jfernan2 commented Dec 2, 2021

For the records: master PR to sincronyze with last minute addition on this PR
#36331

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a3767/20924/summary.html
COMMIT: 607f6d7
CMSSW: CMSSW_12_1_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36308/20924/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2021

+1

@cmsbuild cmsbuild merged commit f3c3408 into cms-sw:CMSSW_12_1_X Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants