Appropriately fill PFCandidate::dnn_gamma_ data member in the constructors and copy operator

[swagata87]

PR description:

This PR fixes a bug which was introduced in #35403.
dnn_gamma_ was declared in DataFormats/ParticleFlowCandidate/interface/PFCandidate.h, but it was never initialised or filled.

PR validation:

Using Higgs->gamma gamma GEN-SIM-DIGI-RAW RelVal, ran the AOD step, and printed PFCandidate's dnn_gamma() score, when the PFCandidate is identified as a photon, i.e. pdgId is 22; and pT>20 GeV.

Before this PR:

 evt  0
PF-photon, pf cand pdgId= 22  pt= 33.189727783203125 dnn score  8.036290025386882e+20
PF-photon, pf cand pdgId= 22  pt= 74.13899230957031 dnn score  8.036290025386882e+20
 
 evt  1
PF-photon, pf cand pdgId= 22  pt= 20.03341293334961 dnn score  0.0
PF-photon, pf cand pdgId= 22  pt= 48.14902114868164 dnn score  2.883718096749398e-38
 
 evt  2
PF-photon, pf cand pdgId= 22  pt= 63.15763854980469 dnn score  -2.0328792349690342e-20
PF-photon, pf cand pdgId= 22  pt= 98.55475616455078 dnn score  0.0
 
 evt  3
PF-photon, pf cand pdgId= 22  pt= 104.18643951416016 dnn score  -6.0656864661723375e-05
 
 evt  4
PF-photon, pf cand pdgId= 22  pt= 55.326622009277344 dnn score  0.0
PF-photon, pf cand pdgId= 22  pt= 57.880157470703125 dnn score  0.0

After this PR:

 evt  0
PF-photon, pf cand pdgId= 22  pt= 33.189727783203125 dnn score  0.9908796548843384
PF-photon, pf cand pdgId= 22  pt= 74.13899230957031 dnn score  0.9941856265068054
 
 evt  1
PF-photon, pf cand pdgId= 22  pt= 20.03341293334961 dnn score  -999.0
PF-photon, pf cand pdgId= 22  pt= 48.14902114868164 dnn score  0.9918241500854492
 
 evt  2
PF-photon, pf cand pdgId= 22  pt= 63.15763854980469 dnn score  0.9920834898948669
PF-photon, pf cand pdgId= 22  pt= 98.55475616455078 dnn score  0.9920132160186768
 
 evt  3
PF-photon, pf cand pdgId= 22  pt= 104.18643951416016 dnn score  0.9921286106109619
 
 evt  4
PF-photon, pf cand pdgId= 22  pt= 55.326622009277344 dnn score  0.9912372827529907
PF-photon, pf cand pdgId= 22  pt= 57.880157470703125 dnn score  0.9917799234390259

runTheMatrix.py -l 12434.0 ran fine.

This PR is not a backport.
Backport not needed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36096/26588

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• DataFormats/ParticleFlowCandidate (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@cbernet, @lgray, @rovere, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[swagata87]

type bug-fix

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94d425/20480/summary.html
COMMIT: a7745b1
CMSSW: CMSSW_12_2_X_2021-11-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36096/20480/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2902040
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902018
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[slava77]

@swagata87
please edit the PR title to describe the actual fix (the origin), not the symptom (the dnn_gamma is not modified by this PR at all).

something like Appropriately fill PFCandidate::dnn_gamma_ data member in the constructors and copy operator would be more clear to me

[slava77]

+reconstruction

for #36096 a7745b1

• code changes are in line with the PR description, to appropriately set PFCandidate::dnn_gamma_
• jenkins tests pass and comparisons with the baseline show no differences (the updated data is not monitored)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1