Phase2-hgx294C Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry #36045

bsunanda · 2021-11-09T02:17:15Z

PR description:

Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry

PR validation:

Verified using cfg's in Geometry/HGCalGeometry

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-11-09T02:22:53Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36045/26503

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36045/26503/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36045/26503/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-11-09T02:29:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36045/26504

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

cmsbuild · 2021-11-09T02:29:49Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)
Geometry/HGCalGeometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-11-09T12:01:08Z

@cmsbuild Please test

cmsbuild · 2021-11-09T13:26:06Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8255db/20368/summary.html
COMMIT: 784a138
CMSSW: CMSSW_12_2_X_2021-11-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36045/20368/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.911

----- Begin Fatal Exception 09-Nov-2021 13:41:43 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'EcalBarrelGeometryEPdd4hep' in category 'CMS EDM Framework ParameterSet Description'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
35234.99935234.999_TTbar_14TeV+2026D77PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D77PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

RelVals-INPUT

34634.034634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
34634.2134634.21_TTbar_14TeV+2026D76_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD+Nano/step2_TTbar_14TeV+2026D76_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD+Nano.log
34834.2134834.21_TTbar_14TeV+2026D76PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU+NanoPU/step2_TTbar_14TeV+2026D76PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU+NanoPU.log

Expand to see more relval errors ...

srimanob · 2021-11-09T13:53:44Z

@cmsbuild please test with #36021

cmsbuild · 2021-11-09T15:41:48Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8255db/20377/summary.html
COMMIT: 784a138
CMSSW: CMSSW_12_2_X_2021-11-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36045/20377/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
35234.99935234.999_TTbar_14TeV+2026D77PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D77PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

RelVals-INPUT

34634.034634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
34634.2134634.21_TTbar_14TeV+2026D76_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD+Nano/step2_TTbar_14TeV+2026D76_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD+Nano.log
34834.2134834.21_TTbar_14TeV+2026D76PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU+NanoPU/step2_TTbar_14TeV+2026D76PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU+NanoPU.log

Expand to see more relval errors ...

bsunanda · 2021-11-09T21:04:50Z

@cmsbuild please test with #36021

cmsbuild · 2021-11-09T21:11:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36045/26535

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalGeomParameters.cc modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

cmsbuild · 2021-11-09T21:14:59Z

Pull request #36045 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please check and sign again.

cmsbuild · 2021-11-10T02:00:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8255db/20414/summary.html
COMMIT: 87799c7
CMSSW: CMSSW_12_2_X_2021-11-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36045/20414/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9073 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901890
DQMHistoTests: Total failures: 104029
DQMHistoTests: Total nulls: 13
DQMHistoTests: Total successes: 2797826
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

cvuosalo · 2021-11-11T00:17:18Z

+1

srimanob · 2021-11-11T01:51:01Z

+1

cmsbuild · 2021-11-11T01:51:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-11-11T05:19:09Z

@bsunanda The differences are expected, right?

bsunanda · 2021-11-11T11:12:36Z

Yes they are expected. This is a bug fix which changes the list of valid cells Sent from my Verizon 4G LTE smartphone

…

-------- Original message -------- From: Qiang Li ***@***.***> Date: 11/10/21 11:20 PM (GMT-06:00) To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>, Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Phase2-hgx294C Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry (PR #36045) @bsunanda<https://github.com/bsunanda> The differences are expected, right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#36045 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOXLZQML4T6EROPOOKDULNG5RANCNFSM5HUEWDVQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

qliphy · 2021-11-11T11:49:03Z

+1

Make sure that all rings of scinitllators are included

fbef5d6

cmsbuild added this to the CMSSW_12_2_X milestone Nov 9, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Nov 9, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 9, 2021

Code check

784a138

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 9, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 9, 2021

cmsbuild added requires-external tests-started and removed tests-rejected labels Nov 9, 2021

cmsbuild removed the tests-started label Nov 9, 2021

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved labels Nov 9, 2021

cmsbuild added requires-external tests-started and removed tests-pending labels Nov 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 9, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2021

cmsbuild added geometry-approved and removed geometry-pending labels Nov 11, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Nov 11, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 11, 2021

cmsbuild merged commit fe57a59 into cms-sw:master Nov 11, 2021

cmsbuild mentioned this pull request Nov 11, 2021

Move to root 6.24 cms-sw/cmsdist#7445

Merged

Phase2-hgx294C Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry #36045

Phase2-hgx294C Make sure that all rings of scinitllators are included in the definitions of HGCalGeometry #36045

Uh oh!

Conversation

bsunanda commented Nov 9, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 9, 2021

Uh oh!

bsunanda commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 9, 2021

RelVals

RelVals-INPUT

Uh oh!

srimanob commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 9, 2021

RelVals

RelVals-INPUT

Uh oh!

bsunanda commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 9, 2021

Uh oh!

cmsbuild commented Nov 10, 2021

Comparison Summary

Uh oh!

cvuosalo commented Nov 11, 2021

Uh oh!

srimanob commented Nov 11, 2021

Uh oh!

cmsbuild commented Nov 11, 2021

Uh oh!

qliphy commented Nov 11, 2021

Uh oh!

bsunanda commented Nov 11, 2021 via email

Uh oh!

qliphy commented Nov 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants