-
Notifications
You must be signed in to change notification settings - Fork 4.6k
small technical updates to HLTJetTiming{Filter,Producer} #35971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35971/26395
|
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-666567/20229/summary.html Comparison SummarySummary:
|
|
+hlt |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR is a simple technical followup to #35724, mainly to address #35724 (review).
Includes small adjustments for
#includestatements,BuildFile.xmlcontent, and use ofstd::abs(instead offabs).FYI: @mcitron
PR validation:
scrambuilds.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A