Skip to content

Improve BeamSpotOnlineWriter plugin in CondTools #35943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Nov 2, 2021
Merged

Improve BeamSpotOnlineWriter plugin in CondTools #35943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b4fd3
Improve BeamSpotOnlineWriter plugin in `CondTools`
francescobrivio Nov 1, 2021
e5a659f
fix unitTest and use throw instead of LogError
francescobrivio Nov 2, 2021
2f085bc
remove forgotten return
francescobrivio Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions CondTools/BeamSpot/plugins/BeamSpotOnlineRecordsWriter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <string>
#include <fstream>
#include <iostream>
#include <ctime>

// user include files
#include "FWCore/Framework/interface/Frameworkfwd.h"
Expand Down Expand Up @@ -108,10 +109,11 @@ void BeamSpotOnlineRecordsWriter::endJob() {
double cov[7][7];
int type, lastAnalyzedLumi, firstAnalyzedLumi, lastAnalyzedRun, lastAnalyzedFill;
std::string tag;
std::time_t lumiRangeBeginTime, lumiRangeEndTime;

fasciiFile >> tag >> lastAnalyzedRun;
fasciiFile >> tag >> tag >> tag >> tag >> tag; // BeginTimeOfFit parsing (not used in payload)
fasciiFile >> tag >> tag >> tag >> tag >> tag; // EndTimeOfFit parsing (not used in payload)
fasciiFile >> tag >> tag >> tag >> tag >> lumiRangeBeginTime; // BeginTimeOfFit parsing (not used in payload)
fasciiFile >> tag >> tag >> tag >> tag >> lumiRangeEndTime; // EndTimeOfFit parsing (not used in payload)
fasciiFile >> tag >> firstAnalyzedLumi;
fasciiFile >> tag >> lastAnalyzedLumi;
fasciiFile >> tag >> type;
Expand All @@ -136,11 +138,21 @@ void BeamSpotOnlineRecordsWriter::endJob() {

lastAnalyzedFill = -999;

// Verify that the parsing was correct by checking the BS positions
if (std::fabs(x) > 1000. || std::fabs(x) < 1.e-20 || std::fabs(y) > 1000. || std::fabs(y) < 1.e-20 ||
std::fabs(z) > 1000. || std::fabs(z) < 1.e-20) {
edm::LogError("BeamSpotOnlineRecordsWriter")
<< " !!! Error in parsing file, parsed BS (x,y,z): (" << x << "," << y << "," << z << ") !!!";
return;
}

edm::LogPrint("BeamSpotOnlineRecordsWriter") << "---- Parsed these parameters from input txt file ----";
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " lastAnalyzedRun : " << lastAnalyzedRun;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " lastAnalyzedFill : " << lastAnalyzedFill;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " firstAnalyzedLumi : " << firstAnalyzedLumi;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " lastAnalyzedLumi : " << lastAnalyzedLumi;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " lumiRangeBeginTime: " << lumiRangeBeginTime;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " lumiRangeEndTime : " << lumiRangeEndTime;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " type : " << type;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " x : " << x;
edm::LogPrint("BeamSpotOnlineRecordsWriter") << " y : " << y;
Expand Down Expand Up @@ -181,6 +193,8 @@ void BeamSpotOnlineRecordsWriter::endJob() {
abeam->SetLastAnalyzedLumi(lastAnalyzedLumi);
abeam->SetLastAnalyzedRun(lastAnalyzedRun);
abeam->SetLastAnalyzedFill(lastAnalyzedFill);
abeam->SetStartTimeStamp(lumiRangeBeginTime);
abeam->SetEndTimeStamp(lumiRangeEndTime);
abeam->SetType(type);
abeam->SetPosition(x, y, z);
abeam->SetSigmaZ(sigmaZ);
Expand All @@ -198,6 +212,11 @@ void BeamSpotOnlineRecordsWriter::endJob() {
}
}

// Set the creation time of the payload to the current time
auto creationTime =
std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::system_clock::now().time_since_epoch()).count();
abeam->SetCreationTime(creationTime);

edm::LogPrint("BeamSpotOnlineRecordsWriter") << " Writing results to DB...";

edm::Service<cond::service::PoolDBOutputService> poolDbService;
Expand Down
2 changes: 1 addition & 1 deletion CondTools/BeamSpot/test/BeamSpotOnlineRecordsWriter_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
VarParsing.VarParsing.varType.bool, # string, int, or float
"are we running the unit test?")
options.register('inputFile',
"BeamFitResults_Run306171.txt", # default value
"../data/BeamFitResults_Run306171.txt", # default value
VarParsing.VarParsing.multiplicity.singleton, # singleton or list
VarParsing.VarParsing.varType.string, # string, int, or float
"location of the input data")
Expand Down