Skip to content

Conversation

@francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Oct 30, 2021

PR description:

Updates to the Legacy and HLT BeamSpot DQM clients:

  • fixed the names of the output DQM folder so that the DQM is more clear:
    • 1 folder for BeamMonitorLegacy
    • 1 folder for BeamMonitorLHT
    • previous BeamMonitor folder is removed
  • Added the offline <-> online beamspot swap same as in express and HLT
  • In the BeamSpot Legacy clients I also fixed the pixelTracksTrackingRegions parameters to remove the 2018 HI customization that was left there (thanks @mmusich!). Overall this should increase the number of tracks reconstructed by the Legacy client so that it can fit PVs and eventually the Beamspot.
  • Fixed a typo in the name of the Legacy BeamSpotOnline tag

PR validation:

Should be validated with playback system in P5, run 346373.

Backport

Not a backport. A forward port to master and 12_1_X will be provided after the playback test.

FYI @mtosi @gennai @vmariani @dzuolo

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2021

A new Pull Request was created by @francescobrivio for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

urgent

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

Pull request #35918 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2474b9/20113/summary.html
COMMIT: 27a7211
CMSSW: CMSSW_12_0_X_2021-10-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35918/20113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Oct 31, 2021

From the online playback I can see that:

  • the BeamMonitorHLT and BeamMonitorLegacy directories are now correctly split as they should be
  • the legacy BS client now seems to have enought trks and PVs to produce a fit

@pmandrik @ahmad3213 @jfernan2 if the playback was succesful from your side please sign this PR and deploy it before the StableBeams today.

@ahmad3213
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 1, 2021

+1
A forward port to master and 12_1_X will be provided after the playback test.

@cmsbuild cmsbuild merged commit 3f2ef58 into cms-sw:CMSSW_12_0_X Nov 1, 2021
@francescobrivio
Copy link
Contributor Author

Just for completeness this is the DQM plot that proves both Beamspot DQM clients were producing converging BeamSpot fits and thus validating this PR:

Schermata 2021-11-01 alle 10 52 47

@mmusich
Copy link
Contributor

mmusich commented Nov 1, 2021

@francescobrivio
Copy link
Contributor Author

backport of #35932

@francescobrivio francescobrivio deleted the alca-BS_nameFix_12_0_X branch November 3, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants