-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[12_0_X] Improve DQM beamspot clients #35918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_0_X] Improve DQM beamspot clients #35918
Conversation
|
A new Pull Request was created by @francescobrivio for CMSSW_12_0_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
urgent |
|
@cmsbuild please test |
|
Pull request #35918 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again. |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2474b9/20113/summary.html Comparison SummarySummary:
|
|
From the online playback I can see that:
@pmandrik @ahmad3213 @jfernan2 if the playback was succesful from your side please sign this PR and deploy it before the StableBeams today. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Also here logs from the conddb: https://cms-conddb.cern.ch/cmsDbBrowser/logs/show_O2O_log/Prod/BeamSpotOnlineLegacy/2021-11-01%2003:00:28.830625 |
|
backport of #35932 |

PR description:
Updates to the Legacy and HLT BeamSpot DQM clients:
pixelTracksTrackingRegionsparameters to remove the 2018 HI customization that was left there (thanks @mmusich!). Overall this should increase the number of tracks reconstructed by the Legacy client so that it can fit PVs and eventually the Beamspot.PR validation:
Should be validated with playback system in P5, run 346373.
Backport
Not a backport. A forward port to master and 12_1_X will be provided after the playback test.
FYI @mtosi @gennai @vmariani @dzuolo