Fixed bug which was crashing ROOT in fitting empty histograms #35904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing full blown DQM files is painfully slow. This PR adds the possibility to run the comparisons over the histograms in parallel via a configurable parameter: `-j`, or the longer version `--num-processes`. The default behaviour is unchanged: using one process will run the current implementation. Selecting more than one process will trigger multiprocessing. The final sorting on the output lists is mandatory to keep a sane ordering within the saved ROOT files. It is useless for the DQMGUI, which does that already internally, but it's mandatory in the exploration of the base ROOT files. Usually the price to pay should be negligible compared to the speed-up gain thanks to the parallelism.
Change config files to include new metadata files needed for the new PCL devs
…erator Add esConsumes to modules in Validation/EventGenerator
Change bx constant to centrally defined value in RawDataTask.cc
Run3-sim93 Use ESGetToken in getting objects from EventSetup
Update mkFit for 12_1_0_pre5
Merge .h files with .icc files in `TrackingTools/GsfTools/plugins`
…rom all HI-related eras
introduction of L2TauNNTag changes done after first iteration code-checks and code-format removed submodule applied 01/10 changes implemented second iteration added third iteration of changes fixed the readme.md file formatting files used are now winter2021 and debugLevel=0 fixed path dependencies adding missing function
…release; Update recipe in README
includes general code style safety checks logging removal of commented code removal of tau_hlt namespace update paths switch to new HLT customization functions use logger instead of cout
…_0_pre5 Enable mkFit by default in 4+2 tracking iterations (initialStepPreSpl…
Phase2-hgx291 Bug fix to address rotated layers in D86
cmsbuild
added
db-pending
dqm-pending
fastsim-pending
generators-pending
geometry-pending
heterogeneous-pending
hlt-pending
l1-pending
new-package-pending
operations-pending
orp-pending
pdmv-pending
pending-signatures
reconstruction-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
xpog-pending
labels
Contributor
|
A new Pull Request was created by @dinardo (Mauro) for CMSSW_12_0_X. It involves the following packages:
The following packages do not have a category, yet: RecoLocalTracker/SiPixelDigiMorphing @SiewYan, @gouskos, @lveldere, @bbilin, @wajidalikhan, @slava77, @ianna, @Saptaparna, @Martin-Grunewald, @ggovi, @alberto-sanchez, @santocch, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @missirol, @agrohsje, @fwyzard, @GurpreetSinghChahal, @smorovic, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @kskovpen, @sbein, @jpata, @qliphy, @pmandrik, @fabiocos, @pbo0, @francescobrivio, @malbouis, @ssekmen, @mkirsano, @jordan-martins, @rekovic, @emeschi, @alja, @srimanob, @fgolf, @mariadalfonso, @tvami, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
@dinardo I guess you based this on the wrong CMSSW branch? :) |
Contributor
|
-alca
|
Contributor
|
@cmsbuild ping |
Contributor
|
-db |
Contributor
|
@cmsbuild , please abort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
I fixed a bug that was crashing ROOT: the application was trying to fit empty histograms.
Now I've protected the fit by checking whether the histogram is empty or not
PR validation:
Now the crash should not occur anymore
if this PR is a backport please specify the original PR and why you need to backport that PR:
#35903