Update customisePixelL1ClusterThresholdForRun2Input to adjust also the GPU producer #35901

fwyzard · 2021-10-29T12:36:05Z

PR description:

Update customisePixelL1ClusterThresholdForRun2Input() to adjust also the GPU producer with the Run 2 settings.

PR validation:

None.

fwyzard · 2021-10-29T12:36:19Z

please test

fwyzard · 2021-10-29T12:38:49Z

type bugfix

cmsbuild · 2021-10-29T12:42:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35901/26301

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385

cmsbuild · 2021-10-29T12:42:36Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2021-10-29T14:08:28Z

The error is in 138.3_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3 Step0-PASSED Step1-FAILED Step2-NOTRUN - time date Fri Oct 29 15:37:49 2021-date Fri Oct 29 15:16:50 2021; exit: 0 31744 0, but that should not run the HLT at all...

missirol · 2021-10-29T14:39:33Z

please abort

will re-trigger the tests with #35890, which fixes the timeout in the offending wf
(I guess the other PR has to be included explicitly even if it's now merged)

missirol · 2021-10-29T14:40:14Z

please test with #35890

missirol · 2021-10-29T14:51:27Z

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

            producer.ClusterThreshold_L1 = 2000
+    for producer in producers_by_type(process, "SiPixelRawToClusterCUDA"):
+        if hasattr(producer,"clusterThreshold_layer1"):
+            producer.ClusterThreshold_L1 = 2000


Suggested change

producer.ClusterThreshold_L1 = 2000

producer.clusterThreshold_layer1 = 2000

No? By the way, is any wf using this in the PR tests?

No ?

Yes, indeed it was supposed to be like that...

By the way, is any wf using this in the PR tests?

Yes, the enable gpu workflows should test this.

Ah, sorry, no... we don't have any 2018-like GPU workflows.

Okay, thanks. Feel free to fix the code in the PR description. :)

…e GPU producer

cmsbuild · 2021-10-29T16:08:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35901/26312

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385

cmsbuild · 2021-10-29T16:09:05Z

Pull request #35901 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

missirol · 2021-10-29T18:33:25Z

please abort

missirol · 2021-10-29T18:34:58Z

test parameters:

pull_request = introduce COPYPASTER3 and use it as step2 in wf 138.3 #35890

missirol · 2021-10-29T18:36:00Z

please test

cmsbuild · 2021-10-29T21:35:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d7fe1/20090/summary.html
COMMIT: cda3168
CMSSW: CMSSW_12_2_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35901/20090/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901440
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2901406
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

missirol · 2021-10-30T09:35:55Z

+hlt

despite the label, this PR did not require any externals (and the other PR, which fixed one of the tests, is already merged)

cmsbuild · 2021-10-30T09:36:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-10-30T13:12:44Z

+1

cmsbuild added this to the CMSSW_12_2_X milestone Oct 29, 2021

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-pending tests-started and removed tests-pending labels Oct 29, 2021

fwyzard mentioned this pull request Oct 29, 2021

Update customisePixelL1ClusterThresholdForRun2Input to adjust also the GPU producer [12.1.x] #35902

Merged

cmsbuild added the bug-fix label Oct 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2021

cmsbuild added tests-pending and removed tests-started labels Oct 29, 2021

cmsbuild added requires-external tests-started and removed tests-pending labels Oct 29, 2021

missirol reviewed Oct 29, 2021

View reviewed changes

Update customisePixelL1ClusterThresholdForRun2Input to adjust also th…

cda3168

…e GPU producer

fwyzard force-pushed the fix_customiseHCALFor2018Input_121x branch from 8c1a266 to cda3168 Compare October 29, 2021 16:02

cmsbuild removed tests-started requires-external code-checks-approved labels Oct 29, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2021

cmsbuild added tests-pending and removed tests-started labels Oct 29, 2021

cmsbuild added the requires-external label Oct 29, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 29, 2021

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Oct 30, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 30, 2021

cmsbuild merged commit 4dc0c5e into cms-sw:master Oct 30, 2021

This was referenced Oct 30, 2021

Add ppRef modifier instead of a GT #35909

Merged

rootmodule: Updated root to tip of branch master cms-sw/cmsdist#7421

Merged

fwyzard deleted the fix_customiseHCALFor2018Input_121x branch November 23, 2021 12:48

	producer.ClusterThreshold_L1 = 2000
	producer.clusterThreshold_layer1 = 2000

Update customisePixelL1ClusterThresholdForRun2Input to adjust also the GPU producer #35901

Update customisePixelL1ClusterThresholdForRun2Input to adjust also the GPU producer #35901

Uh oh!

Conversation

fwyzard commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

fwyzard commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Oct 29, 2021

Uh oh!

cmsbuild commented Oct 29, 2021

Uh oh!

cmsbuild commented Oct 29, 2021

Uh oh!

fwyzard commented Oct 29, 2021

Uh oh!

missirol commented Oct 29, 2021

Uh oh!

missirol commented Oct 29, 2021

Uh oh!

missirol Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

fwyzard Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

fwyzard Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

missirol Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Oct 29, 2021

Uh oh!

cmsbuild commented Oct 29, 2021

Uh oh!

missirol commented Oct 29, 2021

Uh oh!

missirol commented Oct 29, 2021

Uh oh!

missirol commented Oct 29, 2021

Uh oh!

cmsbuild commented Oct 29, 2021

Comparison Summary

Uh oh!

missirol commented Oct 30, 2021

Uh oh!

cmsbuild commented Oct 30, 2021

Uh oh!

qliphy commented Oct 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fwyzard commented Oct 29, 2021 •

edited

Loading

fwyzard commented Oct 29, 2021 •

edited

Loading