Skip to content

added check to avoid seg-fault in HLTScoutingPFProducer #35889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Oct 30, 2021
Merged

added check to avoid seg-fault in HLTScoutingPFProducer #35889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55f02df
added check to avoid seg-fault in HLTScoutingPFProducer
missirol Oct 28, 2021
f6f311a
followup of 55f02dfec4d: fixed check on Ptr
missirol Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions HLTrigger/JetMET/plugins/HLTScoutingPFProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ void HLTScoutingPFProducer::produce(edm::StreamID sid, edm::Event &iEvent, edm::
std::vector<int> candIndices;
if (doCandidates) {
for (auto &cand : jet.getPFConstituents()) {
if (not(cand.isNonnull() and cand.isAvailable())) {
throw cms::Exception("HLTScoutingPFProducer")
<< "invalid reference to reco::PFCandidate from reco::PFJet::getPFConstituents()";
}
if (cand->pt() > pfCandidatePtCut && std::abs(cand->eta()) < pfCandidateEtaCut) {
//search for the candidate in the collection
float minDR2 = 0.0001;
Expand Down