Skip to content

Conversation

@rekovic
Copy link
Contributor

@rekovic rekovic commented Oct 28, 2021

PR description:

This PR is just to comment out two lines to remove message from unexpected CTP7 firmware ID, which is causing hassle for debugging the ongoing collisions. Functionality is not changed. (12_0_X backport of #35873)

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #35873

@rekovic
Copy link
Contributor Author

rekovic commented Oct 28, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2021

A new Pull Request was created by @rekovic for CMSSW_12_0_X.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Oct 28, 2021

backport of #35873

@tvami
Copy link
Contributor

tvami commented Oct 28, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c06f12/20010/summary.html
COMMIT: 84e623c
CMSSW: CMSSW_12_0_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35877/20010/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@rekovic
Copy link
Contributor Author

rekovic commented Oct 28, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Oct 28, 2021

urgent

@perrotta
Copy link
Contributor

perrotta commented Nov 3, 2021

+1

  • The corresponding PR merged in master is Removing obsolete code from CaloLayer1Setup #35940, which implements the proper fix (it removes the obsolete code that originates the flood of spurious messages)
  • In this backport, the simpler solution of just commenting out those (outdated) messages is chosen

@cmsbuild cmsbuild merged commit 1c5c5aa into cms-sw:CMSSW_12_0_X Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants