Skip to content

add ED clients commissioning run type & fix def SPLASH settings #35688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 3 commits into from
Oct 21, 2021
Merged

add ED clients commissioning run type & fix def SPLASH settings #35688

cmsbuild merged 3 commits into from
Oct 21, 2021

Conversation

@pmandrik
Copy link
Contributor

@pmandrik pmandrik commented Oct 15, 2021 •
edited
Loading

PR description:

for ED clients add commissioning run type scenario as ppEra_Run3 -> moved to PR 35365
for ED clients add fix defautl run type SPLASH settings
add some useful printouts for beamhlt, beamhlt & beamspotdip clients

PR validation:

Tested at DQM playback

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Oct 15, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2021 •
edited
Loading

A new Pull Request was created by @pmandrik for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Oct 15, 2021

@pmandrik are you planning a PR in the master, or it is just meant for online DQM (and this is not to be merged, then)?

mmusich
mmusich reviewed Oct 15, 2021
View reviewed changes
DQM/Integration/python/clients/visualization-live-secondInstance_cfg.py Outdated
#scenarios = {'pp_run': 'ppEra_Run2_2016','cosmic_run':'cosmicsEra_Run2_2016','hi_run':'HeavyIons'}
#scenarios = {'pp_run': 'ppEra_Run2_2016','pp_run_stage1': 'ppEra_Run2_2016','cosmic_run':'cosmicsEra_Run2_2016','cosmic_run_stage1':'cosmicsEra_Run2_2016','hi_run':'HeavyIonsEra_Run2_HI'}
scenarios = {'pp_run': 'ppEra_Run3','cosmic_run':'cosmicsEra_Run3','hi_run':'ppEra_Run2_2016_pA'}
scenarios = {'pp_run': 'ppEra_Run3','cosmic_run':'cosmicsEra_Run3','hi_run':'ppEra_Run2_2016_pA', 'commissioning_run':'ppEra_Run3'}
Copy link
Contributor

@mmusich mmusich Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmandrik please undo these changes, I've provided them in #35365 (comment).
Also we think the cosmic era to be more appropriate.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2021

Pull request #35688 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 18, 2021

please test

@pmandrik
Copy link
Contributor Author

pmandrik commented Oct 18, 2021

@pmandrik are you planning a PR in the master, or it is just meant for online DQM (and this is not to be merged, then)?

Yes, please check PR #35715

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7cca3/19714/summary.html
COMMIT: b23f040
CMSSW: CMSSW_12_0_X_2021-10-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35688/19714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 20, 2021

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 21, 2021

backport of #35715

@qliphy
Copy link
Contributor

qliphy commented Oct 21, 2021

+1

@cmsbuild cmsbuild merged commit 82551f2 into cms-sw:CMSSW_12_0_X Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmusich mmusich mmusich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-ok dqm-approved fully-signed orp-approved tests-approved

Projects

None yet

Milestone

CMSSW_12_0_X

Development

Successfully merging this pull request may close these issues.

6 participants

@pmandrik @cmsbuild @perrotta @jfernan2 @qliphy @mmusich