Skip to content

Include realistic CSCBadChambers in Run-3 MC GTs #35637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Oct 13, 2021
Merged

Include realistic CSCBadChambers in Run-3 MC GTs #35637

cmsbuild merged 1 commit into from
Oct 13, 2021

Conversation

@tvami
Copy link
Contributor

@tvami tvami commented Oct 13, 2021

PR description:

PR to update the Run-3 MC GT with a more realistic bad chamber list for the CSC detector as requested in
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4492.html

This includes one bad chamber (ME+2/2/31) and replaces the CSCBadChambers_empty_mc with the new CSCBadChambers_Realistic_211012_mc tag

I've created the following GTs and I show now the diff wrt to the prev GT:

As expected the diffs are in the CSCBadChambers_Realistic_211012_mc tag only.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Oct 13, 2021
@tvami
Copy link
Contributor Author

tvami commented Oct 13, 2021

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35637/25906

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2021

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Oct 13, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee5eb4/19578/summary.html
COMMIT: 113060a
CMSSW: CMSSW_12_1_X_2021-10-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35637/19578/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee5eb4/19578/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee5eb4/19578/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ee5eb4/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecNan+HARVESTRecNan
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ee5eb4/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2796791
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2796763
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -369.871 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -11.641 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03
  • DQMHistoSizes: changed ( 1000.0 ): -11.568 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03
  • DQMHistoSizes: changed ( 1000.0 ): -11.568 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03
  • DQMHistoSizes: changed ( 1000.0 ): -11.352 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3Hits
  • DQMHistoSizes: changed ( 1000.0 ): -11.279 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3Hits
  • DQMHistoSizes: changed ( 1000.0 ): -11.279 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3Hits
  • DQMHistoSizes: changed ( 1000.0 ): -11.062 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 1000.0 ): -11.062 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 1000.0 ): -10.990 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumIsolationMVArun2v1DBnewDMwLT
  • DQMHistoSizes: changed ( 1000.0 ): -10.990 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumIsolationMVArun2v1DBoldDMwLT
  • DQMHistoSizes: changed ( 1000.0 ): ...
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

francescobrivio commented Oct 13, 2021

Test results are quite clean (except the usual MessaggeLogger failures in wf 312.0).
I am not sure about all the RecoTauV/... histograms that changed size. @cms-sw/csc-dpg-l2 any idea if this could be related to the change in CSCBadChambers tag?

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 13, 2021

RecoTauV are due to my PR #35605 which entered into the comparison in this Jenkins test

@francescobrivio
Copy link
Contributor

francescobrivio commented Oct 13, 2021

RecoTauV are due to my PR #35605 which entered into the comparison in this Jenkins test

thanks @jfernan2 for the quick answer!

@francescobrivio
Copy link
Contributor

francescobrivio commented Oct 13, 2021

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild mentioned this pull request Oct 13, 2021
Merged
@qliphy
Copy link
Contributor

qliphy commented Oct 13, 2021

+1

@cmsbuild cmsbuild merged commit dc4b7bf into cms-sw:master Oct 13, 2021
@cmsbuild cmsbuild mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alca-approved code-checks-approved fully-signed orp-approved tests-approved

Projects

None yet

Milestone

CMSSW_12_1_X

Development

Successfully merging this pull request may close these issues.

5 participants

@tvami @cmsbuild @francescobrivio @jfernan2 @qliphy