Diamond dqm #35454

ChrisMisan · 2021-09-28T16:58:42Z

Overview:
This PR introduces new diamond DQM module with following changes to the previous one:

Online/Offline switch, as implemented in pixel DQM: https://github.com/cms-sw/cmssw/blob/master/DQM/CTPPS/plugins/CTPPSPixelDQMSource.cc
Number of OOT windows depends on passed python parameter
Some plots were removed
Added cross rp track correlation plots
Added time distribution plots
Removed most hardcoded values, they are now extracted directly from the data

Lumisection plots:
Following the discussion on lumisection plots it was decided to leave them commented out for the time being due to possible unforeseen issues when parallelized.

Testing
PR was validated by running test/diamond_dqm_test_cfg.py with conditions included in the file.
Memory performance:
This is memory consumption for cmsRun process running whole DQM Online.

cmsbuild · 2021-09-28T17:05:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35454/25610

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/CTPPS/python/ctppsDQM_cff.py modified in PR(s): Diamond sampic dqm #35445

cmsbuild · 2021-09-28T17:05:35Z

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @jan-kaspar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-09-28T17:11:49Z

Is there any reason to not join this PR with #35445 just submitted?
Do they relate each other or does one need the other to run?

ChrisMisan · 2021-09-28T17:27:18Z

Is there any reason to not join this PR with #35445 just submitted? Do they relate each other or does one need the other to run?

Those PRs are independent, there is one common file(ctppsDQM_cff) but changes there are also independent. Thought it'd be cleaner to separate them.

jfernan2 · 2021-09-28T17:28:34Z

OK, but I do understand they do not need each other to run and see results. Thanks

jfernan2 · 2021-09-28T17:28:40Z

please test

cmsbuild · 2021-09-28T18:45:13Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17916c/19207/summary.html
COMMIT: e376503
CMSSW: CMSSW_12_1_X_2021-09-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35454/19207/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1306.0

----- Begin Fatal Exception 28-Sep-2021 19:55:52 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module CTPPSDiamondDQMSource/'ctppsDiamondDQMOfflineSource'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

1330.0

----- Begin Fatal Exception 28-Sep-2021 19:56:42 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module CTPPSDiamondDQMSource/'ctppsDiamondDQMOfflineSource'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

10042.0

----- Begin Fatal Exception 28-Sep-2021 20:02:22 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module CTPPSDiamondDQMSource/'ctppsDiamondDQMOfflineSource'
Exception Message:
No "LHCInfoRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

ChrisMisan · 2021-09-29T10:36:40Z

This PR was tested with GT 120X_dataRun2_v2, there's possibility relval uses "wrong" GT.

jfernan2 · 2021-09-29T11:05:35Z

This PR is in master (i.e. 12_1_X) so you should make sure a corresponding GT to 120X_dataRun2_v2 exists
@tvami @francescobrivio could you help here?

francescobrivio · 2021-09-29T11:40:32Z

This PR is in master (i.e. 12_1_X) so you should make sure a corresponding GT to 120X_dataRun2_v2 exists @tvami @francescobrivio could you help here?

@jfernan2 From the log of 1330.0 I see the actual GT used is auto:run2_mc which currently corresponds to 121X_mcRun2_asymptotic_v4 in master (which is missing the LHCInfoRcd tag).
We are reviewing in these days all the tags needed by CTPPS for all the online & offline GTs and we should have some candidates ready in the next ~couple of days. So this PR will have to wait for the new GTs I guess.

EDIT: other workflows use different autoCond GTs so we will have to review all of them I guess...

vavati · 2021-09-29T13:01:56Z

This PR can be tested with Run2 data and right GT. PPS data are not in MC, just a reminder

francescobrivio · 2021-09-29T13:39:48Z

DQM/CTPPS/python/ctppsDQM_cff.py


 _ctppsDQMOfflineSource = cms.Sequence(
  ctppsPixelDQMOfflineSource
-  + ctppsDiamondDQMSource


@vavati this PR is modifying the _ctppsDQMOfflineSource to include CTPPSDiamondDQMSource.cc which is also modified here so that it requires LHCInfo conditions. So in order to test this PR new GTs will be needed. I don't see how you can test it without modifying the GT (even if you run on run2 data)

My point is: if you have a single ctpps dqm sequence and you use it for both MC and Data you will have to provide all the proper tags in all GTs. If you don't care about ctpps in the MC sequence then you should probably split (or customize) the sequence in a different way for data and for MC.

I hope I understood the issue correctly. Maybe @jfernan2 can comment/suggest as well.

I totally agree with @francescobrivio
We cannot approve a PR which is not going to run in production....

malbouis · 2021-09-29T16:56:27Z

DQM/CTPPS/test/diamond_dqm_test_cfg.py

-# pixel
-process.load('RecoPPS.Local.ctppsPixelLocalTracks_cfi')
-
+process.load('Geometry.VeryForwardGeometry.geometryRPFromDD_2021_cfi')


Why are you using the Run 3 geometry read from the XML file? Was there a specific reason for this choice?

Why are you using the Run 3 geometry read from the XML file? Was there a specific reason for this choice?

Yes, with run3 geometry dqm should produce empty plots for the second station so this is included for validation purposes.

@malbouis
As you know the TAG for a partial Run3 geometry has been released only recently

malbouis · 2021-09-29T17:00:02Z

This PR was tested with GT 120X_dataRun2_v2, there's possibility relval uses "wrong" GT.

@ChrisMisan, would you please add in the description how you tested this PR?

cmsbuild · 2021-10-14T11:34:17Z

Pull request #35454 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

perrotta · 2021-10-14T11:56:54Z

please test

smuzaffar · 2021-10-14T14:36:18Z

please test

cmsbuild · 2021-10-14T18:22:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17916c/19630/summary.html
COMMIT: aa9b785
CMSSW: CMSSW_12_1_X_2021-10-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35454/19630/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17916c/19630/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17916c/19630/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 26 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2750159
DQMHistoTests: Total failures: 53
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 2750079
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 317989.136 KiB( 39 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 12924.539 KiB CTPPS/TimingDiamond
DQMHistoSizes: changed ( 10024.0,... ): -3151.653 KiB CTPPS/TimingFastSilicon
DQMHistoSizes: changed ( 10024.0,... ): 2360.820 KiB CTPPS/DiamondSampic
DQMHistoSizes: changed ( 11634.0,... ): 28913.936 KiB CTPPS/TimingDiamond
DQMHistoSizes: changed ( 11634.0,... ): 2441.273 KiB CTPPS/DiamondSampic
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-10-14T19:21:29Z

+1

cmsbuild · 2021-10-14T19:21:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-10-14T20:43:17Z

Let wait to retest this on an IB which already contains #35445, likely this night 2300, so that we can disentangle the effects of this PR alone...

qliphy · 2021-10-15T02:16:16Z

please test

cmsbuild · 2021-10-15T05:43:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17916c/19648/summary.html
COMMIT: aa9b785
CMSSW: CMSSW_12_1_X_2021-10-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35454/19648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2750425
DQMHistoTests: Total failures: 48
DQMHistoTests: Total nulls: 4
DQMHistoTests: Total successes: 2750351
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 328578.084 KiB( 39 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 12924.539 KiB CTPPS/TimingDiamond
DQMHistoSizes: changed ( 11634.0,... ): 28913.936 KiB CTPPS/TimingDiamond
Checked 170 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

perrotta · 2021-10-15T06:21:23Z

+1

The only changes are in the CTPPS TimingDiamond DQM, as it should

Christopher added 3 commits September 28, 2021 17:28

Diamond DQM

d2a6ea4

Update dqm configuration

f322291

change misleading description

e376503

cmsbuild added this to the CMSSW_12_1_X milestone Sep 28, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Sep 28, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 28, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2021

cmsbuild mentioned this pull request Sep 28, 2021

Diamond sampic dqm #35445

Merged

cmsbuild added tests-rejected and removed tests-started labels Sep 28, 2021

francescobrivio reviewed Sep 29, 2021

View reviewed changes

malbouis reviewed Sep 29, 2021

View reviewed changes

cmsbuild added the code-checks-approved label Oct 14, 2021

cmsbuild added tests-started tests-pending and removed tests-pending tests-started labels Oct 14, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 14, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 14, 2021

cmsbuild added tests-started and removed tests-approved labels Oct 15, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 15, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 15, 2021

cmsbuild merged commit fe01eae into cms-sw:master Oct 15, 2021

Diamond dqm #35454

Diamond dqm #35454

Uh oh!

Conversation

ChrisMisan commented Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 28, 2021

Uh oh!

cmsbuild commented Sep 28, 2021

Uh oh!

jfernan2 commented Sep 28, 2021

Uh oh!

ChrisMisan commented Sep 28, 2021

Uh oh!

jfernan2 commented Sep 28, 2021

Uh oh!

jfernan2 commented Sep 28, 2021

Uh oh!

cmsbuild commented Sep 28, 2021

RelVals

Uh oh!

ChrisMisan commented Sep 29, 2021

Uh oh!

jfernan2 commented Sep 29, 2021

Uh oh!

francescobrivio commented Sep 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vavati commented Sep 29, 2021

Uh oh!

francescobrivio Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

francescobrivio Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

jfernan2 Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

malbouis Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

ChrisMisan Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

vavati Sep 30, 2021

Choose a reason for hiding this comment

Uh oh!

malbouis commented Sep 29, 2021

Uh oh!

cmsbuild commented Oct 14, 2021

Uh oh!

perrotta commented Oct 14, 2021

Uh oh!

smuzaffar commented Oct 14, 2021

Uh oh!

cmsbuild commented Oct 14, 2021

Comparison Summary

Uh oh!

jfernan2 commented Oct 14, 2021

Uh oh!

cmsbuild commented Oct 14, 2021

Uh oh!

perrotta commented Oct 14, 2021

Uh oh!

qliphy commented Oct 15, 2021

Uh oh!

cmsbuild commented Oct 15, 2021

Comparison Summary

Uh oh!

perrotta commented Oct 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

ChrisMisan commented Sep 28, 2021 •

edited

Loading

francescobrivio commented Sep 29, 2021 •

edited

Loading