Skip to content

Conversation

@diemort
Copy link
Contributor

@diemort diemort commented Sep 24, 2021

PR description:

This is a complementary PR to previous backport #35391 related to new files reported in #35399.

PR validation:

Basic PR workflow tests passed. The same tests done in #35391 were done, just the rebase to the IB release missed a few files that should be merged.

if this PR is a backport please specify the original PR and why you need to backport that PR:

#35391 related to #35399

FYI @fabferro @jan-kaspar

@diemort diemort changed the title Backport of ne files for PPS geometry Backport of new files for PPS geometry Sep 24, 2021
@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Sep 24, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2021

A new Pull Request was created by @diemort (Gustavo Silveira) for CMSSW_12_0_X.

It involves the following packages:

  • Geometry/VeryForwardData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @fabferro, @jan-kaspar, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a33a50/18902/summary.html
COMMIT: da3b0a0
CMSSW: CMSSW_12_0_X_2021-09-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35400/18902/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Sep 24, 2021

urgent

@perrotta
Copy link
Contributor

backport of #35399

@perrotta
Copy link
Contributor

+1

  • Backporting the same xml geometry configs merged in the master

@cmsbuild cmsbuild merged commit 2e0e226 into cms-sw:CMSSW_12_0_X Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants