-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Backport of new files for PPS geometry #35400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of new files for PPS geometry #35400
Conversation
|
A new Pull Request was created by @diemort (Gustavo Silveira) for CMSSW_12_0_X. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a33a50/18902/summary.html Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
urgent |
|
backport of #35399 |
|
+1
|
PR description:
This is a complementary PR to previous backport #35391 related to new files reported in #35399.
PR validation:
Basic PR workflow tests passed. The same tests done in #35391 were done, just the rebase to the IB release missed a few files that should be merged.
if this PR is a backport please specify the original PR and why you need to backport that PR:
#35391 related to #35399
FYI @fabferro @jan-kaspar