Migrate TrackingRegions to esConsumes

[makortel]

PR description:

This PR is part of #31061 and reworks TrackingRegion classes, classes that create TrackingRegions, and classes that use TrackingRegions to support esConsumes. in short the EventSetup accesses within TrackingRegion classes are moved to classes that create TrackingRegions.

This PR completes the rework started in #35081 and continued in #35269.

Resolves cms-sw/framework-team#264.

PR validation:

Tested that limited matrix runs in in earlier IB on top of #35269. After the rebase, tested that code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35393/25498

• This PR adds an extra 196KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoMuon/TrackerSeedGenerator/plugins/TSGFromL1Muon.cc modified in PR(s): Added esConsumes to SeedFromProtoTrack #35347
  • File RecoTracker/SpecialSeedGenerators/interface/CosmicRegionalSeedGenerator.h modified in PR(s): finalize esConsumes for RecoTracker/SpecialSeedGenerators #35367
  • File RecoTracker/SpecialSeedGenerators/src/CosmicRegionalSeedGenerator.cc modified in PR(s): finalize esConsumes for RecoTracker/SpecialSeedGenerators #35367

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• Calibration/HcalIsolatedTrackReco (alca)
• FastSimulation/Muons (fastsim)
• FastSimulation/Tracking (fastsim)
• HLTrigger/btau (hlt)
• RecoEgamma/EgammaElectronProducers (reconstruction)
• RecoHI/HiMuonAlgos (reconstruction)
• RecoHI/HiTracking (reconstruction)
• RecoMuon/GlobalTrackingTools (reconstruction)
• RecoMuon/TrackerSeedGenerator (reconstruction)
• RecoPixelVertexing/PixelLowPtUtilities (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)
• RecoTauTag/HLTProducers (hlt)
• RecoTracker/ConversionSeedGenerators (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• RecoTracker/TkHitPairs (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)
• RecoTracker/TkTrackingRegions (reconstruction)

@malbouis, @civanch, @yuanchao, @lveldere, @slava77, @ssekmen, @mdhildreth, @Martin-Grunewald, @missirol, @cmsbuild, @sbein, @jpata, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@emilbols, @felicepantaleo, @jainshilpi, @abbiendi, @swozniewski, @Martin-Grunewald, @bsunanda, @jazzitup, @mbluj, @demuller, @mmusich, @cericeci, @JyothsnaKomaragiri, @JanFSchulte, @jhgoh, @dgulhan, @missirol, @sobhatta, @trocino, @lgray, @rociovilar, @sscruz, @Sam-Harper, @afiqaize, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @matt-komm, @ebrondol, @mtosi, @amagitte, @AlexDeMoor, @HuguesBrun, @mandrenguyen, @varuns23, @miheejo, @Fedespring, @calderona, @yenjie, @lecriste, @kurtejung, @gpetruc, @wrtabb, @andrzejnovak, @yetkinyilmaz, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c08640/18880/summary.html
COMMIT: d783258
CMSSW: CMSSW_12_1_X_2021-09-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35393/18880/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 2 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c08640/18880/llvm-analysis/esrget-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[yuanchao]

Hi Matti, the SA test points out the followings are still using the deprecated function. (introduced by #35269 ?) Will they got fixed?

'''
iSetup.get().get(hfield);
...
iSetup.get().get(hmaker);
'''

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c08640/18880/llvm-analysis/esrget-sa.txt

[makortel]

@yuanchao Thanks for the reminder, I'll address those shortly (my aim was to do that, but apparently I forgot in the end).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35393/25514

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/SpecialSeedGenerators/interface/CosmicRegionalSeedGenerator.h modified in PR(s): finalize esConsumes for RecoTracker/SpecialSeedGenerators #35367
  • File RecoTracker/SpecialSeedGenerators/src/CosmicRegionalSeedGenerator.cc modified in PR(s): finalize esConsumes for RecoTracker/SpecialSeedGenerators #35367

[tvami]

+alca

• was signed already before the rebase

[missirol]

Looks like the tests requested 3 days ago did not really start. Trying to restart them.

[missirol]

@cmsbuild, please abort

[missirol]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c08640/19272/summary.html
COMMIT: ef18849
CMSSW: CMSSW_12_1_X_2021-09-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35393/19272/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[slava77]

+reconstruction

for #35393 ef18849

• code changes are technical, in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1