-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fixes for PPS geometry on Pixel sensors and materials #35346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
90 commits
Select commit
Hold shift + click to select a range
8a32284
Remove EventSetup dependency from CosmicLayerPairs
Dr15Jones e9f86b5
Remove EventSetup use in CosmicHitPairGeneratorFromLayerPair
Dr15Jones aa435c0
Removed EventSetup use in CosmicLayerTriplets
Dr15Jones bd47432
Removed Eventsetup dependency from CosmicHitTripletGenerator
Dr15Jones f13a105
Added esConsumes calls to SeedGeneratorForCosmics
Dr15Jones cc07c62
add GPU to runTheMatrix
7d8f062
add GPU to runTheMatrix
5cec229
update runTheMatrix following comments
282edcf
update lowercase for option
ce3f561
Simplify optional dict
9c75ded
Use esConsumes in ParticleGun base classes
Dr15Jones b7862c5
migrate to argparse
7f17b26
add branch
6135782
update
69f81ed
Update HcalDDDRecConstants.cc
iarspider 1734e7f
bring back wmcontrol default
6707ba0
remove unnecessary const,nargs from revertDqmio
bfdc428
code clean up
de6a246
small clean up on default value
9954e5c
reassembling files from branch geoFix121X
diemort 59686e6
correcting Vaccum entries for new materials
diemort 069dc6c
Better handling of commented out code
Dr15Jones fc16ab2
Move MessageLogger default configuration to be part of Process
makortel deafbcc
Print warning from python if non-default MessageLogger is used in a S…
makortel e0a7781
Add support for the gpu modifier at HLT
fwyzard 84155b6
Make the Patatrack workflows apply the 'gpu' modifier to the HLT step
fwyzard dd84d38
Simplify the GPU pixel local reconstruction
fwyzard 4a33d57
Fix #35225
lecriste 148a7a5
Add protection for multiple subProcesses
lecriste 59fc337
Add missing #include to 3 other files
iarspider f0a7089
Merge branch 'master' into patch-1
iarspider c85ee6e
Print warning for empty PlotterFolder
lecriste 5b7ec18
Removed unnecessary includes
Dr15Jones daaa11d
Use esConsumes in FastTSGFromPropagation
Dr15Jones d1a2075
Add esConsumes to TSGForRoadSearch
Dr15Jones a3783c8
Added esConsumes to TSGFromPropagation
Dr15Jones e44a0d4
Added esConsumes to TrackerSeedCleaner
Dr15Jones 002868b
Fixed incorrect use of consumesCollector in FastTSGFromL2Muon
Dr15Jones 7c96d7e
Added esConsumes to TSGFromL2Muon
Dr15Jones 2f5b4ea
fixed undefined behavior in PixelDigi::pixelToChannel(int row, int col)
ferencek 21cbd1d
migrate DTNoiseCalibration
swagata87 4d2c277
migrate DTTPDeadWriter
swagata87 a9643a4
migrate DTT0Correction
swagata87 bf0a6dd
DTTTrigCorrectionFirst
swagata87 82317dd
migrate DTT0CalibrationRMS
swagata87 a918e9b
migrate DTTTrigWriter, DTVDriftWriter
swagata87 ddc4c6e
migrate DTT0FEBPathCorrection
swagata87 ca12a01
migrate DTT0ChamberReferenceCorrection
swagata87 c4c13de
migrate DTT0Calibration
swagata87 6ea557b
migrate DTResidualCalibration
swagata87 2dc9e5e
DTNoiseComputation
swagata87 9a9bf61
migrate DTFakeT0ESProducer
swagata87 93237cb
migrate DTVDriftSegmentCalibration
swagata87 dc2424e
migrate DTTTrigOffsetCalibration
swagata87 1abbf70
Trying to add a new AlCaReco package forHcal IsoTrack to reduce datav…
57a1191
code checks
swagata87 edbcee9
Small fix to the debug statement
0800172
Code check
ed5ce8f
Migration of CSCCommissioning/CSCFileDumper module to thread safe edm…
barvic ff2ea8e
Merge pull request #35258 from Dr15Jones/esConsumesCosmicSeedGenerator
cmsbuild 53b8d1f
Merge pull request #35336 from swagata87/dev_migrateDT
cmsbuild 9b78054
Merge pull request #35343 from barvic/CSCCommissioning_migrate_to_thr…
cmsbuild 6a33ae6
introducing loop boundaries instead of doing if comparisons in each i…
ferencek 4b97950
Fix -t option for python3
makortel 5f07f09
Take care of Sim Geometry definition
6a1fe83
Merge pull request #35319 from lecriste/parallelValidation
cmsbuild 5292fac
Merge pull request #35298 from makortel/messageLoggerProcess
cmsbuild 87fa9df
Merge pull request #35286 from iarspider/patch-1
cmsbuild de26e11
Merge pull request #35312 from bsunanda/Run3-alca201
cmsbuild 0c0614e
Merge pull request #35273 from Dr15Jones/esConsumesParticleGuns
cmsbuild 3cec5df
deleted FastSimulation/EventProducer
sbein c63368f
removing dead assignment
ferencek 8029159
removed config file using depricated FamosManager/Producer
sbein 0ec8e62
Merge pull request #34978 from fwyzard/HLT_customisation_for_GPU_121x
cmsbuild 5d10e5e
Merge pull request #35263 from srimanob/121_runTheMatrixGPUWorkflow
cmsbuild 788116d
Merge pull request #35349 from bsunanda/Run3-hcx322
cmsbuild 721c5bb
Add the tree maker for IsoTrack analysis using the new calibration ob…
a787d33
correcting dict2021 to comply with master
diemort d5d0c6e
TrackToTrackComparisonHists :use correct handle to check if collectio…
mmusich b493773
Merge pull request #35327 from Dr15Jones/esConsumesTSGFromL2Muon
cmsbuild eaae714
removed FastSimulation/EventProducer from CMSSWReleaseDependency.rules
sbein 5a417ca
Merge pull request #35348 from makortel/addOnTestOptionT
cmsbuild e9a68e6
Merge pull request #35337 from CMSTrackerDPG/siPixChRwghtUBSAN
cmsbuild 941ccdb
Merge pull request #35352 from sbein/from-CMSSW_12_1_X_2021-09-20-2300
cmsbuild 067a5ad
Merge pull request #35353 from mmusich/fixTrackToTrackComparisonHists
cmsbuild 7e3086e
Merge pull request #35339 from bsunanda/Run3-alca201X
cmsbuild 14e2db4
reassembling files from branch geoFix121X
diemort 368fe9a
correcting Vaccum entries for new materials
diemort b01073e
correcting dict2021 to comply with master
diemort 25f5ba2
Merge branch 'geoFix121pre2' of https://github.com/CTPPS/cmssw into g…
diemort File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand this change, I think this line was already removed, see master
https://github.com/cms-sw/cmssw/blob/master/Configuration/Geometry/python/dict2021Geometry.py#L379-L382
Why does git compare something which is not master as it should?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I haven't change other lines apart of adding P7. I'll clean it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand why Git is showing changes that were made in previous PRs.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch appears to be based on CMSSW_12_1_X_2021-08-27-1100, and the shown diff is wrt. that instead of
master. These lines have been changed both in this andmasterbranch in between, so technically there could be a merge conflict. Apparently this case is straightforward-enough (the change is the same) that GitHub would be able to merge the branch intomaster.As @perrotta pointed out, rebasing to a recent IB should remove such lines in the diff.