-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Run3-gex93B Modify Run3 and Phase2D86 geometry due to change in some material xml files (Backport #35290) #35292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_0_X. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b3786/18640/summary.html Comparison SummarySummary:
|
|
+1 |
|
@srimanob Run3 production has been launched with 12_0_X, and this PR indeed bring changes. |
|
We discussed at the recent SIM meeting if we should backport to 12_0 and agree that we prepare backports of all PRs related to geometry. This does not mean that all will be merged. We do this in order to be ready if a decision would be made to have 12_0 geometry equal to 12_1. |
|
Thanks @civanch |
|
hold |
|
Pull request has been put on hold by @srimanob |
|
unhold |
|
Following the release meeting, this PR can merge. The 12_0 production uses 12_0_1 but with DB geometry equivalent to XML we have in 12_0_0. In principle, production can be controlled by GT if new CMSSW will be needed in future. Note that, in the 12_0_X, autocond currently points to the new GT (with updated geometry) already |
|
+Upgrade |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
urgent |
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeOuterZplus.xml', | ||
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeOuterZminus.xml', | ||
| 'Geometry/TrackerCommonData/data/PhaseI/v2/pixbarmaterial.xml', | ||
| 'Geometry/TrackerCommonData/data/PhaseI/v3/pixbarmaterial.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to understand how this backport was designed: this line is from #34983, and it was apparently forgotten in some previous backport of that PR merged in master: could you please explain the logic and the history of previous backports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a few PR for 12_1_X and these are combined in the backport PR. Please merge this PR. It is in the way of other back-outings
|
@bsunanda, I'm trying to follow the complicate line of backports from several sources... |
|
+1
|
PR description:
Modify Run3 and Phase2D86 geometry due to change in some material xml files (Backport #35290)
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport #35290 and #35210