Skip to content

Conversation

@bsunanda
Copy link
Contributor

PR description:

Modify Run3 and Phase2D86 geometry due to change in some material xml files (Backport #35290)

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #35290 and #35210

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_0_X.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/EcalCommonData (geometry)
  • Geometry/TrackerCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @rchatter, @JanFSchulte, @kpedro88, @argiro, @Martin-Grunewald, @thomreis, @VinInn, @simonepigazzini, @mmusich, @ghugo83, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b3786/18640/summary.html
COMMIT: 8440c56
CMSSW: CMSSW_12_0_X_2021-09-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35292/18640/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3119 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 80514
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2918027
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 1 / 38 workflows

@cvuosalo
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

@perrotta @qliphy
Could you please confirm no change policy for production release in this case? Thanks.

@qliphy
Copy link
Contributor

qliphy commented Sep 17, 2021

@srimanob Run3 production has been launched with 12_0_X, and this PR indeed bring changes.
Adding @rappoccio who may comment more.
Or we can discuss this at next ORP.

@civanch
Copy link
Contributor

civanch commented Sep 17, 2021

We discussed at the recent SIM meeting if we should backport to 12_0 and agree that we prepare backports of all PRs related to geometry. This does not mean that all will be merged. We do this in order to be ready if a decision would be made to have 12_0 geometry equal to 12_1.

@srimanob
Copy link
Contributor

Thanks @civanch
I misunderstood that we need to merge it when PR is ready. So maybe I will hold it until we have a discussion at ORP.

@srimanob
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @srimanob
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Sep 18, 2021
@srimanob
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Sep 21, 2021
@srimanob
Copy link
Contributor

srimanob commented Sep 21, 2021

Following the release meeting, this PR can merge.

The 12_0 production uses 12_0_1 but with DB geometry equivalent to XML we have in 12_0_0. In principle, production can be controlled by GT if new CMSSW will be needed in future.

Note that, in the 12_0_X, autocond currently points to the new GT (with updated geometry) already
https://github.com/cms-sw/cmssw/blob/CMSSW_12_0_X/Configuration/AlCa/python/autoCond.py#L71
120X_mcRun3_2021_realistic_v7 is advance one compared to 120X_mcRun3_2021_realistic_v5 (GS) and 120X_mcRun3_2021_realistic_v6 (DR) used in production. v7 include updated in geometry introduced in 12_0_1.

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cvuosalo
Copy link
Contributor

urgent

@perrotta
Copy link
Contributor

perrotta commented Sep 23, 2021

backport of #35290 and (part of) #34983 and #35210

'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeOuterZplus.xml',
'Geometry/TrackerCommonData/data/PhaseI/v2/pixfwdbladeOuterZminus.xml',
'Geometry/TrackerCommonData/data/PhaseI/v2/pixbarmaterial.xml',
'Geometry/TrackerCommonData/data/PhaseI/v3/pixbarmaterial.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to understand how this backport was designed: this line is from #34983, and it was apparently forgotten in some previous backport of that PR merged in master: could you please explain the logic and the history of previous backports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a few PR for 12_1_X and these are combined in the backport PR. Please merge this PR. It is in the way of other back-outings

@bsunanda
Copy link
Contributor Author

@perrotta @qliphy Please merge

@qliphy
Copy link
Contributor

qliphy commented Sep 24, 2021

@perrotta @qliphy Please merge

I am fine with this PR. I will let @perrotta have a check again and merge later if possible.

@perrotta
Copy link
Contributor

@bsunanda, I'm trying to follow the complicate line of backports from several sources...
Why there is not the backport of the "v2" of tecmaterial.xml? Is it the same as "v1", and therefore it is notbackported for simplicity?

@bsunanda
Copy link
Contributor Author

@perrotta We found later there is no need to have "v2" for tecmaterial. So a later PR (#35290) deletes "v2" for tecmaterial and current version in 12_1_X makes use of v1 version of tecmaterial.

@perrotta
Copy link
Contributor

+1

  • Backport of geometry updates that will not be picked up in the standard production workflows, for which no changes are expected

@cmsbuild cmsbuild merged commit 42f6122 into cms-sw:CMSSW_12_0_X Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants