Skip to content

Get rid of the unneeded conf_ class member in SiPixelPhase1EfficiencyExtras #35102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Sep 1, 2021
Merged

Get rid of the unneeded conf_ class member in SiPixelPhase1EfficiencyExtras #35102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions DQM/SiPixelPhase1Track/plugins/SiPixelPhase1EfficiencyExtras.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
#include "FWCore/Framework/interface/MakerMacros.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/EventSetup.h"
#include "DataFormats/Common/interface/Handle.h"

#include "FWCore/ParameterSet/interface/ParameterSet.h"

// DQM Framework
#include "DQMServices/Core/interface/DQMStore.h"
Expand All @@ -45,24 +42,19 @@ class SiPixelPhase1EfficiencyExtras : public DQMEDHarvester {

void dqmEndJob(DQMStore::IBooker& iBooker, DQMStore::IGetter& iGetter) override;

std::string effFolderName_;
std::string vtxFolderName_;
std::string instLumiFolderName_;

private:
edm::ParameterSet conf_;
const std::string effFolderName_;
const std::string vtxFolderName_;
const std::string instLumiFolderName_;
};

SiPixelPhase1EfficiencyExtras::SiPixelPhase1EfficiencyExtras(const edm::ParameterSet& iConfig) : conf_(iConfig) {
SiPixelPhase1EfficiencyExtras::SiPixelPhase1EfficiencyExtras(const edm::ParameterSet& iConfig)
: effFolderName_(iConfig.getParameter<std::string>("EffFolderName")),
vtxFolderName_(iConfig.getParameter<std::string>("VtxFolderName")),
instLumiFolderName_(iConfig.getParameter<std::string>("InstLumiFolderName")) {
LogInfo("PixelDQM") << "SiPixelPhase1EfficiencyExtras::SiPixelPhase1EfficiencyExtras: Hello!" << endl;
effFolderName_ = conf_.getParameter<std::string>("EffFolderName");
vtxFolderName_ = conf_.getParameter<std::string>("VtxFolderName");
instLumiFolderName_ = conf_.getParameter<std::string>("InstLumiFolderName");
}

SiPixelPhase1EfficiencyExtras::~SiPixelPhase1EfficiencyExtras() {
// do anything here that needs to be done at desctruction time
// (e.g. close files, deallocate resources etc.)
LogInfo("PixelDQM") << "SiPixelPhase1EfficiencyExtras::~SiPixelPhase1EfficiencyExtras: Destructor" << endl;
}

Expand Down