Skip to content

[11.3.X] Miscellaneous fixes to Alignment/OfflineValidation all-in-one tool #34878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Aug 16, 2021
Merged

[11.3.X] Miscellaneous fixes to Alignment/OfflineValidation all-in-one tool #34878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8f45e9
introduce python compilation time check of the configuration files pr…
mmusich Aug 13, 2021
b04fe53
fix miscelleanous mistakes in the all-in-one template configutations
mmusich Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Alignment/OfflineValidation/python/TkAlAllInOneTool/offlineValidationTemplates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
## Load and Configure OfflineValidation and Output File
##
process.load("Alignment.OfflineValidation.TrackerOfflineValidation_.oO[offlineValidationMode]Oo._cff")
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..compressionSettings = compressionSettings,
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..compressionSettings = compressionSettings
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..Tracks = 'FinalTrackRefitter'
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..trajectoryInput = 'FinalTrackRefitter'
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..moduleLevelHistsTransient = .oO[offlineModuleLevelHistsTransient]Oo.
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..moduleLevelProfiles = .oO[offlineModuleLevelProfiles]Oo.
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..stripYResiduals = .oO[stripYResiduals]Oo.
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..maxTracks = .oO[maxtracks]Oo./ .oO[parallelJobs]Oo.
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..maxTracks = int(.oO[maxtracks]Oo./.oO[parallelJobs]Oo.)
process.TrackerOfflineValidation.oO[offlineValidationMode]Oo..chargeCut = .oO[chargeCut]Oo.
"""

Expand Down
2 changes: 1 addition & 1 deletion Alignment/OfflineValidation/python/TkAlAllInOneTool/primaryVertexResolutionTemplates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
isMultipleRuns=False
if(isinstance(runboundary, (list, tuple))):
isMultipleRuns=True
print "Multiple Runs are selected"
print("Multiple Runs are selected")

if(isMultipleRuns):
process.source.firstRun = cms.untracked.uint32(int(runboundary[0]))
Expand Down
3 changes: 1 addition & 2 deletions Alignment/OfflineValidation/python/TkAlAllInOneTool/zMuMuValidationTemplates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
ZMuMuValidationTemplate="""

compressionSettings = 207
###### MuSclFit SETTINGS ##############################################


### MuScleFit specific configuration

process.looper = cms.Looper(
Expand Down
10 changes: 10 additions & 0 deletions Alignment/OfflineValidation/test/test_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,16 @@ validateAlignments.py -c validation_config.ini -N testingAllInOneTool --dryRun |

printf "\n\n"

echo " TESTING all-in-one tool configuration ..."
FILES="$PWD/testingAllInOneTool/*_cfg.py"
for f in $FILES
do
echo "Processing $f file..."
python $FILE/$f || die "Failure compiling test configuration" $?
done

printf "\n\n"

echo " TESTING Primary Vertex Validation run-by-run submission ..."
submitPVValidationJobs.py -j UNIT_TEST -D /HLTPhysics/Run2016C-TkAlMinBias-07Dec2018-v1/ALCARECO -i ${LOCAL_TEST_DIR}/testPVValidation_Relvals_DATA.ini -r --unitTest || die "Failure running PV Validation run-by-run submission" $?

Expand Down