Skip to content

[12.0.X] Miscellaneous fixes to Alignment/OflineValidation all-in-one tool #34877

Merged
cmsbuild merged 2 commits intocms-sw:CMSSW_12_0_Xfrom
mmusich:miscellaneousFixesAlignmentOfflineValidation_allInOneTool_12_0_X
Aug 16, 2021
Merged

[12.0.X] Miscellaneous fixes to Alignment/OflineValidation all-in-one tool #34877
cmsbuild merged 2 commits intocms-sw:CMSSW_12_0_Xfrom
mmusich:miscellaneousFixesAlignmentOfflineValidation_allInOneTool_12_0_X

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 13, 2021

backport of #34876

PR description:

The goal of this PR is to fix some miscelleanous mistakes in the all-in-one template configurations introduced since the last alignment campaigns (commit 10f0cad).
I profit of the PR to enhance the unit test to check at compilation time the soundness of the python configuration produced by the test themselves (commit 7916c58 ).

PR validation:

Run the Alignment/OfflineValidation unit tests via scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #34876

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 13, 2021

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Aug 13, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30fff3/17773/summary.html
COMMIT: 7916c58
CMSSW: CMSSW_12_0_X_2021-08-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34877/17773/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998529
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 14, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 16, 2021

+1
tested in master IB

@cmsbuild cmsbuild merged commit 1ef8943 into cms-sw:CMSSW_12_0_X Aug 16, 2021
@mmusich mmusich deleted the miscellaneousFixesAlignmentOfflineValidation_allInOneTool_12_0_X branch August 16, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants