[GCC11] Add missing #include for std::size_t definition #34825

iarspider · 2021-08-10T08:01:51Z

Error log: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-09-1100/HeterogeneousCore/CUDAUtilities
Error message:

In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/src/deviceAllocatorStatus.cc:1:
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/interface/deviceAllocatorStatus.h:10:9: error: 'size_t' does not name a type
    10 |         size_t free;
      |         ^~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/ada76bbef987ba1823d9aebd3a0b2f87/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/interface/deviceAllocatorStatus.h:5:1: note: 'size_t' is defined in header '<cstddef>'; did you forget to '#include <cstddef>'?
    4 | #include <map>
  +++ |+#include <cstddef>
    5 |

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

iarspider · 2021-08-10T08:02:05Z

please test for slc7_amd64_gcc11

cmsbuild · 2021-08-10T08:07:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34825/24596

This PR adds an extra 12KB to repository

cmsbuild · 2021-08-10T08:07:47Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

HeterogeneousCore/CUDAUtilities (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-08-11T10:06:08Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee046/17690/summary.html
COMMIT: 6a1e144
CMSSW: CMSSW_12_1_X_2021-08-09-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34825/17690/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee046/17690/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee046/17690/git-merge-result

Build

I found compilation error when building:

>> Cuda Device Link tmp/slc7_amd64_gcc11/src/HeterogeneousCore/CUDAUtilities/test/gpuPrefixScan_t/gpuPrefixScan_t_cudadlink.o 
>> Building binary gpuPrefixScan_t
Copying tmp/slc7_amd64_gcc11/src/HeterogeneousCore/CUDAUtilities/test/gpuPrefixScan_t/gpuPrefixScan_t to productstore area:
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu: In function 'void go(bool) [with T = float; int NS = 2; U = float; LL = double]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:145:15: error: array subscript 'long unsigned int[0]' is partly outside array bounds of 'float [1]' [-Werror=array-bounds]
  145 |           *k = (*k >> sh) << sh;
      |           ~~~~^~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-09-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:139:6: note: while referencing 'k1'
  139 |         auto k1 = a[ind[j]];
      |      ^

smuzaffar · 2021-08-11T10:14:53Z

please test

smuzaffar · 2021-08-11T10:16:07Z

gcc11 build errors are fix ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee046/17690/build-logs/HeterogeneousCore/CUDAUtilities/log.html ) though we have still have few more in tests which can be fixed in a different PR

cmsbuild · 2021-08-11T21:57:35Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee046/17700/summary.html
COMMIT: 6a1e144
CMSSW: CMSSW_12_1_X_2021-08-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34825/17700/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

34834.2134834.21_TTbar_14TeV+2026D76PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D76PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
34834.992134834.9921_TTbar_14TeV+2026D76PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D76PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999420
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2999391
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

smuzaffar · 2021-08-12T08:16:24Z

@fwyzard any objection on this change? If this is the correct fix then it should fix many build/link errors for gcc11 IBs

fwyzard · 2021-08-12T08:32:06Z

no objections to the change itself, but why is it needed ?
isn't std::size_t the same type as size_t ?

also, if we make the change we need to add an explicit comment about it, as per the file's license

HeterogeneousCore/CUDAUtilities/interface/deviceAllocatorStatus.h

Co-authored-by: Andrea Bocci <[email protected]>

iarspider · 2021-08-12T08:41:23Z

size_t and std::size_t are the same by definition:

#include <stddef.h>
namespace std 
{
  using ::ptrdiff_t;
  using ::size_t;
}

When writing in C++, one can either include stddef.h and use regular size_t, or include cstddef and use std::size_t. Of course, when writing in pure C, the latter is not an option.

fwyzard · 2021-08-12T08:44:07Z

please test

fwyzard · 2021-08-12T08:44:17Z

+heterogeneous

cmsbuild · 2021-08-12T08:44:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34825/24641

This PR adds an extra 12KB to repository

cmsbuild · 2021-08-12T08:45:16Z

Pull request #34825 was updated. can you please check and sign again.

cmsbuild · 2021-08-12T12:43:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee046/17726/summary.html
COMMIT: 1d6b8dd
CMSSW: CMSSW_12_1_X_2021-08-12-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34825/17726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999420
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2999391
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

perrotta · 2021-08-12T12:47:04Z

+1

Technical

[GCC11] Add missing #include for std::size_t definition

6a1e144

cmsbuild added this to the CMSSW_12_1_X milestone Aug 10, 2021

cmsbuild added code-checks-pending heterogeneous-pending orp-pending pending-signatures tests-started labels Aug 10, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 10, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 11, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 11, 2021

cmsbuild added tests-rejected tests-started and removed tests-started tests-rejected labels Aug 11, 2021

fwyzard reviewed Aug 12, 2021

View reviewed changes

HeterogeneousCore/CUDAUtilities/interface/deviceAllocatorStatus.h Show resolved Hide resolved

Update HeterogeneousCore/CUDAUtilities/interface/deviceAllocatorStatus.h

1d6b8dd

Co-authored-by: Andrea Bocci <[email protected]>

cmsbuild removed tests-started code-checks-approved labels Aug 12, 2021

cmsbuild added code-checks-pending tests-pending labels Aug 12, 2021

cmsbuild added fully-signed heterogeneous-approved tests-started and removed pending-signatures tests-pending heterogeneous-pending labels Aug 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 12, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 12, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 12, 2021

cmsbuild merged commit fa9d6a3 into cms-sw:master Aug 12, 2021

This was referenced Aug 12, 2021

Add GEM unpacker in L1Repack FullMC and temporary load of GEM geometry to hltGetConfiguration #34788

Closed

initialize Trackster::iterationIndex_ #34858

Merged

[GCC11] Add missing #include for std::size_t definition #34825

[GCC11] Add missing #include for std::size_t definition #34825

Uh oh!

Conversation

iarspider commented Aug 10, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

iarspider commented Aug 10, 2021

Uh oh!

cmsbuild commented Aug 10, 2021

Uh oh!

cmsbuild commented Aug 10, 2021

Uh oh!

cmsbuild commented Aug 11, 2021

Build

Uh oh!

smuzaffar commented Aug 11, 2021

Uh oh!

smuzaffar commented Aug 11, 2021

Uh oh!

cmsbuild commented Aug 11, 2021

RelVals-INPUT

Comparison Summary

Uh oh!

smuzaffar commented Aug 12, 2021

Uh oh!

fwyzard commented Aug 12, 2021

Uh oh!

Uh oh!

iarspider commented Aug 12, 2021

Uh oh!

fwyzard commented Aug 12, 2021

Uh oh!

fwyzard commented Aug 12, 2021

Uh oh!

cmsbuild commented Aug 12, 2021

Uh oh!

cmsbuild commented Aug 12, 2021

Uh oh!

cmsbuild commented Aug 12, 2021

Comparison Summary

Uh oh!

perrotta commented Aug 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants