-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add additional paths to customizeHLTIter0ToMkFit #34793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional paths to customizeHLTIter0ToMkFit #34793
Conversation
The other paths also include hltIter0PFlowCkfTrackCandidates and need the change in order to be self-consistent.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34793/24501
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
code-checks |
|
it looks like the bot is out for lunch or dinner |
@smuzaffar |
|
@slava77 , most of code check jobs run on lxplus nodes and for last few days we have issues with some of lxplus nodes where singularity can not run [a]. Unfortunately code checks for this PR was run 4 times on buggy nodes. Anyway, code checks are running now and results will be available soon |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34793/24536
|
|
please test |
|
@smuzaffar is the comparison test for this pr stuck in some endless loop? Seems to be doing the same thing over and over for the past 12 hours. |
|
@Dr15Jones not really, https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/44643/ should finish in 10/20 mins. Normally it takes 2 hours when job starts. |
|
@smuzaffar I checked this build before going to bed last night and the camparison had already been running for more than 2 hours. I then get up this morning and it still says it is running. |
|
Here is the sequence of jobs
all look good in terms of jobs. As jenkins was very busy last night that is why there were delays beteween various jobs |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-235cd6/17599/summary.html Comparison SummarySummary:
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The other paths also include hltIter0PFlowCkfTrackCandidates and need the change in order to be self-consistent.
The inconsistency was found by #34735
PR validation:
I ran workflow 11634.7 with this change and the changes from #34735 and it now runs fine.