Add GEM unpacker in L1Repack FullMC and temporary load of GEM geometry to hltGetConfiguration

[srimanob]

PR description:

Move to #34788

This PR is to fix two issues when L1REPACK is used for Run3. The error messages w/o this PR is mentioned at the end of the PR description.
(1) no GEM unpacker defined in SimL1EmulatorRepack. It is solved in this PR.
(2) when hltGetConfiguration is used, GEM geometry is not loaded properly. This PR introduced a temporary fix.

PR validation:

The RAW input can be picked from /afs/cern.ch/user/s/srimanob/public/ForGEML1T/step2.root. It is a RAW file produced from CMSSW_12_0_0_pre4 with wf 11634.21.

To test (1), the following cmsDriver run fine.
cmsDriver.py --process reHLT -s L1REPACK:FullMC,HLT:@relval2021 --conditions auto:phase1_2021_realistic --datatier GEN-SIM-RAW -n -1 --eventcontent RAWSIM --geometry DB:Extended --era Run3 --filein file:step2.root --fileout file:step3_reHLT.root --python reHLT_ProdLike_2021.py --no_exec

To test (2), the following config can run fine.
hltGetConfiguration /dev/CMSSW_12_0_0/GRun/V2 --process reHLT --globaltag auto:phase1_2021_realistic --mc --unprescale --paths HLTriggerFirstPath,HLT_IsoMu24_v13,HLT_Mu50_v13,HLTriggerFinalPath --output minimal --input file:step2.root --l1-emulator FullMC --customise HLTrigger/Configuration/customizeHLTforCMSSW.customiseForRun3GEMGeometry > test_reHLT.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, and no need of backport

Note

Issue of (1): solved in this PR

----- Begin Fatal Exception 05-Aug-2021 05:33:59 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonOverlapTrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Prefetching for module GEMPadDigiClusterProducer/'simMuonGEMPadDigiClusters'
   [8] Calling method for module GEMPadDigiProducer/'simMuonGEMPadDigis'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMDigi>
Looking for module label: simMuonGEMDigis
Looking for productInstanceName: 

Issue of (2): temporary solution is provided for now

----- Begin Fatal Exception 05-Aug-2021 05:59:31 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  stream begin Run run: 1 stream: 1
   [1] Calling method for module GEMPadDigiClusterProducer/'simMuonGEMPadDigiClusters'
Exception Message:
No data of type "GEMGeometry" with label "" in record "MuonGeometryRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 05-Aug-2021 05:59:31 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  stream begin Run run: 1 stream: 3
   [1] Calling method for module GEMPadDigiProducer/'simMuonGEMPadDigis'
Exception Message:
No data of type "GEMGeometry" with label "" in record "MuonGeometryRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

[srimanob]

FYI @dildick @jshlee @rekovic

Note that Run3 era should be called already with
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/CustomConfigs.py#L123-L127

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24468

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• Configuration/StandardSequences (operations)

@perrotta, @silviodonato, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[srimanob]

Hi @Martin-Grunewald @fwyzard
Do you have a hint of what can make the difference between the following command? Thanks in advance.

(1)
cmsDriver.py --process reHLT -s L1REPACK:FullMC,HLT:@relval2021 --conditions auto:phase1_2021_realistic --datatier GEN-SIM-RAW -n -1 --eventcontent RAWSIM --geometry DB:Extended --era Run3 --filein file:step2.root --fileout file:step3_reHLT.root --python reHLT_ProdLike_2021.py --no_exec

(2)
hltGetConfiguration /dev/CMSSW_12_0_0/GRun/V2 --process reHLT --globaltag auto:phase1_2021_realistic --mc --unprescale --paths HLTriggerFirstPath,HLT_IsoMu24_v13,HLT_Mu50_v13,HLTriggerFinalPath --output minimal --input file:step2.root --l1-emulator FullMC > test_reHLT.py
I assume Run3 era in (2) is defined in
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/CustomConfigs.py#L123-L127
already. I also try to add --eras but it does not help.

[dildick]

It seems that hltGetConfiguration is loading the wrong geometry.

[srimanob]

Hi @dildick
If I add (*) to the hlt config, thing will run properly. It seems we have to find the place where this kind of geometry config is dumped by hltGetConfiguration. I am looking around in
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/Tools/confdb.py

process.GEMGeometryESModule = cms.ESProducer( "GEMGeometryESModule",
  fromDD4Hep = cms.bool( False ),
  appendToDataLabel = cms.string( "" ),
  fromDDD = cms.bool( False )
)

[perrotta]

Hi @dildick
If I add (*) to the hlt config, thing will run properly. It seems we have to find the place where this kind of geometry config is dumped by hltGetConfiguration. I am looking around in
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/Configuration/python/Tools/confdb.py

process.GEMGeometryESModule = cms.ESProducer( "GEMGeometryESModule",
  fromDD4Hep = cms.bool( False ),
  appendToDataLabel = cms.string( "" ),
  fromDDD = cms.bool( False )
)

I think @Martin-Grunewald can suggest how to best fix it

[fwyzard]

For consistency with the other muon ESProducer modules, a solution could be

• add GEMGeometryESModule to the HLT menu in ConfDB, based on the snippet provided by Phat
• update HLTrigger/Configuration/python/Tools/confdb.py to remove it from the fragment dumps, in order to reuse from the offline event setup
• regenerate the HLT dumps

[Martin-Grunewald]

Until then add a process.load of the GEMGeometryESModule cfi file in customizeHLTforCMSSW.... (process.load should not create a duplicate but overwrite if it is already there)

[Martin-Grunewald]

Please add the PR number to the name of the function.

[Martin-Grunewald]

You also need to call this function, at the bottom of the file!

      process = customiseForRun3GEMGeometry34785(process)

[srimanob]

Ah understand, Thanks.
Added.

I tested with --customise HLTrigger/Configuration/customizeHLTforCMSSW.customiseForRun3GEMGeometry before, so I did not add it.

[Martin-Grunewald]

There is now a merge conflict in HLTrigger/Configuration/python/customizeHLTforCMSSW.py as that file has changed recently where you call the function. Please rebase...

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24482

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Update DT DQM, calibration scripts, and local reco code to allow using "new" DB format #34612

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24482/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24482/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[srimanob]

I mess up with rebase, checking old 12_0. Trying to fix again, sorry for the noise.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24483

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24483/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34785/24483/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly