-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Phase2-TB63 Rearrange the header file and make first example for dd4hep #34752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34752/24418
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34752/24419
|
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-000977/17516/summary.html Comparison SummarySummary:
|
|
@bsunanda , git usually is right. Please, wait a bit and try to rebase. |
|
@bsunanda , check with the today IB SimG4CMS/HGCalTestBeam/plugins/HGCPassive.h |
|
Close this PR in favor of #34791 |
Phase2-TB63Z Rearrange the header file and make first example for dd4hep (replacing #34752)
PR description:
Rearrange the header file and make first example for dd4hep
PR validation:
Tested using examples in SimG4CMS/HGCalTestBeam/test
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special