Skip to content

Conversation

@bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 3, 2021

PR description:

Rearrange the header file and make first example for dd4hep

PR validation:

Tested using examples in SimG4CMS/HGCalTestBeam/test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34752/24418

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34752/24419

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • SimG4CMS/HGCalTestBeam (upgrade, simulation)

@civanch, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 4, 2021

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-000977/17516/summary.html
COMMIT: 3722b28
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34752/17516/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 4, 2021

@civanch @srimanob @perrotta @qliphy The conflict does not make sense. I tried to merge the PR with a new IB and it merges without any problem.

@civanch
Copy link
Contributor

civanch commented Aug 4, 2021

@bsunanda , git usually is right. Please, wait a bit and try to rebase.

@civanch
Copy link
Contributor

civanch commented Aug 5, 2021

@bsunanda , check with the today IB SimG4CMS/HGCalTestBeam/plugins/HGCPassive.h

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 5, 2021
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Aug 5, 2021
@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 5, 2021

Close this PR in favor of #34791

@bsunanda bsunanda closed this Aug 5, 2021
cmsbuild added a commit that referenced this pull request Aug 9, 2021
Phase2-TB63Z Rearrange the header file and make first example for dd4hep (replacing #34752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants