Skip to content

fix CAHitNtupletGeneratorOnGPU in case of no hits #34684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jul 29, 2021
Merged

fix CAHitNtupletGeneratorOnGPU in case of no hits #34684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ PixelTrackHeterogeneous CAHitNtupletGeneratorOnGPU::makeTuplesAsync(TrackingRecH
float bfield,
cudaStream_t stream) const {
PixelTrackHeterogeneous tracks(cms::cuda::make_device_unique<pixelTrack::TrackSoA>(stream));


if (0 == hits_d.nHits())
return tracks;

auto* soa = tracks.get();

CAHitNtupletGeneratorKernelsGPU kernels(m_params);
Expand All @@ -204,6 +207,9 @@ PixelTrackHeterogeneous CAHitNtupletGeneratorOnGPU::makeTuplesAsync(TrackingRecH
PixelTrackHeterogeneous CAHitNtupletGeneratorOnGPU::makeTuples(TrackingRecHit2DCPU const& hits_d, float bfield) const {
PixelTrackHeterogeneous tracks(std::make_unique<pixelTrack::TrackSoA>());

if (0 == hits_d.nHits())
return tracks;

auto* soa = tracks.get();
assert(soa);

Expand All @@ -215,9 +221,6 @@ PixelTrackHeterogeneous CAHitNtupletGeneratorOnGPU::makeTuples(TrackingRecHit2DC
kernels.launchKernels(hits_d, soa, nullptr);
kernels.fillHitDetIndices(hits_d.view(), soa, nullptr); // in principle needed only if Hits not "available"

if (0 == hits_d.nHits())
return tracks;

// now fit
HelixFitOnGPU fitter(bfield, m_params.fit5as4_);
fitter.allocateOnGPU(&(soa->hitIndices), kernels.tupleMultiplicity(), soa);
Expand Down