-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update GT string for 12_0_X #34613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update GT string for 12_0_X #34613
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong, by the way. It should be Commission2021,
/ExpressCosmics/Commissioning2021-Express-v1/FEVT
which can be found in
https://cmsweb.cern.ch/das/request?instance=prod/global&input=dataset+run%3D343498
Should we keep 2020 as is, and add 2021, or replace it with 2021. Either way is fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @boudoul @amassiro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK thanks @srimanob for checking. I only received a message from PPD ".. could you ask pdmv to update the run for runthematrix for run 3, using Run 343498, please?" so I only updated the Run number :( I can update PR with additional workflow for Commission2021 or replace 2020 one. Please let me know how would you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want this update GT string to be merged urgently so I will revert the run number and then we discuss with RC offline for the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chayanit : sorry for the delay I was away - Obviously updating a run number is implying to check the corresponding dataset otherwise it will just crash by definition . Could you please replace the 2020 WF by the 2021 one ? Thanks to @srimanob , you do not need to look for the dataset, he found it for you. Thanks .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @boudoul, I will open a separate PR to not mix them up.