Skip to content

Conversation

@sroychow
Copy link
Contributor

PR description:

Part of #31061. Following up from #34208 to migrate more DQM packages for esConsumes.

PR validation:

Code compiles and static analyzer checks do no show the Eventsetup get warnings.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34266/23553

  • This PR adds an extra 168KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

DQM/BeamMonitor
DQM/Physics
DQM/PhysicsObjectsMonitoring
DQM/PixelLumi
DQMOffline/JetMET

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@sroychow
Copy link
Contributor Author

sroychow commented Jun 27, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b9efa/16264/summary.html
COMMIT: f26fa40
CMSSW: CMSSW_12_0_X_2021-06-27-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34266/16264/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34266/23557

  • This PR adds an extra 168KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34266 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@sroychow
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b9efa/16265/summary.html
COMMIT: 178a413
CMSSW: CMSSW_12_0_X_2021-06-27-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34266/16265/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b9efa/16265/llvm-analysis/legacy-mod-sa.txt for details.

RelVals-INPUT

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785682
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@sroychow sroychow marked this pull request as ready for review June 27, 2021 18:08
@sroychow
Copy link
Contributor Author

Failed Tests: RelVals-INPUT
From the log, I can see this

21:08:13 603 603 600 561 118 41 3 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed

@smuzaffar can you suggest what is the issue? This is probably similar to this.

@smuzaffar
Copy link
Contributor

@sroychow , please ignore this error. This is due to dasgoclient message

2021/06/27 16:30:09 ERROR DAS QL ERROR, query=file block = /MinimumBias/Run2011A-ValSkim-08Nov2011-v1/RAW-RECO#239c497e-0fae-11e1-a8b1-00221959e72f run = 165121 site = T2_CH_CERN, idx=0, msg=unable to parse DAS query

I will fix the bot to ignore such errors.

@jfernan2
Copy link
Contributor

Thanks @sroychow for this PR. I understand you are not fixing more packages in this PR so I am signing it

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@sroychow
Copy link
Contributor Author

Thanks @sroychow for this PR. I understand you are not fixing more packages in this PR so I am signing it

Hi @jfernan2 Thanks. That's right. After this PR, only Ecal DQM packages remain to be migrated. Since last Friday they said that they are working on them, I am not touching them.

@qliphy
Copy link
Contributor

qliphy commented Jun 29, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Jun 29, 2021

merge

@cmsbuild cmsbuild merged commit bfa24b5 into cms-sw:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants