-
Notifications
You must be signed in to change notification settings - Fork 4.6k
DQM : migrate modules for esConumes part 2 #34266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34266/23553
|
|
A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master. It involves the following packages: DQM/BeamMonitor @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34266/23557
|
|
Pull request #34266 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
|
@cmsbuild please test |
|
-1 Failed Tests: RelVals-INPUT CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b9efa/16265/llvm-analysis/legacy-mod-sa.txt for details. RelVals-INPUTComparison SummarySummary:
|
@smuzaffar can you suggest what is the issue? This is probably similar to this. |
|
@sroychow , please ignore this error. This is due to dasgoclient message I will fix the bot to ignore such errors. |
|
Thanks @sroychow for this PR. I understand you are not fixing more packages in this PR so I am signing it |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
merge |
PR description:
Part of #31061. Following up from #34208 to migrate more DQM packages for esConsumes.
PR validation:
Code compiles and static analyzer checks do no show the Eventsetup get warnings.
if this PR is a backport please specify the original PR and why you need to backport that PR:
NA