Skip to content

Conversation

@guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Jun 20, 2021

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #33858).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added for 12_0_0_pre3

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34191/23408

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins
CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CondFormats/L1TObjects
CondFormats/SiPixelObjects
DQM/RPCMonitorClient
DQM/RPCMonitorDigi
DQMOffline/RecoB
OnlineDB/SiStripESSources
RecoLocalTracker/SiStripRecHitConverter
RecoTracker/MkFit
SimCalorimetry/HcalSimProducers
SimG4Core/GFlash
Validation/SiTrackerPhase2V

@perrotta, @malbouis, @civanch, @yuanchao, @jpata, @kmaeshima, @tlampen, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @ahmad3213, @slava77, @ggovi, @pohsun, @rvenditti, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@erikbutz, @emilbols, @echabert, @felicepantaleo, @yduhm, @robervalwalsh, @OzAmram, @threus, @mmusich, @seemasharmafnal, @acimmino, @makortel, @abdoulline, @JanFSchulte, @dgulhan, @slomeo, @sroychow, @ferencek, @mariadalfonso, @pieterdavid, @cvuosalo, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @alesaggio, @ebrondol, @mtosi, @fabiocos, @arossi83, @gbenelli, @JyothsnaKomaragiri, @dkotlins, @gpetruc, @andrzejnovak, @rociovilar, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jun 21, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65bbcf/16121/summary.html
COMMIT: 198a116
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34191/16121/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785631
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785596
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@jfernan2
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+reconstruction

  • Technical cleaning
  • Jenkins tests pass

@yuanchao
Copy link
Contributor

+1

  • buildfile cleaning (technical)
  • compiles and unit tests passed

@civanch
Copy link
Contributor

civanch commented Jun 21, 2021

+1

@guitargeek
Copy link
Contributor Author

@ggovi, is this okay for db?

@qliphy
Copy link
Contributor

qliphy commented Jun 23, 2021

merge
@cms-sw/db-l2 Let's know if you have any comment.

@cmsbuild cmsbuild merged commit 53a5edf into cms-sw:master Jun 23, 2021
@guitargeek guitargeek deleted the deps_1 branch June 23, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants