Skip to content

Specify separate directories to run external instances in ExternalGeneratorFilter #34173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Jun 21, 2021
Merged

Specify separate directories to run external instances in ExternalGeneratorFilter #34173

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
859da07
Specify separate directories to run external instances
colizz Jun 17, 2021
849fa60
Remove error_code to allow filesystem functions throwing expections
colizz Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions GeneratorInterface/Core/plugins/ExternalGeneratorFilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,22 @@ namespace externalgen {

channel_.setupWorker([&]() {
using namespace std::string_literals;
using namespace std::filesystem;
edm::LogSystem("ExternalProcess") << id_ << " starting external process \n";
std::string verboseCommand;
if (verbose) {
verboseCommand = "--verbose ";
}
std::error_code ec;
auto curDir = current_path();
auto newDir = path("thread"s + std::to_string(id_));
create_directory(newDir, ec);
current_path(newDir, ec);
Copy link
Contributor

@makortel makortel Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that any possible errors are silently ignored.

Copy link
Contributor Author

@colizz colizz Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, shall this work?

Suggested change
current_path(newDir, ec);
current_path(newDir, ec);
if (ec) {
throw cms::Exception("ExternalFailed")
<< "failed entering the working dir for process " << id_ << ": " << ec.message();
}

(Actually the previous code was following this example

cmssw/GeneratorInterface/LHEInterface/plugins/ExternalLHEProducer.cc

Lines 481 to 483 in c5d2673

auto newDir = path("thread"s + std::to_string(id));
create_directory(newDir, ec);
current_path(newDir, ec);
)

Copy link
Contributor

@makortel makortel Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about letting these functions to throw the exceptions? (i.e. remove the ec altogether, assuming the messages of those exceptions would be clear-enough)

pipe_ =
popen(("cmsExternalGenerator "s + verboseCommand + channel_.sharedMemoryName() + " " + channel_.uniqueID())
.c_str(),
"w");
current_path(curDir, ec);

if (nullptr == pipe_) {
abort();
Expand Down