Skip to content

Conversation

@francescobrivio
Copy link
Contributor

PR description:

Update online GTs with a new GEMRECO geometry tag used in MWGR#4 (June 2021), as detailed in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4408.html and https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4410.html. The new GEMRECO geometry tag (GEMRECO_Geometry_v2_hlt) contains a payload valid from 11_3_X which has been appended
with since 341787.

GT diffs:
Run 3 data HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v1/113X_dataRun3_HLT_v2

Run 2 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HLT_relval_v1/113X_dataRun2_HLT_relval_v2

Run 3 data (express)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v1/113X_dataRun3_Express_v3

Run 3 data (prompt)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Prompt_v1/113X_dataRun3_Prompt_v3

PR validation:

Tested with:

runTheMatrix.py -l 138.1,138.2 --ibeos -j4
addOnTests.py -j8

Backport:

A backport for 11_3_X will be provided

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 138.1,138.2

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34165/23373

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-727356/16072/summary.html
COMMIT: da41ea7
CMSSW: CMSSW_12_0_X_2021-06-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34165/16072/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-dt4ml_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-dt_dqm_sourceclient had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-727356/138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-727356/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862491
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

@silviodonato @qliphy I see the two failing unitTests are also failing in the IB:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_0_X_2021-06-16-2300/unitTestLogs/DQM/Integration#/ (while they are not failing in the backport #34166)
Should I wait for the new IB results to before re-triggering the tests?

@qliphy
Copy link
Contributor

qliphy commented Jun 17, 2021

@francescobrivio The unit failures should be fixed by #34164
which is now merged and should be included in next IB tomorrow.

@francescobrivio
Copy link
Contributor Author

@francescobrivio The unit failures should be fixed by #34164
which is now merged and should be included in next IB tomorrow.

Thank you! I'll re-start the tests tomorrow then!

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 138.1,138.2

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-727356/16095/summary.html
COMMIT: da41ea7
CMSSW: CMSSW_12_0_X_2021-06-17-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34165/16095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-727356/138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-727356/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2871916
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2871887
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

+alca

  • Update of the autoCond for the GTs used in MWGR4
  • The tag differences are as described and the updated tag includes the geometry payload for runs taken with 11_3_X.
  • The few failures that appear are related to the MessageLogger and are not related to the GTs introduced in this PR.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 18, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants