Skip to content

DTDQM Fix to testUnit #34164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jun 17, 2021
Merged

DTDQM Fix to testUnit #34164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtBlockedROChannelsTest_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import FWCore.ParameterSet.Config as cms
from DQMServices.Core.DQMEDHarvester import DQMEDHarvester

blockedROChannelTest = DQMEDHarvester("DTBlockedROChannelsTest",
blockedROChannelTest = DQMEDHarvester('DTBlockedROChannelsTest',
offlineMode = cms.untracked.bool(False),
diagnosticPrescale = cms.untracked.int32(1),
checkUros = cms.untracked.bool(False)
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtCertificationSummary_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import FWCore.ParameterSet.Config as cms
from DQMServices.Core.DQMEDHarvester import DQMEDHarvester

dtCertificationSummary = DQMEDHarvester("DTCertificationSummary")
dtCertificationSummary = DQMEDHarvester('DTCertificationSummary')


8 changes: 4 additions & 4 deletions DQM/DTMonitorClient/python/dtFineDelayCorr_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
# Read old delays from file or from Db
readOldFromDb = cms.bool(False),
# Input file name for old delays
oldDelaysInputFile = cms.string("dtOldFineDelays.txt"),
oldDelaysInputFile = cms.string('dtOldFineDelays.txt'),
# Write new delays to file or to Db
writeDB = cms.bool(False),
# output file name
outputFile = cms.string("dtFineDelaysNew.txt"),
outputFile = cms.string('dtFineDelaysNew.txt'),
# Tag for the t0Mean Histograms
t0MeanHistoTag = cms.string("TrackCrossingTimeAll"),
t0MeanHistoTag = cms.string('TrackCrossingTimeAll'),
# Hardware Source (TM)
hwSource = cms.string("TM"),
hwSource = cms.string('TM'),
# Choose to use Hist Mean or Gaussian Fit Mean
gaussMean = cms.bool(False),
# Require Minimum Number Of Entries in the t0Mean Histogram
Expand Down
6 changes: 3 additions & 3 deletions DQM/DTMonitorClient/python/dtLocalTriggerSynchTest_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
dbFromTM = cms.bool(False),
fineParamDiff = cms.bool(False),
coarseParamDiff = cms.bool(False),
numHistoTag = cms.string("TrackCrossingTimeAllInBX"),
denHistoTag = cms.string("TrackCrossingTimeHHInBX"),
ratioHistoTag = cms.string("TrackCrossingTimeAllOverHHInBX")
numHistoTag = cms.string('TrackCrossingTimeAllInBX'),
denHistoTag = cms.string('TrackCrossingTimeHHInBX'),
ratioHistoTag = cms.string('TrackCrossingTimeAllOverHHInBX')
)


2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtResolutionAnalysisTest_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
maxGoodSigmaValue = cms.untracked.double(0.05),
minBadSigmaValue = cms.untracked.double(0.08),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("DT/02-Segments")
topHistoFolder = cms.untracked.string('DT/02-Segments')
)


2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtResolutionAnalysisTest_hlt_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
permittedMeanRange = cms.untracked.double(0.01),
permittedSigmaRange = cms.untracked.double(0.08),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("HLT/HLTMonMuon/DT-Segments")
topHistoFolder = cms.untracked.string('HLT/HLTMonMuon/DT-Segments')
)


2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtResolutionTestFinalCalib_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
permittedMeanRange = cms.untracked.double(0.02),
permittedSigmaRange = cms.untracked.double(0.12),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("DT/CalibrationSummary"),
topHistoFolder = cms.untracked.string('DT/CalibrationSummary'),
doCalibAnalysis = cms.untracked.bool(True)
)
2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtSegmentAnalysisTest_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
chi2Threshold = cms.untracked.double(5.0),
normalizeHistoPlots = cms.untracked.bool(False),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("DT/02-Segments"),
topHistoFolder = cms.untracked.string('DT/02-Segments'),
# hlt DQM mode
hltDQMMode = cms.untracked.bool(False),
nEventsCert = cms.untracked.int32(1000),
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorClient/python/dtSegmentAnalysisTest_hlt_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
chi2Threshold = cms.untracked.double(5.0),
normalizeHistoPlots = cms.untracked.bool(False),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("HLT/HLTMonMuon/DT-Segments"),
topHistoFolder = cms.untracked.string('HLT/HLTMonMuon/DT-Segments'),
# hlt DQM mode
hltDQMMode = cms.untracked.bool(True),
nEventsCert = cms.untracked.int32(1000)
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/ALCARECODTCalibSynchCosmicsDQM_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
)

dtAlcaResolutionMonitorCosmics = dtResolutionAnalysisMonitor.clone(
topHistoFolder = "AlCaReco/DtCalibSynchCosmics/01-Calibration"
topHistoFolder = 'AlCaReco/DtCalibSynchCosmics/01-Calibration'
)

#dtTriggerSynchMonitorCosmics = dtTriggerSynchMonitor.clone(
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/ALCARECODTCalibSynchDQM_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
)

dtAlcaResolutionMonitor = dtResolutionAnalysisMonitor.clone(
topHistoFolder = "AlCaReco/DtCalibSynch/01-Calibration"
topHistoFolder = 'AlCaReco/DtCalibSynch/01-Calibration'
)

dtTriggerSynchMonitor.baseDir = 'AlCaReco/DtCalibSynch/02-Synchronization'
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/ALCARECODTCalibSynchHIDQM_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
)

dtAlcaResolutionMonitorHI = dtResolutionAnalysisMonitor.clone(
topHistoFolder = "AlCaReco/DtCalibSynchHI/01-Calibration"
topHistoFolder = 'AlCaReco/DtCalibSynchHI/01-Calibration'
)

dtTriggerSynchMonitorHI = dtTriggerSynchMonitor.clone(
Expand Down
12 changes: 6 additions & 6 deletions DQM/DTMonitorModule/python/dtChamberEfficiencyHI_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
dtEfficiencyMonitor = DQMEDAnalyzer('DTChamberEfficiency',
MuonServiceProxy,
debug = cms.untracked.bool(True),
TrackCollection = cms.InputTag("standAloneMuons"),
TrackCollection = cms.InputTag('standAloneMuons'),
theMaxChi2 = cms.double(1000.),
theNSigma = cms.double(3.),
theMinNrec = cms.double(5.),
dt4DSegments = cms.InputTag("dt4DSegments"),
theRPCRecHits = cms.InputTag("dummy"),
thegemRecHits = cms.InputTag("dummy"),
cscSegments = cms.InputTag("dummy"),
dt4DSegments = cms.InputTag('dt4DSegments'),
theRPCRecHits = cms.InputTag('dummy'),
thegemRecHits = cms.InputTag('dummy'),
cscSegments = cms.InputTag('dummy'),
RPCLayers = cms.bool(False),
NavigationType = cms.string("Standard")
NavigationType = cms.string('Standard')
)

10 changes: 5 additions & 5 deletions DQM/DTMonitorModule/python/dtChamberEfficiency_Cosmics_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
dtEfficiencyMonitor = DQMEDAnalyzer('DTChamberEfficiency',
MuonServiceProxy,
debug = cms.untracked.bool(True),
TrackCollection = cms.InputTag("cosmicMuons"),
TrackCollection = cms.InputTag('cosmicMuons'),
theMaxChi2 = cms.double(100.),
theNSigma = cms.double(3.),
theMinNrec = cms.double(20.),
dt4DSegments = cms.InputTag("dt4DSegments"),
theRPCRecHits = cms.InputTag("dummy"),
cscSegments = cms.InputTag("dummy"),
dt4DSegments = cms.InputTag('dt4DSegments'),
theRPCRecHits = cms.InputTag('dummy'),
cscSegments = cms.InputTag('dummy'),
RPCLayers = cms.bool(False),
NavigationType = cms.string("Direct")
NavigationType = cms.string('Direct')
)

8 changes: 4 additions & 4 deletions DQM/DTMonitorModule/python/dtChamberEfficiency_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
theMaxChi2 = cms.double(1000.),
theNSigma = cms.double(3.),
theMinNrec = cms.double(3.),
dt4DSegments = cms.InputTag("dt4DSegments"),
theRPCRecHits = cms.InputTag("dummy"),
cscSegments = cms.InputTag("dummy"),
dt4DSegments = cms.InputTag('dt4DSegments'),
theRPCRecHits = cms.InputTag('dummy'),
cscSegments = cms.InputTag('dummy'),
RPCLayers = cms.bool(False),
NavigationType = cms.string("Standard")
NavigationType = cms.string('Standard')
)

4 changes: 2 additions & 2 deletions DQM/DTMonitorModule/python/dtDataIntegrityTask_EvF_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import FWCore.ParameterSet.Config as cms

from DQM.DTMonitorModule.dtDataIntegrityTask_cfi import *
dtDataIntegrityTask.processingMode = "HLT"
dtDataIntegrityTask.fedIntegrityFolder = "DT/FEDIntegrity_EvF"
dtDataIntegrityTask.processingMode = 'HLT'
dtDataIntegrityTask.fedIntegrityFolder = 'DT/FEDIntegrity_EvF'

16 changes: 8 additions & 8 deletions DQM/DTMonitorModule/python/dtDataIntegrityTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@

from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer
dtDataIntegrityTask = DQMEDAnalyzer('DTDataIntegrityTask',
fedIntegrityFolder = cms.untracked.string("DT/FEDIntegrity"),
processingMode = cms.untracked.string("Online"),
dtFEDlabel = cms.InputTag("dtDataIntegrityUnpacker")
fedIntegrityFolder = cms.untracked.string('DT/FEDIntegrity'),
processingMode = cms.untracked.string('Online'),
dtFEDlabel = cms.InputTag('dtDataIntegrityUnpacker')
)

dtDataIntegrityTaskOffline = DQMEDAnalyzer('DTDataIntegrityROSOffline',
getSCInfo = cms.untracked.bool(True),
fedIntegrityFolder = cms.untracked.string("DT/FEDIntegrity"),
dtDDULabel = cms.InputTag("dtDataIntegrityUnpacker"),
dtROS25Label = cms.InputTag("dtDataIntegrityUnpacker"),
fedIntegrityFolder = cms.untracked.string('DT/FEDIntegrity'),
dtDDULabel = cms.InputTag('dtDataIntegrityUnpacker'),
dtROS25Label = cms.InputTag('dtDataIntegrityUnpacker'),
)

dtDataIntegrityUrosOffline = DQMEDAnalyzer('DTDataIntegrityUrosOffline',
fedIntegrityFolder = cms.untracked.string("DT/FEDIntegrity"),
dtFEDlabel = cms.InputTag("dtDataIntegrityUnpacker")
fedIntegrityFolder = cms.untracked.string('DT/FEDIntegrity'),
dtFEDlabel = cms.InputTag('dtDataIntegrityUnpacker')
)

from Configuration.Eras.Modifier_run2_DT_2018_cff import run2_DT_2018
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtDigiTask_TP_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# Value of the ttrig pedestal used when not reading from DB
defaultTtrig = cms.int32(3450),
# the label to retrieve the DT digis
dtDigiLabel = cms.InputTag("dtunpacker"),
dtDigiLabel = cms.InputTag('dtunpacker'),
# check the noisy flag in the DB and use it
checkNoisyChannels = cms.untracked.bool(True),
# set static booking (all the detector)
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtDigiTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# Value of the ttrig pedestal used when not reading from DB
defaultTtrig = cms.int32(2700),
# the label to retrieve the DT digis
dtDigiLabel = cms.InputTag("dtunpacker"),
dtDigiLabel = cms.InputTag('dtunpacker'),
# check the noisy flag in the DB and use it
checkNoisyChannels = cms.untracked.bool(True),
# set static booking (all the detector)
Expand Down
4 changes: 2 additions & 2 deletions DQM/DTMonitorModule/python/dtNoiseTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer
dtNoiseMonitor = DQMEDAnalyzer('DTNoiseTask',
# the label to retrieve the DT digis
dtDigiLabel = cms.InputTag("dtunpacker"),
dtDigiLabel = cms.InputTag('dtunpacker'),
# switch for time box booking
doTbHistos = cms.untracked.bool(False),
# the name of the 4D rec hits collection
recHits4DLabel = cms.string("dt4DSegments"),
recHits4DLabel = cms.string('dt4DSegments'),
# switch for segment veto
doSegmentVeto = cms.untracked.bool(False),
# safe margin (ns) between ttrig and beginning of counting area
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtResolutionTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
phiHitsCut = cms.untracked.uint32(6),
zHitsCut = cms.untracked.uint32(3),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("DT/02-Segments")
topHistoFolder = cms.untracked.string('DT/02-Segments')
)


2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtResolutionTask_hlt_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# interval of lumi block after which we reset the histos
ResetCycle = cms.untracked.int32(10000),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("HLT/HLTMonMuon/DT-Segments")
topHistoFolder = cms.untracked.string('HLT/HLTMonMuon/DT-Segments')
)


2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtRunConditionVar_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
debug = cms.untracked.bool(False),
nMinHitsPhi = cms.untracked.int32(5),
maxAnglePhiSegm = cms.untracked.double(30.),
recoSegments = cms.InputTag("dt4DSegments"),
recoSegments = cms.InputTag('dt4DSegments'),
)

2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtSegmentTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# switch off uneeded histograms
detailedAnalysis = cms.untracked.bool(False),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("DT/02-Segments"),
topHistoFolder = cms.untracked.string('DT/02-Segments'),
# hlt DQM mode
hltDQMMode = cms.untracked.bool(False),
# max phi angle of reconstructed segments
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtSegmentTask_hlt_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# switch on/off sliding bins in time histos
slideTimeBins = cms.untracked.bool(True),
# top folder for the histograms in DQMStore
topHistoFolder = cms.untracked.string("HLT/HLTMonMuon/DT-Segments"),
topHistoFolder = cms.untracked.string('HLT/HLTMonMuon/DT-Segments'),
# hlt DQM mode
hltDQMMode = cms.untracked.bool(True)
)
Expand Down
8 changes: 4 additions & 4 deletions DQM/DTMonitorModule/python/dtTriggerLutTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer
dtTriggerLutMonitor = DQMEDAnalyzer('DTLocalTriggerLutTask',
# labels of TM data and 4D segments
inputTagTMin = cms.untracked.InputTag("twinMuxStage2Digis:PhIn"),
inputTagTMout = cms.untracked.InputTag("twinMuxStage2Digis:PhOut"),
inputTagSEG = cms.untracked.InputTag("dt4DSegments"),
inputTagTMin = cms.untracked.InputTag('twinMuxStage2Digis:PhIn'),
inputTagTMout = cms.untracked.InputTag('twinMuxStage2Digis:PhOut'),
inputTagSEG = cms.untracked.InputTag('dt4DSegments'),
# set static booking (all the detector)
staticBooking = cms.untracked.bool(True),
# set outflows to boudaries
rebinOutFlowsInGraph = cms.untracked.bool(True),
# enable more detailed studies
detailedAnalysis = cms.untracked.bool(False),
# label of the geometry used to feed DTTrigGeomUtils
geomLabel = cms.untracked.string("idealForDigi"),
geomLabel = cms.untracked.string('idealForDigi'),
# number of luminosity blocks to reset the histos
ResetCycle = cms.untracked.int32(9999)
)
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtTriggerSynchTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
nBXLow = cms.int32(1),
angleRange = cms.double(30.),
minHitsPhi = cms.int32(7),
baseDir = cms.string("DT/90-LocalTriggerSynch/"),
baseDir = cms.string('DT/90-LocalTriggerSynch/'),
tTrigModeConfig = cms.PSet(
vPropWire = cms.double(24.4),
doTOFCorrection = cms.bool(False),
Expand Down
2 changes: 1 addition & 1 deletion DQM/DTMonitorModule/python/dtTriggerTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
staticBooking = cms.untracked.bool(True),
# labels of TM data and 4D segments
tm_label = cms.untracked.InputTag('twinMuxStage2Digis:PhIn'),
tmTh_label = cms.untracked.InputTag("twinMuxStage2Digis","ThIn"),
tmTh_label = cms.untracked.InputTag('twinMuxStage2Digis','ThIn'),
ros_label = cms.untracked.InputTag('dtunpacker'),
seg_label = cms.untracked.InputTag('dt4DSegments'),
maxBXTM = cms.untracked.int32(2), # max BX for TM plots
Expand Down
4 changes: 2 additions & 2 deletions DQM/DTMonitorModule/python/dt_dqm_sourceclient_common_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
from DQM.DTMonitorModule.dtTriggerLutTask_cfi import *
from DQM.DTMonitorClient.dtLocalTriggerTest_cfi import *
from DQM.DTMonitorClient.dtTriggerLutTest_cfi import *
triggerTest.hwSources = 'TM'
triggerTest.hwSources = ['TM']
# scaler task
from DQM.DTMonitorModule.dtScalerInfoTask_cfi import *

Expand Down Expand Up @@ -104,7 +104,7 @@
# Local Trigger task for test pulses
from DQM.DTMonitorModule.dtTriggerTask_TP_cfi import *
from DQM.DTMonitorClient.dtLocalTriggerTest_TP_cfi import *
dtTPTriggerTest.hwSources = 'TM'
dtTPTriggerTest.hwSources = ['TM']
Copy link
Contributor

@Dr15Jones Dr15Jones Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes in this file are all that is needed to fix the unit tests.


unpackers = cms.Sequence(dtunpacker + twinMuxStage2Digis + scalersRawToDigi)

Expand Down