Fix use of EDAlias on 'source'

[Dr15Jones]

PR description:

Sources which assign the label 'source' to their data products can now properly be handled by EDAlias.

PR validation:

Code compiles and newly added test passes.

solves #34157
solves cms-sw/framework-team#171

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34161/23366

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/EDConsumerBase.cc modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21b8a/16036/summary.html
COMMIT: f5fcc7f
CMSSW: CMSSW_12_0_X_2021-06-16-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34161/16036/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• L1T: fix duplicate dictionary problems in #33978 #34094 @cecilecaillol: L1T: fix duplicate dictionary problems in L1T phase-2: Update VertexFinder and remove the old L1TkPrimaryVertexProducer #33978
• [CORE] Apply code-checks/format #34130 @smuzaffar: [CORE] Apply code-checks/format
• [DQM] Apply code-checks/format #34131 @smuzaffar: [DQM] Apply code-checks/format
• [L1] Apply code-checks/format #34138 @smuzaffar: [L1] Apply code-checks/format
• move InefficientDoubleROC.py script to python3 #34150 @davidlange6: move InefficientDoubleROC.py script to python3
• Drop Type in toModify for DTDQM #34153 @jfernan2: Drop Type in toModify for DTDQM
• Drop type specs for DT DQM #34144 @jfernan2: Drop type specs for DT DQM
• [SIMULATION] Apply code-checks/format #34141 @smuzaffar: [SIMULATION] Apply code-checks/format
• Fix minor mistake in CSC Run-3 slope to Run-2 pattern translation (CCLUT-15) #34119 @dildick: Fix minor mistake in CSC Run-3 slope to Run-2 pattern translation (CCLUT-15)

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21b8a/16036/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a21b8a/16036/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862491
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1