[SiPixel Payload Inspector] Quality Maps Improved

[mmusich]

PR description:

The main goal of this PR is to improve the graphical appearance of plots produced with the pixel payload inspector, specifically for the SiPixelQuality flavour.
In doing so the class Phase1PixelROCMaps had to be changed in order to:

• print the name of the tag and IOVs in the plot header (commit 69821a2);
• support the case of diffing two payloads (commits 56dba64 and 85c9df3);

All classes depending on that had to be modified accordingly (done in commits 2bb3909, ef689cd, 6e9c712)
I profit of this PR to do some additional clean-up:

• update the scram architecture in all the test scripts (commit ea3a58c )
• mark all the methods implemented in the Phase1PixelROCMaps header as inlined (see PR [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366) (commit f52b394)
• fix a mistake in one of the comments (commit b5ddb04 )

PR validation:

Unit tests of the package run successfully.
In addition run the following script:

#!/bin/sh

W_DIR=$(pwd)
mkdir -p $W_DIR/myplots

getPayloadData.py --plugin pluginSiPixelQuality_PayloadInspector --plot plot_SiPixelFullQualityMap --tag SiPixelQuality_phase1_2018_permanentlyBad --time_type Lumi --iovs '{"start_iov": "1", "end_iov": "1
"}' --db Prod --test ;
mv *.png $W_DIR/myplots/SiPixelQuality_phase1_2018_permanentlyBad.png

getPayloadData.py --plugin pluginSiPixelQuality_PayloadInspector --plot plot_SiPixelFullQualityMap --tag SiPixelQuality_phase1_2021_v2 --time_type Lumi --iovs '{"start_iov": "1", "end_iov": "1"}' --db Pro
d --test ;
mv *.png $W_DIR/myplots/SiPixelQuality_phase1_2021_v2.png

getPayloadData.py --plugin pluginSiPixelQuality_PayloadInspector --plot plot_SiPixelFullQualityMapCompareTwoTags --tag SiPixelQuality_phase1_2021_v2 --tagtwo SiPixelQuality_phase1_2018_permanentlyBad --ti
me_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --iovstwo '{"start_iov": "1", "end_iov": "1"}' --db Prod --test ;
mv *.png $W_DIR/myplots/SiPixelQuality_diff.png

getPayloadData.py --plugin pluginSiPixelQuality_PayloadInspector --plot plot_SiPixelBPixQualityMapCompareTwoTags --tag SiPixelQuality_phase1_2021_v2 --tagtwo SiPixelQuality_phase1_2018_permanentlyBad --ti
me_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --iovstwo '{"start_iov": "1", "end_iov": "1"}' --db Prod --test ;
mv *.png $W_DIR/myplots/SiPixelQuality_BPIX_diff.png

getPayloadData.py --plugin pluginSiPixelQuality_PayloadInspector --plot plot_SiPixelFPixQualityMapCompareTwoTags --tag SiPixelQuality_phase1_2021_v2 --tagtwo SiPixelQuality_phase1_2018_permanentlyBad --ti
me_type Run --iovs '{"start_iov": "1", "end_iov": "1"}' --iovstwo '{"start_iov": "1", "end_iov": "1"}' --db Prod --test ;
mv *.png $W_DIR/myplots/SiPixelQuality_FPIX_diff.png

and obtained the following plots.

I post one specific example here:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

CC: @tvami @tsusa

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34071/23224

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiPixelPlugins
DQM/TrackerRemapper

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @VinInn, @OzAmram, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52aa5c/15836/summary.html
COMMIT: 27cec51
CMSSW: CMSSW_12_0_X_2021-06-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34071/15836/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34071/23233

• This PR adds an extra 64KB to repository

[cmsbuild]

Pull request #34071 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @ggovi, @rvenditti can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52aa5c/15851/summary.html
COMMIT: 85c9df3
CMSSW: CMSSW_12_0_X_2021-06-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34071/15851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2862491
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

@mmusich might this PR affect Online DQM plots somehow or it just modifies those generated by the getPayloadData.py script?
Thanks

[mmusich]

@jfernan2 it does not affect Online DQM, only plots generated with the getPayloadData.py script (either privately or in the CondDB browser).

[jfernan2]

+1

[qliphy]

kindly ping @cms-sw/db-l2

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1