[DQM] Apply code-checks/format with misc-definitions-in-headers

[smuzaffar]

code-checks/format applied on full cmssw

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34039/23173

ERROR: Build errors found during clang-tidy run.

HLTriggerOffline/Exotica/src/HLTExoticaPlotter.cc:218:1: error: version control conflict marker in file [clang-diagnostic-error]
<<<<<<< HEAD
^
Suppressed 1988 warnings (1983 in non-user code, 4 NOLINT, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34039/23191

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DQM/CSCMonitorModule
DQM/SiPixelPhase1Common
DQM/SiStripMonitorClient
DQMOffline/RecoB
DQMOffline/Trigger
DQMServices/Components
Validation/HcalHits
Validation/RecoTau

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@emilbols, @jandrea, @fioriNTU, @threus, @cericeci, @venturia, @hdelanno, @JyothsnaKomaragiri, @abdoulline, @jhgoh, @missirol, @HuguesBrun, @ferencek, @trocino, @rociovilar, @sscruz, @barvic, @sroychow, @ptcox, @hatakeyamak, @idebruyn, @mtosi, @arossi83, @Fedespring, @calderona, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0e4f/15784/summary.html
COMMIT: 091d37d
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34039/15784/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• implement Concurrent GeneratorFilter technique #33883 @PhyM73: implement Concurrent GeneratorFilter technique
• Issue fix in Exotica HLT validation code #34006 @borzari: Issue fix in Exotica HLT validation code
• Migrate module config in RecoTracker{IterativeTracking} to use default cfipython v2 #34007 @jeongeun: Migrate module config in RecoTracker{IterativeTracking} to use default cfipython v2
• LowPtElectrons: NanoAOD integration (forward port) #34005 @bainbrid: LowPtElectrons: NanoAOD integration (forward port)
• Modification to PythiaFilterMotherSister #33806 @BParkHNLs: Modification to PythiaFilterMotherSister
• Fix for IOV Array Iterator #33941 @ggovi: Fix for IOV Array Iterator
• L1T phase-2: Update VertexFinder and remove the old L1TkPrimaryVertexProducer #33978 @cecilecaillol: L1T phase-2: Update VertexFinder and remove the old L1TkPrimaryVertexProducer

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0e4f/15784/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef0e4f/15784/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.259 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1325.81 ): -0.759 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 136.8523 ): -0.500 KiB Physics/NanoAODDQM
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: found differences in 7 / 37 workflows

[jfernan2]

+1
Changes due to #34005

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1