Moved FileInPath to FWCore/Utilities

[Dr15Jones]

PR description:

Moved the class edm::FileInPath from FWCore/ParameterSet to FWCore/Utilities. The class only depends on code from FWCore/Utilities.

The move was also meant to reduce *Formats packages dependencies on FWCore/ParameterSet which will make transitioning to ROOT's module system easier.

PR validation:

Code compiles.

fixes cms-sw/framework-team#157

[Dr15Jones]

NOTE: transitioning away from old includes used in the rest of CMSSW will happen in future pull requests.

[Dr15Jones]

@davidlange6 FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33886/22927

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Integration
FWCore/ParameterSet
FWCore/PyDevParameterSet
FWCore/PythonParameterSet
FWCore/Utilities

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da8226/15394/summary.html
COMMIT: df4cfd5
CMSSW: CMSSW_12_0_X_2021-05-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33886/15394/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• More BuildFiles cleaning #33858 @guitargeek: More BuildFiles cleaning
• Run4-hgx286 Start with the cell definitions of V16 #33836 @bsunanda: Run4-hgx286 Start with the cell definitions of V16
• Including jetId criteria for UL16  #33826 @alefisico: Including jetId criteria for UL16
• Phase2-hgx286 Define the big partitions for next version of HGCal #33833 @bsunanda: Phase2-hgx286 Define the big partitions for next version of HGCal
• Clean up Utilities/StaticAnalyers scripts to avoid errors because of formatting. #33870 @gartung: Clean up Utilities/StaticAnalyers scripts to avoid errors because of formatting.
• Fix CaloTopologyRecord.h location #33875 @mrodozov: Fix CaloTopologyRecord.h location

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da8226/15394/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da8226/15394/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test EcalADCToGeV_update_test had ERRORS
---> test EcalDCS_O2O_test had ERRORS
---> test EcalDAQ_O2O_test had ERRORS
---> test EcalTPGBadStripStatus_O2O_test had ERRORS
and more ...

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2650457
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[makortel]

+1

Failing tests are in CondTools and are failing in IBs as well.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

merge