Remove ParameterSet usage from CondFormats/L1Trigger #33873

Dr15Jones · 2021-05-27T21:08:28Z

PR description:

The dependency on edm::ParameterSet by L1MuCSCTFConfiguration was not needed. The only piece of code that wants an edm::ParameterSet based on the info stored in that class is CSCTFSectorProcessor.

Removing the dependency fixes problems see in the ROOT module's build plus it is in general a good idea to keep dependencies for CondFormats to a bare minimum.

In addition, *Rcd.h files were found in the /src directory which are duplicates of what is already in CondFormats/Records.

PR validation:

The code compiles fine in the regular build and now in the CXXMODULE build.

solves cms-sw/framework-team#155

The L1MuCSCTFConfiguration does not need to depend upon ParameterSet to do its job. The functionality was moved to a standalone function. Only CSCTFSectorProcessor was dependent upon that member function.

This is the only package that uses the function. This is needed from the ROOT modules build.

The classes are already declared in CondFormats/Records so these were a 'one definition rule' violation.

Dr15Jones · 2021-05-27T21:08:47Z

@davidlange6 FYI

cmsbuild · 2021-05-27T21:14:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33873/22907

This PR adds an extra 36KB to repository
Found files with invalid states:
- CondFormats/L1TObjects/src/parameters.cc:
  - Added: 02a0752
  - Deleted: c247c07
- CondFormats/L1TObjects/interface/parameters.h:
  - Added: 02a0752
  - Deleted: c247c07

cmsbuild · 2021-05-27T21:14:47Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/L1TObjects
L1Trigger/CSCTrackFinder

@malbouis, @yuanchao, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2021-05-27T23:13:21Z

please test

cmsbuild · 2021-05-28T01:08:34Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-204cee/15374/summary.html
COMMIT: 6b6213d
CMSSW: CMSSW_12_0_X_2021-05-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33873/15374/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalConstantsASCIIWriter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalCorrPFCalculation.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalIsoTrackAnalysis.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalIsoTrackStudy.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc:33:10: fatal error: Geometry/CaloEventSetup/interface/CaloTopologyRecord.h: No such file or directory
   33 | #include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/HcalLaserTest.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-2300/src/Calibration/HcalCalibAlgos/test/ValidationHcalIsoTrackAlCaReco.cc

Dr15Jones · 2021-05-28T13:00:12Z

please test with #33870

makortel · 2021-05-28T13:06:09Z

please test with #33870

@Dr15Jones Did you mean #33875?

Dr15Jones · 2021-05-28T13:07:44Z

Did you mean #33875?

Ops, yes.

Dr15Jones · 2021-05-28T13:08:06Z

please test with #33875

cmsbuild · 2021-05-28T16:40:05Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-204cee/15385/summary.html
COMMIT: 6b6213d
CMSSW: CMSSW_12_0_X_2021-05-28-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33873/15385/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11.0DAS Error
13.0DAS Error
14.0DAS Error

Expand to see more relval errors ...

15.0

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

Dr15Jones · 2021-05-28T16:41:21Z

DAS failures are not from this pull request.

Dr15Jones · 2021-05-30T18:22:12Z

please test

cmsbuild · 2021-05-30T21:46:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-204cee/15432/summary.html
COMMIT: 6b6213d
CMSSW: CMSSW_12_0_X_2021-05-30-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33873/15432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cecilecaillol · 2021-05-31T10:34:49Z

+l1

ggovi · 2021-05-31T21:19:41Z

+1

Dr15Jones · 2021-06-01T13:18:12Z

@cms-sw/alca-l2 ping

yuanchao · 2021-06-02T11:50:34Z

+1

remove edm::ParameterSet dependency.
matrix tests and unite tests passed
build warnings not from the modification of the PR

cmsbuild · 2021-06-02T11:50:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-03T00:24:52Z

+1

Dr15Jones added 3 commits May 27, 2021 15:30

Removed ParameterSet from L1MuCSCTFConfiguration

02a0752

The L1MuCSCTFConfiguration does not need to depend upon ParameterSet to do its job. The functionality was moved to a standalone function. Only CSCTFSectorProcessor was dependent upon that member function.

Moved parameters function to L1Trigger/CSCTrackFinder

c247c07

This is the only package that uses the function. This is needed from the ROOT modules build.

Removed *Rcd.h headers from CondFormats/L1TObjects

6b6213d

The classes are already declared in CondFormats/Records so these were a 'one definition rule' violation.

cmsbuild added this to the CMSSW_12_0_X milestone May 27, 2021

cmsbuild added alca-pending code-checks-pending db-pending l1-pending orp-pending pending-signatures tests-pending labels May 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2021

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels May 27, 2021

cmsbuild added requires-external tests-started and removed tests-rejected labels May 28, 2021

cmsbuild added tests-rejected and removed tests-started labels May 28, 2021

cmsbuild added tests-started and removed requires-external tests-rejected labels May 30, 2021

cmsbuild added tests-approved and removed tests-started labels May 30, 2021

cmsbuild added l1-approved and removed l1-pending labels May 31, 2021

cmsbuild added db-approved and removed db-pending labels May 31, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 2, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 3, 2021

cmsbuild merged commit 903a837 into cms-sw:master Jun 3, 2021

Dr15Jones deleted the rmParameterSetFromL1MuCSCTFConfiguration branch June 3, 2021 19:07

Remove ParameterSet usage from CondFormats/L1Trigger #33873

Remove ParameterSet usage from CondFormats/L1Trigger #33873

Uh oh!

Conversation

Dr15Jones commented May 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

Dr15Jones commented May 27, 2021

Uh oh!

cmsbuild commented May 27, 2021

Uh oh!

cmsbuild commented May 27, 2021

Uh oh!

Dr15Jones commented May 27, 2021

Uh oh!

cmsbuild commented May 28, 2021

Build

Uh oh!

Dr15Jones commented May 28, 2021

Uh oh!

makortel commented May 28, 2021

Uh oh!

Dr15Jones commented May 28, 2021

Uh oh!

Dr15Jones commented May 28, 2021

Uh oh!

cmsbuild commented May 28, 2021

RelVals-INPUT

Comparison Summary

Uh oh!

Dr15Jones commented May 28, 2021

Uh oh!

Dr15Jones commented May 30, 2021

Uh oh!

cmsbuild commented May 30, 2021

Comparison Summary

Uh oh!

cecilecaillol commented May 31, 2021

Uh oh!

ggovi commented May 31, 2021

Uh oh!

Dr15Jones commented Jun 1, 2021

Uh oh!

yuanchao commented Jun 2, 2021

Uh oh!

cmsbuild commented Jun 2, 2021

Uh oh!

qliphy commented Jun 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Dr15Jones commented May 27, 2021 •

edited

Loading