Skip to content

Conversation

@silviodonato
Copy link
Contributor

Reverts #33779

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_11_3_X.

It involves the following packages:

Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder
RecoMTD/DetLayers
SimFastTiming/FastTimingCommon
Validation/MtdValidation

@perrotta, @civanch, @Dr15Jones, @ahmad3213, @kmaeshima, @cvuosalo, @andrius-k, @kpedro88, @ianna, @cmsbuild, @makortel, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @ErnestaP, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

merge

@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771476/15202/summary.html
COMMIT: f5281cb
CMSSW: CMSSW_11_3_X_2021-05-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33793/15202/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771476/15202/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771476/15202/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test GeometryMTDGeometryBuilderTestDriver had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 98 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 360
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2876664
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@smuzaffar smuzaffar deleted the revert-33779-fc-bp33598 branch June 10, 2021 21:35
@jfernan2
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants