Backport of Muon L1 prefire weights #33759

JanFSchulte · 2021-05-17T21:41:46Z

This is a backport of #33758 to the 106X release cycle so the weights can be added to the next nano-AOD production.

Incidentally this PR also serves as a backport of #32728 by @lathomas.

cmsbuild · 2021-05-17T21:42:12Z

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatUtils

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @swertz, @JyothsnaKomaragiri, @ahinzmann, @schoef, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Add Muon L1 to prefire weight producer #33758

mariadalfonso · 2021-05-18T08:14:43Z

as a note, we need to safeguard the current ongoing v8 production in 10_6_X; you should add things like
(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify(xyzTable , xyxVariable = None)

silviodonato · 2021-05-27T08:57:08Z

kind reminder @JanFSchulte (see the comment above)

perrotta · 2021-05-27T09:14:58Z

kind reminder @JanFSchulte (see the comment above)

To be complete, this PR still needs the following:

Provide a backport for Updates to the L1 prefiring weight producer #32728
Synchronize with the latest updates implemented in the master version of this PR (once the review of Add Muon L1 to prefire weight producer #33758 will be completed and it will be merged)
Add the safeguard as requested in Backport of Muon L1 prefire weights #33759 (comment)

perrotta · 2021-05-27T09:15:08Z

backport of #33758

cmsbuild · 2021-05-27T14:33:41Z

Pull request #33759 was updated. @perrotta, @gouskos, @silviodonato, @cmsbuild, @jpata, @fgolf, @slava77, @qliphy, @mariadalfonso, @fabiocos, @davidlange6 can you please check and sign again.

JanFSchulte · 2021-05-27T14:34:47Z

Some comments:

Updates to the L1 prefiring weight producer #32728 Is already backported with the changes made so far
I have made the code changes even with Add Muon L1 to prefire weight producer #33758
I have added the protection, at least insofar as I understood it. This was about not adding the new variables to nanoAOD, right? Because the weight calculation will change regardless with the new code. If that is not desired, I can add a switch to the producer to exclude the muon weights.

cmsbuild · 2021-05-27T14:38:43Z

Pull request #33759 was updated. @perrotta, @gouskos, @silviodonato, @cmsbuild, @jpata, @fgolf, @slava77, @qliphy, @mariadalfonso, @fabiocos, @davidlange6 can you please check and sign again.

mariadalfonso · 2021-05-28T06:51:51Z

I have added the protection, at least insofar as I understood it. This was about not adding the new variables to nanoAOD, right? Because the weight calculation will change regardless with the new code. If that is not desired, I can add a switch to the producer to exclude the muon weights.

this is ok to keep the same set of branches as in production
https://github.com/cms-sw/cmssw/pull/33759/files#diff-9b898944f08810913ea5c1605c47bd9a6c99eb91fc20f491ba2767702f4a0184R259
but also the general weight should not change (so will have to stay the ECAL only), so we need to add a switch

cmsbuild · 2021-05-28T16:06:47Z

Pull request #33759 was updated. @perrotta, @gouskos, @silviodonato, @cmsbuild, @jpata, @fgolf, @slava77, @qliphy, @mariadalfonso, @fabiocos, @davidlange6 can you please check and sign again.

JanFSchulte · 2021-05-28T16:08:45Z

I have added a flag and added the switch to the config to turn muon weights offs in nano V8. I also realized that by backporting #32728 we switched to the new UL2017 maps for ECAL, so I added a protection for that, too. @lathomas could you check if this makes sense.

perrotta · 2021-05-29T20:39:35Z

please test

cmsbuild · 2021-05-29T21:55:37Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7131b/15423/summary.html
COMMIT: 728ae17
CMSSW: CMSSW_10_6_X_2021-05-29-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

136.8523

----- Begin Fatal Exception 29-May-2021 23:02:51 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1PrefiringWeightProducer label='prefiringweight'
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatUtils/data/L1MuonPrefiringParametriations.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 29-May-2021 23:03:29 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1PrefiringWeightProducer label='prefiringweight'
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatUtils/data/L1MuonPrefiringParametriations.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 29-May-2021 23:03:31 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1PrefiringWeightProducer label='prefiringweight'
Exception Message:
edm::FileInPath unable to find file PhysicsTools/PatUtils/data/L1MuonPrefiringParametriations.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15423/CMSSW_10_6_X_2021-05-29-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2021-05-29-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.7722136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log
136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

Expand to see more relval errors ...

mariadalfonso · 2021-05-30T08:45:36Z

test parameters:

pull_request = cms-data/PhysicsTools-PatUtils#2

mariadalfonso · 2021-05-30T08:46:18Z

please test

JanFSchulte · 2021-06-08T22:52:00Z

I can do that, but that will change the name of already existing variables in V8, since the naming scheme was already this way before: https://github.com/cms-sw/cmssw/pull/33759/files#diff-9b898944f08810913ea5c1605c47bd9a6c99eb91fc20f491ba2767702f4a0184R239-R249

mariadalfonso · 2021-06-09T00:02:08Z

before this PR was like this
https://cms-nanoaod-integration.web.cern.ch/integration/33990/mc106Xul16_doc.html#L1PreFiringWeight

now is changing into
https://cms-nanoaod-integration.web.cern.ch/integration/33758/mc106Xul16_doc.html#L1PreFiringWeight
L1PreFiringWeight_L1PreFiringWeight shows up twice

JanFSchulte · 2021-06-09T00:34:46Z

Ah, I get it now, it's because we have added a name to the table. I'll fix that.

cmsbuild · 2021-06-09T02:31:47Z

Pull request #33759 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please check and sign again.

mariadalfonso · 2021-06-09T06:14:00Z

please test

mariadalfonso · 2021-06-09T09:50:49Z

results from this morning nano-test:
tests done on IB: CMSSW_10_6_X_2021-06-08-2300 (it include the final cms-dist)
on Z --> tau tau

The branch name is now fixed
https://cms-nanoaod-integration.web.cern.ch/integration/33759/mc106Xul17v2_doc.html#L1PreFiringWeight
https://cms-nanoaod-integration.web.cern.ch/integration/33759/mc106Xul17v2_size_report.html#L1PreFiringWeight
the nanoV8 we need to restore the pre-changes and what I see looks correct: 2016/2017 only the Nom/Up/Down, 2018 are all set to 1 (but this we expect since the old maps do not exist for the 2018)
DQM-nanov8-2018mc
the nanov9 DQM are like this:

looks ready to be signed, I wait the cms-sw bot finish

cmsbuild · 2021-06-09T15:22:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7131b/15801/summary.html
COMMIT: 991fa3b
CMSSW: CMSSW_10_6_X_2021-06-08-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33759/15801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215678
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215342
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.52 KiB( 34 files compared)
DQMHistoSizes: changed ( 1325.81 ): 0.562 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 136.8523 ): 0.958 KiB Physics/NanoAODDQM
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: found differences in 2 / 34 workflows

mariadalfonso · 2021-06-10T08:17:21Z

comparing master vs backport, I need a clarification on the 2018 set up
see here
https://github.com/cms-sw/cmssw/pull/33759/files#r648949152

perrotta · 2021-06-10T08:23:45Z

PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

-    stage1L1Trigger.toModify(process.prefiringweight, DataEra = "2016BtoH")
-    stage2L1Trigger_2017.toModify(process.prefiringweight, DataEra = "2017BtoF")
+    process.load("PhysicsTools.PatUtils.L1PrefiringWeightProducer_cff")
+    stage2L1Trigger.toModify(process.prefiringweight, DataEraECAL = "2017BtoF", JetMaxMuonFraction = -1, DoMuons = cms.bool(False) )


Is the era correct here ("2017BtoF")?

if we want to reproduce the configuration previous to this PR to comply with the rule forbidding changes to RECO, yes. (these 2017 maps were also mistakenly picked previously for 2016 ...)

if we want to reproduce the configuration previous to this PR to comply with the rule forbidding changes to RECO, yes. (these 2017 maps were also mistakenly picked previously for 2016 ...)

Ok, thank you!

perrotta · 2021-06-11T07:57:52Z

@JanFSchulte @mariadalfonso please notify in this github thread as soon as everything got clarified, so that we can conclude with this backport PR (I can take a "+1" from xpog as an implicit notification).

mariadalfonso · 2021-06-11T14:56:05Z

+xpog

changes inline with master; protected the nanov8 settings
some results here #33759 (comment)

perrotta · 2021-06-11T16:36:46Z

+1

Prefire weights are added for L1 muons
Mostly identical to the master version, modulo the protections at config level and the storage of weights as doubles instead of floats, to satisfy the "no change" rule for stable CMSSW versions.
Usage of those weights is for analyses and for nanoAOD: they do not enter the reconstruction part of the current workflows
Customization looks correct: jenkins tests pass and show no differences wrt baseline in standard workflows
The needed updated externals are already merged with Update L1 prefiring weights for muons cms-data/PhysicsTools-PatUtils#4, with the corresponding updated tag merged in 10_6 with [10.6] Backport of 6998 i.e. PhysicsTools-PatUtils=V00-05-00 cmsdist#7000

cmsbuild · 2021-06-11T16:37:07Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-12T00:46:16Z

+1

cmsbuild added this to the CMSSW_10_6_X milestone May 17, 2021

cmsbuild added orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels May 17, 2021

mariadalfonso mentioned this pull request May 17, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild added backport operations-pending labels May 27, 2021

cmsbuild added tests-started and removed tests-pending labels May 29, 2021

cmsbuild added tests-rejected and removed tests-started labels May 29, 2021

mariadalfonso mentioned this pull request May 30, 2021

Update tag for PhysicsTools-PatUtils to V00-03-00 cms-sw/cmsdist#6938

Merged

cmsbuild added the requires-external label May 30, 2021

fix weight labels in nano

991fa3b

cmsbuild added tests-started and removed tests-pending labels Jun 9, 2021

cmsbuild added tests-approved backport-ok and removed tests-started backport labels Jun 9, 2021

perrotta reviewed Jun 10, 2021

View reviewed changes

cmsbuild added xpog-approved and removed xpog-pending labels Jun 11, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 11, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 12, 2021

cmsbuild merged commit d7f9097 into cms-sw:CMSSW_10_6_X Jun 12, 2021

Backport of Muon L1 prefire weights #33759

Backport of Muon L1 prefire weights #33759

Uh oh!

Conversation

JanFSchulte commented May 17, 2021

Uh oh!

cmsbuild commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mariadalfonso commented May 18, 2021

Uh oh!

silviodonato commented May 27, 2021

Uh oh!

perrotta commented May 27, 2021

Uh oh!

perrotta commented May 27, 2021

Uh oh!

cmsbuild commented May 27, 2021

Uh oh!

JanFSchulte commented May 27, 2021

Uh oh!

cmsbuild commented May 27, 2021

Uh oh!

mariadalfonso commented May 28, 2021

Uh oh!

cmsbuild commented May 28, 2021

Uh oh!

JanFSchulte commented May 28, 2021

Uh oh!

perrotta commented May 29, 2021

Uh oh!

cmsbuild commented May 29, 2021

Unit Tests

RelVals

RelVals-INPUT

Uh oh!

mariadalfonso commented May 30, 2021

Uh oh!

mariadalfonso commented May 30, 2021

Uh oh!

JanFSchulte commented Jun 8, 2021

Uh oh!

mariadalfonso commented Jun 9, 2021

Uh oh!

JanFSchulte commented Jun 9, 2021

Uh oh!

cmsbuild commented Jun 9, 2021

Uh oh!

mariadalfonso commented Jun 9, 2021

Uh oh!

mariadalfonso commented Jun 9, 2021

Uh oh!

cmsbuild commented Jun 9, 2021

Comparison Summary

Uh oh!

mariadalfonso commented Jun 10, 2021

Uh oh!

perrotta Jun 10, 2021

Choose a reason for hiding this comment

Uh oh!

lathomas Jun 10, 2021

Choose a reason for hiding this comment

Uh oh!

perrotta Jun 10, 2021

Choose a reason for hiding this comment

Uh oh!

perrotta commented Jun 11, 2021

Uh oh!

mariadalfonso commented Jun 11, 2021

Uh oh!

perrotta commented Jun 11, 2021

Uh oh!

cmsbuild commented Jun 11, 2021

Uh oh!

qliphy commented Jun 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

cmsbuild commented May 17, 2021 •

edited

Loading