MTD reconstruction: code cleaning for old comments (issue #24452)

[fabiocos]

PR description:

At the time of MTD TDR the reconstruction code was quickly integrated, due to the time constraints, leaving a number of minor comments pending for future cleaning. They were summarised in issue #24452 . Part of them was already addressed, this PR is meant to solve most of the items in the list #24452 (comment) (mostly code aesthetics, by @kpedro88 @Dr15Jones @slava77 ). Those not yet solved here will be separately addressed with the original reviewers in parallel to this PR review.

PR validation:

Code compiles and run, test wf 34634.0 provides the same DQM output.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33680/22581

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Reconstruction_cff.py modified in PR(s): Redesign all GPU workflows to detect if a GPU is present, and fall back to CPU otherwise #33428

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/StandardSequences
DataFormats/FTLRecHit
RecoLocalFastTime/FTLClusterizer
RecoLocalFastTime/FTLRecProducers
RecoMTD/Configuration
RecoMTD/MeasurementDet
TrackingTools/RecoGeometry

@perrotta, @silviodonato, @franzoni, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @bellan, @lecriste, @gpetruc, @ebrondol, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-239dc0/14970/summary.html
COMMIT: 1ddc668
CMSSW: CMSSW_12_0_X_2021-05-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33680/14970/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2663145
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33680/22598

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Reconstruction_cff.py modified in PR(s): Redesign all GPU workflows to detect if a GPU is present, and fall back to CPU otherwise #33428

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33680/22675

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #33680 was updated. @perrotta, @silviodonato, @franzoni, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-239dc0/15098/summary.html
COMMIT: 30d57cf
CMSSW: CMSSW_12_0_X_2021-05-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33680/15098/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-239dc0/15098/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648207
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Technical adjustments/updates
• Jenkins tests pass

[srimanob]

+Upgrade

Code cleaning with no changes expected.

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.