[DD4hep] start on geometry XML payload producer #33548

ianna · 2021-04-27T18:35:25Z

PR description:

@cvuosalo - IMHO, this is a very straightforward way: if xml_geometry_payload is defined, a big XML will be produced (std::cout for now).

Please, see the test:

cmsRun DetectorDescription/DDCMS/test/python/testShapes.py

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

ianna · 2021-04-27T18:36:23Z

@cvuosalo - please, see 5539cc7

cmsbuild · 2021-04-27T18:48:02Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33548/22329

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): update the tracking material for Phase2 geometry D49 #30126, Run4-hgx282 Remove overlap in for EB in 2 recent Phase2 scenarios D82 and D83 #33530
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Update template and gen errors for phase-2 geometries with 3D pixels #33508, Redesign all GPU workflows to detect if a GPU is present, and fall back to CPU otherwise #33428, Add run3 tracking low pu era #33532, Add new workflows to upgradeWorkflowComponents.py for HLT #33461
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2026D83.xml modified in PR(s): Run4-hgx282 Remove overlap in for EB in 2 recent Phase2 scenarios D82 and D83 #33530
- File Geometry/CMSCommonData/python/cmsExtendedGeometry2026D83XML_cfi.py modified in PR(s): Run4-hgx282 Remove overlap in for EB in 2 recent Phase2 scenarios D82 and D83 #33530
- File RecoHGCal/Configuration/python/RecoHGCal_EventContent_cff.py modified in PR(s): [HGCAL] Deprecate MultiCluster #33488, [HGCAL] Simplify makeHGCalValidationPlots #33545
- File RecoHGCal/TICL/python/SimTracksters_cff.py modified in PR(s): [HGCAL] Deprecate MultiCluster #33488, [HGCAL] Simplify makeHGCalValidationPlots #33545
- File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): [HGCAL] Deprecate MultiCluster #33488, [HGCAL] Simplify makeHGCalValidationPlots #33545
- File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): [HGCAL] Deprecate MultiCluster #33488, [HGCAL] Simplify makeHGCalValidationPlots #33545
- File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): [HGCAL] Deprecate MultiCluster #33488, [HGCAL] Simplify makeHGCalValidationPlots #33545
- File Validation/HGCalValidation/scripts/makeHGCalValidationPlots.py modified in PR(s): [HGCAL] Deprecate MultiCluster #33488, [HGCAL] Simplify makeHGCalValidationPlots #33545

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33548/22329/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33548/22329/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

perrotta · 2021-04-30T06:45:50Z

-1
(please rebase in order to get rid of unwanted commits)

cmsbuild · 2021-06-16T08:18:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33548/23350

This PR adds an extra 24KB to repository
Found files with invalid states:
- Geometry/MTDGeometryBuilder/interface/MTDTopologyBuilder.h:
  - Added: faf18ac
  - Deleted: f2a994f
- RecoMTD/DetLayers/test/runTest.sh:
  - Deleted: faf18ac
  - Added: f2a994f
- Geometry/MTDGeometryBuilder/src/MTDPixelTopologyBuilder.cc:
  - Deleted: faf18ac
  - Added: f2a994f
- Geometry/MTDGeometryBuilder/src/MTDTopologyBuilder.cc:
  - Added: faf18ac
  - Deleted: f2a994f
- RecoMTD/DetLayers/test/TestETLNavigation.cc:
  - Deleted: faf18ac
  - Added: f2a994f
- Geometry/MTDGeometryBuilder/interface/MTDPixelTopologyBuilder.h:
  - Deleted: faf18ac
  - Added: f2a994f
There are other open Pull requests which might conflict with changes you have proposed:
- File DetectorDescription/DDCMS/interface/DDParsingContext.h modified in PR(s): [DD4hep] Tool for creation of DD4hep geometry DB payloads and for migration validation #34111
- File DetectorDescription/DDCMS/interface/DDXMLTags.h modified in PR(s): [DD4hep] Tool for creation of DD4hep geometry DB payloads and for migration validation #34111
- File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): [DD4hep] Tool for creation of DD4hep geometry DB payloads and for migration validation #34111

cmsbuild · 2021-06-16T08:21:21Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Calibration/EcalCalibAlgos
DetectorDescription/DDCMS
Geometry/MTDCommonData
RecoLocalTracker/SiPixelRecHits

@perrotta, @malbouis, @civanch, @Dr15Jones, @makortel, @cvuosalo, @tlampen, @ianna, @kpedro88, @cmsbuild, @srimanob, @yuanchao, @mdhildreth, @slava77, @jpata, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@felicepantaleo, @argiro, @OzAmram, @thomreis, @threus, @slomeo, @vargasa, @makortel, @JanFSchulte, @simonepigazzini, @GiacomoSguazzoni, @rovere, @VinInn, @ferencek, @tocheng, @mmusich, @mtosi, @fabiocos, @rchatter, @dkotlins, @gpetruc, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-06-16T08:24:14Z

RecoLocalTracker/SiPixelRecHits/plugins/PixelCPEFastESProducer.cc

  // specific to PixelCPEFastESProducer
  desc.add<std::string>("ComponentName", "PixelCPEFast");
  desc.add<edm::ESInputTag>("MagneticFieldRecord", edm::ESInputTag());
+  desc.addOptional<bool>("useLAAlignmentOffsets", false)->setComment("deprecated");


@ianna why this change?

I think rebase didn't take into an account reverted changes :-(

mmusich · 2021-06-16T08:24:26Z

RecoLocalTracker/SiPixelRecHits/plugins/PixelCPEGenericESProducer.cc

  // specific to PixelCPEGenericESProducer
  desc.add<std::string>("ComponentName", "PixelCPEGeneric");
  desc.add<edm::ESInputTag>("MagneticFieldRecord", edm::ESInputTag(""));
+  desc.addOptional<bool>("useLAAlignmentOffsets", false)->setComment("deprecated");


@ianna why this change?

I think rebase didn't take into an account reverted changes:

Revert "Update mtdParameters for D49 and D60 (Bug fix)", This reverts… … 1307d75 Revert "[backport] MTD geometry and reconstruction: synchronise with … … faf18ac change ECAL pedestals requireStableBeam flag for MWGR test 2a9cbcd Revert "Revert "[backport] MTD geometry and reconstruction: synchroni… …f2a994f revert changes breaking online HLT menu in production release 93afbed

mmusich · 2021-06-16T08:29:26Z

RecoLocalTracker/SiPixelRecHits/plugins/PixelCPETemplateRecoESProducer.cc


  // specific to PixelCPETemplateRecoESProducer
  desc.add<std::string>("ComponentName", "PixelCPETemplateReco");
+  desc.addOptional<bool>("DoLorentz", true)->setComment("deprecated");


@ianna why this change?

same reason as above

fabiocos · 2021-06-16T08:50:15Z

@ianna why restoring old parameters in mtdParameters.xml?

fabiocos · 2021-06-16T08:51:57Z

I guess it is a similar issue as in the discussion with @mmusich ... There is no reason to go back anyway

ianna · 2021-06-16T08:55:24Z

I guess it is a similar issue as in the discussion with @mmusich ... There is no reason to go back anyway

Yes, I have no idea why a rebase picked the other commits. I'll try to rebase again a bit later. If this will not work, I'll cherry-pick my commit and open a new PR.

civanch · 2021-06-16T10:12:09Z

@ianna , better to start a new PR even if extra work will be needed.

slava77 · 2021-06-17T13:37:39Z

-1

it looks like the rebase went wrong and changes in reco code are not expected

srimanob · 2021-07-08T17:28:01Z

@ianna
Do we still need this, or should it be closed? Thanks.

cmsbuild added this to the CMSSW_12_0_X milestone Apr 27, 2021

cmsbuild added alca-pending analysis-pending code-checks-pending core-pending dqm-pending geometry-pending l1-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Apr 27, 2021

ianna marked this pull request as draft April 27, 2021 18:36

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 27, 2021

This was referenced Apr 28, 2021

Add run3 tracking low pu era #33532

Merged

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Merged

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Apr 30, 2021

ianna force-pushed the dd4hep-geometry-payload branch from 913a14e to 08abe62 Compare June 16, 2021 08:10

cmsbuild removed analysis-pending core-pending db-pending dqm-pending generators-pending heterogeneous-pending hlt-pending l1-pending operations-pending pdmv-pending simulation-pending labels Jun 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 16, 2021

mmusich reviewed Jun 16, 2021

View reviewed changes

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Jun 17, 2021

cmsbuild mentioned this pull request Jun 18, 2021

fix DBG IBs warnings about EDM_ML_DEBUG redefined #34180

Merged

cmsbuild mentioned this pull request Jul 6, 2021

[DD4hep] Add support for Assembly tags in XML and for creating DB payload #34344

Merged

ianna closed this Jul 9, 2021

ianna deleted the dd4hep-geometry-payload branch June 25, 2025 16:57

[DD4hep] start on geometry XML payload producer #33548

[DD4hep] start on geometry XML payload producer #33548

Uh oh!

Conversation

ianna commented Apr 27, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

ianna commented Apr 27, 2021

Uh oh!

cmsbuild commented Apr 27, 2021

Uh oh!

perrotta commented Apr 30, 2021

Uh oh!

cmsbuild commented Jun 16, 2021

Uh oh!

cmsbuild commented Jun 16, 2021

Uh oh!

mmusich Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

ianna Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

mmusich Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

ianna Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

mmusich Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

ianna Jun 16, 2021

Choose a reason for hiding this comment

Uh oh!

fabiocos commented Jun 16, 2021

Uh oh!

fabiocos commented Jun 16, 2021

Uh oh!

ianna commented Jun 16, 2021

Uh oh!

civanch commented Jun 16, 2021

Uh oh!

slava77 commented Jun 17, 2021

Uh oh!

srimanob commented Jul 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants