Make BadHcalMitigation enabled by default

[laurenhay]

PR description:

Changes have been implemented to make BadHcalMitigation on by default, as requested in issue #30426 and switch the modifier to disable the mitigation.
This deprecates the workflow 136.8643 which is a duplicate of 136.8642 with only hcal mitigation added.
It also deprecates any relval step containing "BadHcalMitig", as this is now automatically on and an extra step to add it is unnecessary. HcalMitigation for the photon and electron are also enabled by default and the corresponding PF modifier is redefined to allow the mitigation to be turned off.

PR validation:

These updates were validated through building in CMSSW_11_3_X and by running

runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@hatakeyamak @rappoccio @bendavid @marksan87

[cmsbuild]

@laurenhay, CMSSW_11_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

@laurenhay, CMSSW_11_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33413/22054

• This PR adds an extra 80KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Patatrack integration - Pixel workflows (12/N) #31854, Add customisation to make sure that upgrade WFs will cross LS in the short matrix  #32957, Split SiPixelCalSingleMuon into two separate ALCARECO producers #33399, [PPS] Prompt calibration loop component for timing detector #33215, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): PPS: update of era modifiers #33250

[cmsbuild]

A new Pull Request was created by @laurenhay for master.

It involves the following packages:

Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences
RecoJets/JetProducers
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer

@perrotta, @jordan-martins, @chayanit, @wajidalikhan, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @felicepantaleo, @hatakeyamak, @Martin-Grunewald, @lgray, @slomeo, @mmarionncern, @makortel, @dgulhan, @jdolen, @seemasharmafnal, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mtosi, @fabiocos, @clelange, @ahinzmann, @lecriste, @cbernet, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e3c12/14201/summary.html
COMMIT: 3ae9d9f
CMSSW: CMSSW_11_3_X_2021-04-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33413/14201/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e3c12/14201/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6604 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865526
• DQMHistoTests: Total failures: 8771
• DQMHistoTests: Total nulls: 7
• DQMHistoTests: Total successes: 2856726
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.027 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): 0.035 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

RecoParticleFlow/PFClusterProducer/particleFlowBadHcalPseudoCluster_cff.py is empty: is this added by mistake?

[cmsbuild]

Pull request #33413 was updated. @perrotta, @jordan-martins, @chayanit, @wajidalikhan, @srimanob, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e3c12/14246/summary.html
COMMIT: bbb75f1
CMSSW: CMSSW_11_3_X_2021-04-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33413/14246/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e3c12/14246/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6600 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2864426
• DQMHistoTests: Total failures: 8766
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 2855632
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.031 KiB( 37 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): 0.035 KiB JetMET/SUSYDQM
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33413 bbb75f1

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show differences in PF reco and downstream
  • there is no change in HI 2018 wf 140.56 as expected (this was apparently the only wf available in the jenkins tests with comparisons that had the mitigation already enabled)

as an example, in RunEGamma2018C wf 136.874 we can see HEM15-16 as the largest effect in a combination of eta and phi for neutral hadrons:

[srimanob]

+Upgrade

Using BadHcalMitigation as default has been discussed since Run-2 UL.

[chayanit]

+1

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.