[HGCAL] MultiCluster to CaloParticle associator #33384

lecriste · 2021-04-09T11:46:59Z

PR description:

This PR introduces an associator that can be consumed by several analyzers, avoiding code duplication. This PR supersedes PR#32941, no changes are expected in the output.

PR validation:

runTheMatrix -l limited

cmsbuild · 2021-04-09T11:51:36Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21983

This PR adds an extra 204KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/ParticleFlowReco/interface/HGCalMultiCluster.h modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimCalorimetry/HGCalAssociatorProducers/interface/AssociatorTools.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366, MultiCluster-CaloParticle associator #32941
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LayerClusterAssociatorByEnergyScoreImpl.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimCalorimetry/HGCalAssociatorProducers/plugins/MultiClusterAssociatorByEnergyScoreImpl.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimCalorimetry/HGCalAssociatorProducers/plugins/MultiClusterAssociatorByEnergyScoreImpl.h modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimCalorimetry/HGCalAssociatorProducers/plugins/MultiClusterAssociatorByEnergyScoreProducer.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimCalorimetry/HGCalAssociatorProducers/python/MCToCPAssociation_cfi.py modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/interface/MultiClusterToCaloParticleAssociator.h modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/interface/MultiClusterToCaloParticleAssociatorBaseImpl.h modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/plugins/BuildFile.xml modified in PR(s): [HGCAL] Tracksters to SimClusters associator #33333, MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/plugins/MCToCPAssociatorEDProducer.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/src/MultiClusterToCaloParticleAssociator.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/src/MultiClusterToCaloParticleAssociatorBaseImpl.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/src/classes.h modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333, MultiCluster-CaloParticle associator #32941
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333, MultiCluster-CaloParticle associator #32941

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21983/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21983/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-04-09T12:01:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/21984

This PR adds an extra 204KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimCalorimetry/HGCalAssociatorProducers/interface/AssociatorTools.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366
- File SimDataFormats/Associations/plugins/BuildFile.xml modified in PR(s): [HGCAL] Tracksters to SimClusters associator #33333
- File SimDataFormats/Associations/src/classes.h modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186, [HGCAL] Tracksters to SimClusters associator #33333

cmsbuild · 2021-04-09T12:01:28Z

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

DataFormats/ParticleFlowReco
SimCalorimetry/HGCalAssociatorProducers
SimDataFormats/Associations

@perrotta, @civanch, @kpedro88, @cmsbuild, @srimanob, @mdhildreth, @slava77, @jpata can you please review it and eventually sign? Thanks.
@hatakeyamak, @rovere, @lgray, @apsallid, @cbernet, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2021-04-09T13:47:45Z

please test

cmsbuild · 2021-04-14T21:34:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33384/22112

This PR adds an extra 220KB to repository
Found files with invalid states:
- SimDataFormats/Associations/plugins/MCToCPAssociatorEDProducer.cc:
  - Added: 9266ce2
  - Modified: f31f25c, 4bc0d03
  - Deleted: 897fd82
There are other open Pull requests which might conflict with changes you have proposed:
- File SimCalorimetry/HGCalAssociatorProducers/interface/AssociatorTools.h modified in PR(s): [RFC] Test clang-tidy --checks misc-definitions-in-headers #33366
- File SimDataFormats/Associations/src/classes.h modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186

cmsbuild · 2021-04-14T21:35:04Z

Pull request #33384 was updated. @perrotta, @civanch, @kpedro88, @cmsbuild, @srimanob, @mdhildreth, @slava77, @jpata can you please check and sign again.

srimanob · 2021-04-15T01:19:35Z

Please test

cmsbuild · 2021-04-15T06:50:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61da68/14247/summary.html
COMMIT: 9572be0
CMSSW: CMSSW_11_3_X_2021-04-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33384/14247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2864426
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2864403
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

slava77 · 2021-04-16T14:54:38Z

+reconstruction

for #33384 9572be0

the reconstruction category part is almost trivial addition of a typedef in DataFormats/ParticleFlowReco/interface/HGCalMultiCluster.h

civanch · 2021-04-16T19:46:47Z

+1

srimanob · 2021-04-17T07:13:28Z

+Upgrade

cmsbuild · 2021-04-17T07:13:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-04-18T01:32:24Z

+1

lecriste added 10 commits February 3, 2021 10:08

Skeleton for MultiClusters-CaloParticles associator

9266ce2

Skeleton for multiCl-CP associator

91dee87

Skeleton for multiCl-CP associator producer

f31f25c

Fix multiple definition

e0ca3af

Associator implementation

03bf77f

Code checks

4bc0d03

hardScatterOnly argument

003072e

SharedEnergy_caloparticle2multicl_vs_

54bb7e8

Associator only

e437a0c

Fix dependecy

48fd6ac

cmsbuild added this to the CMSSW_11_3_X milestone Apr 9, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Apr 9, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 9, 2021

lecriste mentioned this pull request Apr 9, 2021

MultiCluster-CaloParticle associator #32941

Closed

code-format

331630b

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 14, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 15, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 15, 2021

cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021

cmsbuild mentioned this pull request Apr 16, 2021

moving DataFormats/RecoCandidate/interface/TrackAssociation.h into SimDataFormats #33186

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 16, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Apr 16, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 18, 2021

cmsbuild merged commit 266e788 into cms-sw:master Apr 18, 2021

davidlange6 mentioned this pull request Apr 21, 2021

add missing dependencies to SimDataFormats/Association #33489

Merged

[HGCAL] MultiCluster to CaloParticle associator #33384

[HGCAL] MultiCluster to CaloParticle associator #33384

Uh oh!

Conversation

lecriste commented Apr 9, 2021

PR description:

PR validation:

Uh oh!

cmsbuild commented Apr 9, 2021

Uh oh!

cmsbuild commented Apr 9, 2021

Uh oh!

cmsbuild commented Apr 9, 2021

Uh oh!

perrotta commented Apr 9, 2021

Uh oh!

cmsbuild commented Apr 14, 2021

Uh oh!

cmsbuild commented Apr 14, 2021

Uh oh!

srimanob commented Apr 15, 2021

Uh oh!

cmsbuild commented Apr 15, 2021

Comparison Summary

Uh oh!

slava77 commented Apr 16, 2021

Uh oh!

civanch commented Apr 16, 2021

Uh oh!

srimanob commented Apr 17, 2021

Uh oh!

cmsbuild commented Apr 17, 2021

Uh oh!

qliphy commented Apr 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants