-
Notifications
You must be signed in to change notification settings - Fork 4.6k
new_samples (TTbarLepton_14 and QQH1352T_14) added #33323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33323/21871
|
|
A new Pull Request was created by @sharmaaash (Ashish Sharma) for master. It involves the following packages: Configuration/Generator @SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @srimanob, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| ('WpM_13TeV_TuneCUETP8M1_cfi', UpgradeFragment(Kby(9,50),'WpM_13')), | ||
| ('SingleNuE10_cfi', UpgradeFragment(Kby(9,50),'NuGun')), | ||
| ('TTbarLepton_13TeV_TuneCUETP8M1_cfi', UpgradeFragment(Kby(9,50),'TTbarLepton_13')), | ||
| ('TTbarLepton_14TeV_TuneCUETP8M1_cfi', UpgradeFragment(Kby(9,50),'TTbarLepton_14')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we prefer to put new fragments at the end of the list to avoid changing all the workflow numbers, which could cause confusion and mistakes. @chayanit can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. This will ruin the order of existing workflows. Please add new workflows at the end of the list instead.
|
Reopen new pull request |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33323/21872
|
|
Pull request #33323 was updated. @SiewYan, @mkirsano, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @GurpreetSinghChahal, @srimanob, @agrohsje, @alberto-sanchez can you please check and sign again. |
|
I have modified and created new PR.
*---Cheers,ASHISH Sharma*
…On Fri, Apr 2, 2021 at 10:02 AM Chayanit Asawatangtrakuldee < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
<#33323 (comment)>:
> @@ -1302,11 +1302,13 @@ def __init__(self, howMuch, dataset):
('WpM_13TeV_TuneCUETP8M1_cfi', UpgradeFragment(Kby(9,50),'WpM_13')),
('SingleNuE10_cfi', UpgradeFragment(Kby(9,50),'NuGun')),
('TTbarLepton_13TeV_TuneCUETP8M1_cfi', UpgradeFragment(Kby(9,50),'TTbarLepton_13')),
+ ('TTbarLepton_14TeV_TuneCUETP8M1_cfi', UpgradeFragment(Kby(9,50),'TTbarLepton_14')),
Right. This will ruin the order of existing workflows. Please add new
workflows at the end of the list instead.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33323 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4FZP64UGWKPUY63XJQB3LTGVCGLANCNFSM42IGTSZQ>
.
|
PR description:
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: