[HGCAL] TICL SimTracksters

[felicepantaleo]

PR description:

This PR introduces SimTracksters.
SimTracksters are Tracksters objects containing layerclusters that are associated to the same SimClusters.
They are run in the HGCal Validation Sequence and kept only in FEVT.
They will be useful for benchmarking the pattern recognition as they will produce the best possible tracksters directly from simulation.

PR validation:

used wf 23290.0

@rovere @cseez @ebrondol @lecriste fyi

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33318/21853

• This PR adds an extra 64KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): [HGCAL] TICL iteration data member for tracksters #33290
  • File Validation/Configuration/python/hgcalSimValid_cff.py modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): MultiCluster-CaloParticle associator #32941

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

DataFormats/HGCalReco
RecoHGCal/Configuration
RecoHGCal/TICL
SimDataFormats/Associations
Validation/Configuration
Validation/HGCalValidation

@perrotta, @andrius-k, @kmaeshima, @civanch, @ErnestaP, @ahmad3213, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @kpedro88, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @lecriste, @hatakeyamak, @fabiocos, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f536a9/13896/summary.html
COMMIT: 3ccaff6
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33318/13896/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are 1 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f536a9/13896/llvm-analysis/cmsclangtidy.txt for details.

RelVals

• 34834.999

----- Begin Fatal Exception 31-Mar-2021 19:33:40 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step9'
   [2] Prefetching for module HGCalValidator/'hgcalValidator'
   [3] Calling method for module TrackstersFromSimClustersProducer/'ticlSimTracksters'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<SimCluster>
Looking for module label: mix
Looking for productInstanceName: MergedCaloTruth

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

[kpedro88]

@felicepantaleo you need something like

cmssw/Validation/HGCalValidation/python/HGCalValidator_cfi.py

Lines 78 to 81 in 9c0ef28

	from Configuration.ProcessModifiers.premix_stage2_cff import premix_stage2
	premix_stage2.toModify(hgcalValidator,
	label_cp_fake = "mixData:MergedCaloTruth"
	)

in RecoHGCal/TICL/python/SimTracksters_cff.py

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33318/21859

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): [HGCAL] TICL iteration data member for tracksters #33290
  • File Validation/Configuration/python/hgcalSimValid_cff.py modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): MultiCluster-CaloParticle associator #32941

[cmsbuild]

Pull request #33318 was updated. @perrotta, @andrius-k, @kmaeshima, @civanch, @ErnestaP, @ahmad3213, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @kpedro88, @rvenditti can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33318/22082

• This PR adds an extra 76KB to repository

[cmsbuild]

Pull request #33318 was updated. @perrotta, @andrius-k, @kmaeshima, @civanch, @ErnestaP, @ahmad3213, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @kpedro88, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f536a9/14214/summary.html
COMMIT: 0e28f7d
CMSSW: CMSSW_11_3_X_2021-04-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33318/14214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865526
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2865497
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 21731.488 KiB( 37 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 5432.873 KiB HGCAL/HGCalValidator
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[civanch]

+1

[jpata]

+reconstruction

• adds new Sim-based TICL trackster objects
• we note a new SimDataFormats dependency in RecoHGCAL/TICL. Per [HGCAL] TICL SimTracksters #33318 (comment), if additional sim dependencies are needed in this reco package, the SimTrackster producer should be moved to a separate package
• no reco changes, but there are new DQM objects in the Phase2 workflows

[srimanob]

+Upgrade

This PR also introduces new EventContent, ticlMultiClustersFromSimTracksters, in AOD (so in RECO, FEVT) but as mentioned by the author, MultiClusters collections will be deprecated soon. Still unclear on if-else of PDG ID in TrackstersFromSimClustersProducer.cc, but no harm to have it as it is.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1