Skip to content

Clean BuildFiles and add source_only flags to fix warnings #33282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Apr 2, 2021
Merged

Clean BuildFiles and add source_only flags to fix warnings #33282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CondCore/SiPixelPlugins/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,12 @@
<library file="SiPixelQualityProbabilities_PayloadInspector.cc" name="SiPixelQualityProbabilities_PayloadInspector">
<use name="CondCore/Utilities"/>
<use name="CondCore/CondDB"/>
<use name="CondFormats/Common"/>
<use name="CalibTracker/StandaloneTrackerTopology"/>
</library>

<library file="SiPixelFEDChannelContainer_PayloadInspector.cc" name="SiPixelFEDChannelContainer_PayloadInspector">
<use name="CondCore/Utilities"/>
<use name="CondCore/CondDB"/>
<use name="CondFormats/Common"/>
<use name="CalibTracker/StandaloneTrackerTopology"/>
</library>

Expand Down
2 changes: 1 addition & 1 deletion DataFormats/CSCDigi/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/MuonDetId"/>
<use name="DataFormats/GEMDigi"/>
<use name="DataFormats/MuonData"/>
<use name="DataFormats/MuonData" source_only="1"/>
<use name="FWCore/MessageLogger"/>
<export>
<lib name="1"/>
Expand Down
2 changes: 1 addition & 1 deletion DataFormats/GEMDigi/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/MuonDetId"/>
<use name="DataFormats/GEMRecHit"/>
<use name="DataFormats/MuonData"/>
<use name="DataFormats/MuonData" source_only="1"/>
<use name="FWCore/MessageLogger"/>
<export>
<lib name="1"/>
Expand Down
2 changes: 1 addition & 1 deletion DataFormats/RPCDigi/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<use name="DataFormats/Common"/>
<use name="DataFormats/MuonDetId"/>
<use name="CondFormats/RPCObjects"/>
<use name="DataFormats/MuonData"/>
<use name="DataFormats/MuonData" source_only="1"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/Utilities"/>
<export>
Expand Down
1 change: 0 additions & 1 deletion Geometry/MTDGeometryBuilder/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<use name="FWCore/ParameterSet"/>
<use name="Geometry/CommonTopologies"/>
<use name="Geometry/MTDGeometryBuilder"/>
<use name="Geometry/MTDNumberingBuilder"/>
<use name="Geometry/Records"/>
<use name="boost_system"/>
<use name="rootcling"/>
Expand Down
2 changes: 0 additions & 2 deletions HLTrigger/Egamma/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
<use name="CondFormats/DataRecord"/>
<use name="CondFormats/L1TObjects"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/EgammaCandidates"/>
Expand Down
1 change: 1 addition & 0 deletions HLTrigger/HLTcore/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<use name="DataFormats/Common"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/PrescaleService"/>
<use name="FWCore/ServiceRegistry"/>
<use name="FWCore/MessageLogger"/>
<use name="L1Trigger/GlobalTriggerAnalyzer"/>
Expand Down
1 change: 0 additions & 1 deletion HLTrigger/HLTcore/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
<use name="DataFormats/RecoCandidate"/>
<use name="DataFormats/TauReco"/>
<use name="HLTrigger/HLTcore"/>
<use name="FWCore/PrescaleService"/>
<use name="FWCore/ServiceRegistry"/>
<use name="FWCore/Utilities"/>
<flags EDM_PLUGIN="1"/>
Expand Down
1 change: 0 additions & 1 deletion HeterogeneousCore/SonicTriton/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<flags EDM_PLUGIN="1"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/Framework"/>
<use name="HeterogeneousCore/SonicCore"/>
<use name="HeterogeneousCore/SonicTriton"/>
</library>
</environment>
1 change: 0 additions & 1 deletion L1Trigger/L1TNtuples/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/TrackReco"/>
<use name="EventFilter/L1TRawToDigi"/>
<use name="RecoLocalCalo/EcalRecAlgos"/>
<use name="TrackingTools/TrajectoryState"/>
<use name="L1Trigger/CSCTrackFinder"/>
Expand Down
1 change: 1 addition & 0 deletions L1Trigger/L1TNtuples/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<use name="DataFormats/VertexReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/TrackReco"/>
<use name="EventFilter/L1TRawToDigi"/>
<use name="Geometry/DTGeometry"/>
<use name="Geometry/CSCGeometry"/>
<use name="Geometry/RPCGeometry"/>
Expand Down
6 changes: 3 additions & 3 deletions PhysicsTools/JetExamples/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@
<library file="printJetFlavourInfo.cc">
<flags EDM_PLUGIN="1"/>
<use name="FWCore/Framework"/>
<use name="SimDataFormats/JetMatching"/>
Copy link
Contributor

@perrotta perrotta Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing all these, shouldn't they get replaced by DataFormats/JetMatching?

<use name="DataFormats/Candidate"/>
<use name="DataFormats/JetMatching"/>
<use name="DataFormats/JetReco"/>
</library>

<library file="printJetFlavour.cc">
<flags EDM_PLUGIN="1"/>
<use name="FWCore/Framework"/>
<use name="SimDataFormats/JetMatching"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/JetMatching"/>
<use name="DataFormats/JetReco"/>
</library>

<library file="printGenJetRatio.cc">
<flags EDM_PLUGIN="1"/>
<use name="FWCore/Framework"/>
<use name="SimDataFormats/JetMatching"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/JetMatching"/>
<use name="DataFormats/JetReco"/>
</library>

Expand Down
2 changes: 1 addition & 1 deletion PhysicsTools/JetMCAlgos/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
<use name="PhysicsTools/JetMCAlgos"/>
<use name="PhysicsTools/JetMCUtils"/>
<use name="PhysicsTools/HepMCCandAlgos"/>
<use name="SimDataFormats/JetMatching"/>
Copy link
Contributor

@perrotta perrotta Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here <use name="DataFormats/JetMatching"/> (see recent #33189)

<use name="SimDataFormats/GeneratorProducts"/>
<use name="DataFormats/HepMCCandidate"/>
<use name="CommonTools/CandUtils"/>
<use name="CommonTools/UtilAlgos"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/JetMatching"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/Math"/>
<use name="DataFormats/ParticleFlowCandidate"/>
Expand Down
2 changes: 1 addition & 1 deletion PhysicsTools/PatAlgos/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<use name="DataFormats/PatCandidates"/>
<use name="DataFormats/BTauReco"/>
<use name="DataFormats/Common"/>
<use name="DataFormats/JetMatching"/>
<use name="DataFormats/JetReco"/>
<use name="DataFormats/MuonReco"/>
<use name="DataFormats/TrackReco"/>
Expand All @@ -27,7 +28,6 @@
<use name="RecoEgamma/EgammaTools"/>
<use name="SimDataFormats/Track"/>
<use name="SimDataFormats/Vertex"/>
<use name="SimDataFormats/JetMatching"/>
Copy link
Contributor

@perrotta perrotta Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here <use name="DataFormats/JetMatching"/> (see recent #33189)

<use name="SimDataFormats/PileupSummaryInfo"/>
<use name="SimGeneral/HepPDTRecord"/>
<use name="RecoMET/METAlgorithms"/>
Expand Down
2 changes: 0 additions & 2 deletions RecoEgamma/PhotonIdentification/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<use name="FWCore/Framework"/>
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="CommonTools/Utils"/>
<use name="CondFormats/DataRecord"/>
<use name="CondFormats/EcalObjects"/>
<use name="DataFormats/BeamSpot"/>
<use name="DataFormats/Common"/>
Expand Down
1 change: 1 addition & 0 deletions RecoEgamma/PhotonIdentification/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<use name="CommonTools/Egamma"/>
<use name="CommonTools/MVAUtils"/>
<use name="CommonTools/UtilAlgos"/>
<use name="CommonTools/Utils"/>
<library name="RecoEgammaPhotonIdentificationPlugins" file="*.cc">
<use name="RecoEgamma/PhotonIdentification"/>
<use name="RecoEgamma/EgammaTools"/>
Expand Down
2 changes: 0 additions & 2 deletions RecoHGCal/TICL/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
<use name="FWCore/ParameterSet"/>
<use name="FWCore/PluginManager"/>
<use name="DataFormats/CaloRecHit"/>
<use name="DataFormats/L1Trigger"/>
<use name="DataFormats/Candidate"/>
<use name="DataFormats/ParticleFlowCandidate"/>
<use name="DataFormats/HGCalReco"/>
<use name="FWCore/MessageLogger"/>
Expand Down
3 changes: 0 additions & 3 deletions RecoHGCal/TICL/test/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
<use name="DataFormats/TrackReco"/>
<use name="DataFormats/Math"/>
<use name="SimDataFormats/CaloAnalysis"/>
<use name="Geometry/HcalTowerAlgo"/>
<use name="Geometry/HGCalGeometry"/>
<use name="Geometry/Records"/>
<use name="RecoLocalCalo/HGCalRecAlgos"/>
<flags EDM_PLUGIN="1"/>
<library file="*.cc" name="testRecoHGCalTICL"> </library>
4 changes: 2 additions & 2 deletions RecoTracker/FinalTrackSelectors/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
<use name="FWCore/MessageLogger"/>
<use name="FWCore/ParameterSet"/>
<use name="CondFormats/GBRForest"/>
<use name="PhysicsTools/TensorFlow"/>
<use name="TrackingTools/PatternTools"/>
<use name="roottmva"/>
<use name="lwtnn"/>
<use name="TrackingTools/Records"/>
Copy link
Contributor

@perrotta perrotta Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be replaced by TrackingTools/PatternTools?

<use name="PhysicsTools/TensorFlow"/>
<export>
<lib name="1"/>
</export>
1 change: 1 addition & 0 deletions RecoTracker/FinalTrackSelectors/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
<use name="TrackingTools/TransientTrack"/>
<use name="TrackingTools/GeomPropagators"/>
<use name="TrackingTools/KalmanUpdators"/>
<use name="TrackingTools/Records"/>
<use name="CondFormats/GBRForest"/>
<use name="CommonTools/Utils"/>
<use name="CommonTools/Statistics"/>
Expand Down
1 change: 1 addition & 0 deletions RecoVertex/PrimaryVertexProducer/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<use name="RecoVertex/KalmanVertexFit"/>
<use name="RecoVertex/VertexPrimitives"/>
<use name="RecoVertex/VertexTools"/>
<use name="TrackingTools/Records"/>
<use name="TrackingTools/TransientTrack"/>
<use name="vdt_headers"/>
<export>
Expand Down
1 change: 0 additions & 1 deletion RecoVertex/PrimaryVertexProducer/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<use name="FWCore/Framework"/>
<use name="clhep"/>
<use name="RecoVertex/PrimaryVertexProducer"/>
<use name="TrackingTools/Records"/>
<library file="*.cc" name="RecoVertexPrimaryVertexProducerPlugins">
<flags EDM_PLUGIN="1"/>
</library>
2 changes: 0 additions & 2 deletions Validation/CSCRecHits/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@
<use name="DQMServices/Core"/>
<use name="FWCore/Framework"/>
<use name="FWCore/ParameterSet"/>
<use name="FWCore/ServiceRegistry"/>
<use name="Geometry/CSCGeometry"/>
<use name="Geometry/Records"/>
<use name="SimMuon/MCTruth"/>
<use name="Validation/MuonCSCDigis"/>
<export>
<lib name="1"/>
Expand Down
2 changes: 2 additions & 0 deletions Validation/CSCRecHits/plugins/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<library file="*.cc" name="ValidationCSCRecHitsPlugin">
<use name="FWCore/Framework"/>
<use name="FWCore/ServiceRegistry"/>
<use name="Validation/CSCRecHits"/>
<use name="SimMuon/MCTruth"/>
<use name="clhep"/>
<flags EDM_PLUGIN="1"/>
</library>