Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1190 commits
Select commit Hold shift + click to select a range
c8aa48b
change fillDescriptions to generate EvFOutputModule cfi file for confDB.
smorovic Mar 16, 2021
04a1e0b
code checks
davidlange6 Mar 16, 2021
5a245f5
Code check
Mar 16, 2021
a47ce9b
improved file name generation in FRDOutputModule and test script
smorovic Mar 16, 2021
cf6d18b
code-format
smorovic Mar 16, 2021
246388c
Update HCAL code in material budger studies for DD4HEP
Mar 16, 2021
5899517
Code check
Mar 16, 2021
d89b6be
added comments explaining global vars fix for future reference
alejands Mar 17, 2021
fd4f314
added clarifying that PNMaskFile is no longer used since run 2
alejands Mar 17, 2021
ca9029f
Merge pull request #33171 from smuzaffar/llvm11-warn
cmsbuild Mar 17, 2021
4bcdf96
Merge pull request #33119 from nminafra/ecalTiming_11_3_X_kucc
cmsbuild Mar 17, 2021
53893ec
Merge pull request #33173 from bsunanda/Run4-hgx278X
cmsbuild Mar 17, 2021
c9e21b7
minor formatting fixes to global vars fix
alejands Mar 17, 2021
709c175
Merge pull request #33193 from quark2/GEMonlineDQM_PR_113X
cmsbuild Mar 17, 2021
0840e0b
new enroller based on variadic types
davidlange6 Mar 17, 2021
a07fd65
remove boost?
davidlange6 Mar 17, 2021
0d83c85
cleanup BuildFile
davidlange6 Mar 17, 2021
348740e
cleanup
davidlange6 Mar 17, 2021
4d7cd73
code format
davidlange6 Mar 17, 2021
bb7e921
Update MTD geometry dump, remove dependency on MTDTopology
fabiocos Mar 9, 2021
ca328c1
Fix order of endcap layers, update detailed dumps
fabiocos Mar 10, 2021
bc4619b
Fix the order of multiple ETL hits to follow the expected convention
fabiocos Mar 17, 2021
7ff31f1
replace some run time by compile time calculations
bfonta Mar 17, 2021
67f8a97
Merge pull request #33200 from alejands/globalVars_113X
cmsbuild Mar 17, 2021
f5bcfe7
apply code format
bfonta Mar 17, 2021
580617c
apply code format
bfonta Mar 17, 2021
6a93c06
Update HLT global tags and use a symbolic GT for run2_hlt_hi
christopheralanwest Mar 13, 2021
a8912b7
Use HLT and Express global tags from autoCond
christopheralanwest Mar 17, 2021
43459a5
added MultiplicityValueProducer(s) to HLTrigger/JetMET
missirol Mar 17, 2021
1f1038b
convert MultiplicityValueProducer* from stream to global
missirol Mar 17, 2021
e62cd8b
added include guards to MultiplicityValueProducer*
missirol Mar 17, 2021
4be38a4
split MultiplicityValueProducer* in separate headers
missirol Mar 17, 2021
c24657f
fixed cfi default name of MultiplicityValueProducer*
missirol Mar 17, 2021
35d06bb
removed include in MultiplicityValueProducer*
missirol Mar 17, 2021
a303007
Update PFCalibrationRcd with label HLT
christopheralanwest Mar 17, 2021
dbeb22f
Merge pull request #33146 from dinyar/emtf_displacement_in_regmuoncan…
cmsbuild Mar 17, 2021
ada11b3
add variable to muon and isotrack
sroychow Mar 17, 2021
162ce95
replace explict configuration with a reference from cfipython/, gener…
slava77devel Mar 17, 2021
988b4e0
Add run1_hlt_relval and run1_data to compatibility dictionary
christopheralanwest Mar 17, 2021
f9b641c
Rename run3_data_promptlike key to run3_data_prompt
christopheralanwest Mar 18, 2021
0621711
adding new plots to muon and isotrack collection
sroychow Mar 18, 2021
d613da7
added default values to MultiplicityValueProducer*::fillDescriptions
missirol Mar 18, 2021
6f15bd7
renamed MultiplicityValueProducer* -> HLTMultiplicityValueProducer*
missirol Mar 18, 2021
d5d5ee0
Delete go.1
davidlange6 Mar 18, 2021
fc3c7b9
Change DBS url to cmsweb-prod in MatrixInjector
justinasr Mar 18, 2021
d91f354
Add KaonsL and KaonsS to HGCal validation eff
ebrondol Mar 18, 2021
c578336
Add new conditions to for T25 and T26 to autoCondPhase2
adewit Mar 18, 2021
715a269
increase precision of gen particles
sroychow Mar 18, 2021
32fb1e8
Add support for configuration validation to EDLooper
makortel Mar 18, 2021
5e6cd3a
Merge pull request #33144 from smuzaffar/boost_filesystem_cleanup
cmsbuild Mar 18, 2021
3367af4
Merge pull request #33098 from slomeo/MigrationToDD4hepForME0dbLoader
cmsbuild Mar 18, 2021
df9b098
Merge pull request #33105 from OzAmram/2d_template_cleanup
cmsbuild Mar 18, 2021
3f060cb
Merge pull request #33202 from davidlange6/dl210317
cmsbuild Mar 18, 2021
339a37b
Merge pull request #33204 from missirol/devel_1130pre4_multiplicityVa…
cmsbuild Mar 18, 2021
f67178c
Fix record load string for T25/T26 GenErrors
adewit Mar 18, 2021
28cdb4a
Merge remote-tracking branch 'official-cmssw/master' into mixed-geome…
adewit Mar 18, 2021
0936dc5
couts removed
Tyler-Lam Mar 18, 2021
b06a804
imports constants from common location
swagata87 Mar 18, 2021
ecfd63c
create new file with constants used in localCov
swagata87 Mar 18, 2021
f0b4d1e
code checks
swagata87 Mar 18, 2021
fc5aca2
Update era modifiers for T25/T26
adewit Mar 18, 2021
3f4e65c
Add IT versions for T25 and T26 to README
adewit Mar 18, 2021
ebf48b5
Removing inadvertently added empty lines
adewit Mar 18, 2021
15c94cd
Propagate changes from master branch to cmsExtendedGeometry for D80/81
adewit Mar 18, 2021
d0e00c5
remove dxy and dz cuts on isotracks for mW
mdunser Mar 18, 2021
f4843d6
add Era Phase2C11I13T25M9 and use it where appropriate
mmusich Mar 18, 2021
8c253ed
Merge pull request #33207 from slava77/CMSSW_11_3_X_2021-03-16-1100/s…
cmsbuild Mar 19, 2021
61c1e21
Merge pull request #33195 from bsunanda/Run3-gex63
cmsbuild Mar 19, 2021
8a3e75a
Merge pull request #33168 from slava77/CMSSW_11_3_X_2021-03-08-1100/t…
cmsbuild Mar 19, 2021
c2e5c91
Merge pull request #33198 from smorovic/131X-202103-frdsource_refacto…
cmsbuild Mar 19, 2021
b27fcd0
Merge pull request #33181 from fabiocos/fc-detlayers
cmsbuild Mar 19, 2021
c7e8c5b
Merge pull request #33199 from bsunanda/Run3-hcx294
cmsbuild Mar 19, 2021
8d73184
cleaned up not used sequence
jeongeun Mar 19, 2021
9832dd4
Merge branch 'master' into common112Xupdates
jeongeun Mar 19, 2021
b5e07d5
Merge pull request #1 from mmusich/add_Era_Phase2C11I13T25M9
adewit Mar 19, 2021
1e3ea73
Added record for ECAL trigger double weights mechanism
valsdav Mar 19, 2021
e8badcf
fix of HcalDumpConditions
Mar 19, 2021
aa80a04
Applied code checks
valsdav Mar 19, 2021
652d0d7
Code format cleaning
valsdav Mar 19, 2021
c13313b
Annotate EventSetupImpl::taskArena() as thread safe
makortel Mar 19, 2021
70e05fa
Mark dependence on FWCore/SOA as source-only
makortel Mar 19, 2021
cbe664c
Avoid ASAN problem in HGCalGeomTools::radius
Mar 19, 2021
786a88b
Applied again code checks
valsdav Mar 19, 2021
6cc5d9b
Merge pull request #33201 from jeongeun/common112Xupdates
cmsbuild Mar 19, 2021
add6ea7
Merge pull request #33179 from davidlange6/dl210315fft
cmsbuild Mar 19, 2021
6bfc613
Adding DD4hep D80/D81 configs
adewit Mar 19, 2021
f2e4d64
Update Herwig settings blocks to version 7.2.2
Dominic-Stafford Mar 19, 2021
035d7ef
Update Herwig+Powheg test to use settings blocks
Dominic-Stafford Mar 19, 2021
dc87db2
Print the number of reports per file in parens in the scan-build report
gartung Mar 19, 2021
2c8643b
Combination of ETL time in two discs with compatibility check
fabiocos Mar 18, 2021
35a8695
Fix check on time consistency
fabiocos Mar 18, 2021
e421f92
technical code update, define first hit only in one place
fabiocos Mar 18, 2021
9d5f04a
Reduce number of getattr and other improvements
mbluj Mar 19, 2021
05030c4
Remove debug statements
fabiocos Mar 19, 2021
2da6891
Add Herwig+Madgrpah mlm and FxFx tests
Dominic-Stafford Mar 19, 2021
72ab465
Column with Num repors added
gartung Mar 19, 2021
335e4aa
Use filename line num and parent function for key. Ignore path length.
gartung Mar 19, 2021
14f18b0
Refactor ProductResolvers
Dr15Jones Mar 19, 2021
71fe0cd
Attempt to have common files
Mar 19, 2021
4f7cfcb
Add one missing cff file
Mar 19, 2021
9286126
Code Check
Mar 20, 2021
f5b1bc4
Merge pull request #33229 from gartung/gartung-SA-postprocess
cmsbuild Mar 20, 2021
a03d18b
Merge pull request #33219 from makortel/buildFileTestObjects
cmsbuild Mar 20, 2021
296a4a6
Merge pull request #33218 from makortel/threadSafeEventSetupImplTaskA…
cmsbuild Mar 20, 2021
8394011
Merge pull request #33208 from sroychow/muonandisotrackv9
cmsbuild Mar 20, 2021
81fd7b9
make mult configurable
swagata87 Mar 20, 2021
c7bd7c1
code checks
swagata87 Mar 20, 2021
696a016
Merge pull request #33188 from davidlange6/dl210316tt
cmsbuild Mar 20, 2021
722a167
update CLHEP::Hep3Vector ClassVersion, needed for the update of GEANT…
silviodonato Mar 20, 2021
8df7fd7
As suggested by Matti
Mar 20, 2021
a27c112
Cleanup of several outdated paths (listed in https://twiki.cern.ch/tw…
borzari Mar 20, 2021
b568cef
Protect against concurrent access of DD4Hep Detector
Dr15Jones Mar 20, 2021
b2a79a3
esConsumes migration of HLTrigger/Egamma
missirol Mar 20, 2021
d29525a
esConsumes migration of HLTrigger/HLTanalyzers
missirol Mar 21, 2021
3691115
migrate Validation/TrackerDigis to esConsumes
mmusich Mar 21, 2021
5d0a1d7
esConsumes migration of HLTrigger/HLTcore
missirol Mar 21, 2021
c2651c4
migrate Validation/TrackerHits to esConsumes
mmusich Mar 21, 2021
90a9395
migrate Validation/TrackerRecHits to esConsumes
mmusich Mar 21, 2021
6041c89
migrate Validation/RecoTrack to esConsumes
mmusich Mar 20, 2021
0b80e87
migrate Validation/SiOuterTrackerV to esConsumes
mmusich Mar 21, 2021
42057d7
esConsumes migration of HLTrigger/HLTfilters
missirol Mar 21, 2021
efdc576
esConsumes migration of HLTrigger/JSONMonitoring
missirol Mar 21, 2021
d0d653d
esConsumes migration of HLTrigger/JetMET
missirol Mar 21, 2021
72e7578
esConsumes migration of HLTrigger/Muon
missirol Mar 21, 2021
55f029a
Merge pull request #33235 from mmusich/esCosumesMigration_ValidationR…
cmsbuild Mar 21, 2021
67f6dda
removing commented fragments
Mar 22, 2021
4731ed8
removing empty line
Mar 22, 2021
4d1c923
Added support of conversion timestamp->run to copy function
ggovi Mar 22, 2021
2bbbd04
Merge pull request #33234 from silviodonato/CLHEP_class_version
cmsbuild Mar 22, 2021
1b23a1c
Merge pull request #33238 from mmusich/migrateValidationTracker_esCon…
cmsbuild Mar 22, 2021
3070a54
Merge pull request #33001 from mariadalfonso/ticlNosefixes
cmsbuild Mar 22, 2021
23fad57
Merge pull request #33222 from adewit/mixed-geometries
cmsbuild Mar 22, 2021
ad97afe
Use phase1PixelTopology::numberOfLayers where appropriate
czangela Mar 22, 2021
4d1f89a
clang format
czangela Mar 22, 2021
0de7d4d
Make reference in FullSim as well
Mar 22, 2021
0490073
Avoid use after move
makortel Mar 20, 2021
320065b
Adding new validation plots for tracks and hits
gsorrentino18 Mar 22, 2021
583ab98
update dict map as TTTrackTruthPair is not part of Associations
smuzaffar Mar 22, 2021
b97792b
Merge pull request #33245 from makortel/useAfterMoveGlobalEndLumiAsync
cmsbuild Mar 22, 2021
aa90481
added back dxy and dz cuts for isotracks below 15 GeV. everything abo…
mdunser Mar 22, 2021
0a6d8d5
Optimizing code
Mar 22, 2021
abb2562
Code checks
Mar 22, 2021
94f18a4
esConsumes migration of HLTrigger/btau
missirol Mar 22, 2021
2a151d0
Next step for V15 geometry for HGCal
Mar 22, 2021
571cac7
Code check
Mar 22, 2021
78e26a9
Need to change hfnoseParametersInitialization_cfi.py
Mar 22, 2021
7b4b41d
Merge pull request #33247 from smuzaffar/fix-TTTrackTruthPair-dupDict…
cmsbuild Mar 23, 2021
e95eb16
Merge pull request #33189 from davidlange6/dl210316
cmsbuild Mar 23, 2021
8ffadd1
Merge pull request #33150 from cms-tau-pog/CMSSW_11_3_X_tau-pog_tauID…
cmsbuild Mar 23, 2021
fc2a926
Update track validation plugin
gsorrentino18 Mar 23, 2021
8c93a85
Merge pull request #33244 from czangela/pixel_local_reco_refactorings…
cmsbuild Mar 23, 2021
99380ed
Merge pull request #33236 from Dr15Jones/fixThreadDD4Hep
cmsbuild Mar 23, 2021
0dc9613
Merge pull request #33090 from chayanit/UpdatedGS
cmsbuild Mar 23, 2021
afae069
Adding MEs for track's time and error
gsorrentino18 Mar 23, 2021
5a75c0e
Working (suboptimal) version
Mar 23, 2021
63030a5
Merge pull request #33227 from Dominic-Stafford/Herwig7_2_2_settings_…
cmsbuild Mar 23, 2021
28d9f7a
Merge pull request #33233 from bsunanda/Run3-sim83
cmsbuild Mar 23, 2021
f5c759d
Update LocalOccupancy plot and removing MEs for non MTD tracks
gsorrentino18 Mar 23, 2021
00c4431
Bugfix
Mar 23, 2021
3647ff4
Technical code cleaning following A. Perrotta's comments
fabiocos Mar 23, 2021
6316290
Utilities/StaticAnalyzers: Update EventSetupRecord::get report to rem…
gartung Mar 23, 2021
491a871
HLT menu migration to 11_3_0_pre5
Martin-Grunewald Mar 23, 2021
4e4f884
Make class members
Mar 23, 2021
708078d
Half-strip offset can be negative. Include cases for CFEB changes
Mar 23, 2021
ab0a6fb
Make logic clearer
Mar 23, 2021
7ea174d
Include rare cases where key shifts by +/- 2 half-strips
Mar 23, 2021
848bf90
add weight to output LUT and add all tags to TK
akhukhun Mar 23, 2021
47f368e
run code-checks
akhukhun Mar 23, 2021
8e2ddbc
esConsumes migration of HLTrigger/special
missirol Mar 23, 2021
936cf52
Merge pull request #33148 from swagata87/noiseCleanedLocalCov_113X
cmsbuild Mar 24, 2021
c0f6283
Merge pull request #33116 from thomreis/ecal-local-reco-gpu-fix-issues
cmsbuild Mar 24, 2021
5d97531
remove lumiproducer from RecoTLR
jpata Mar 24, 2021
8f56caa
migrate to esConsumes RecoPixelVertexing/PixelVertexFinding and RecoV…
mmusich Mar 19, 2021
c4551bf
migrate to esConsumes RecoVertex/KalmanVertexFit
mmusich Mar 19, 2021
75e1341
Fixed duplicate definitions of Phase 1 materials (FPix_CFSkin and cie…
ghugo83 Mar 24, 2021
0809661
Adding monitoring of the BTL rechits longitudinal position and fixing…
gsorrentino18 Mar 24, 2021
1af8dad
minor fix: restoring correct value of LocalPositionDebug flag
gsorrentino18 Mar 24, 2021
243c880
Add explicit constructor to set value
Dr15Jones Mar 24, 2021
dac6294
Add back putOrMerge interface to RunPrincipal
Dr15Jones Mar 24, 2021
e55cc02
Added fixed pixfwdMaterials.xml to T3.
ghugo83 Mar 24, 2021
fe4dbec
Merge pull request #33241 from ggovi/condcore-conddb-tools-improvemen…
cmsbuild Mar 24, 2021
1f939c8
Merge pull request #33206 from christopheralanwest/alca-update-relval…
cmsbuild Mar 24, 2021
154662e
Merge pull request #33248 from bsunanda/Phase2-hgx279
cmsbuild Mar 24, 2021
0c38700
Merge pull request #33255 from cms-tsg-storm/HLTmigrationTo1130pre5
cmsbuild Mar 24, 2021
b1665f4
Merge pull request #33118 from cecilecaillol/l1t-integration-CMSSW_11…
cmsbuild Mar 24, 2021
6399684
Merge pull request #33256 from jpata/lumiprod_recotlr
cmsbuild Mar 24, 2021
63175bd
Remove enumerable_thread_specific so we only use one thread_specific …
Mar 24, 2021
574677e
formatting
Mar 24, 2021
84e51f8
address remaining static analyzer complaints in Validation/RecoTrack …
mmusich Mar 24, 2021
2558613
Add wiki links to warning messages for EventSetupRecord::get warning
gartung Mar 24, 2021
d17a4e6
Merge pull request #33251 from gartung/gartung-SA-esrget-report
cmsbuild Mar 25, 2021
5049c0b
Merge pull request #33232 from mmusich/esConsums_vtxing
cmsbuild Mar 25, 2021
94706ff
Merge pull request #32717 from JHiltbrand/112X_hcalPUSub
cmsbuild Mar 25, 2021
3d9996d
Merge pull request #32103 from mdunser/Nano_muPt15Pass
cmsbuild Mar 25, 2021
2f98234
Merge pull request #31634 from hyunyong/MuAl_addGEM_PR
cmsbuild Mar 25, 2021
89c9f3e
Merge pull request #31436 from Dr15Jones/fix_interface_script
cmsbuild Mar 25, 2021
1f16063
Moving fabs to std::abs
gsorrentino18 Mar 25, 2021
96eb0d5
Fix order in CaloParticleSelector
ebrondol Mar 23, 2021
ef8641f
Add 6th sample color and marker
ebrondol Mar 25, 2021
1647d2f
Add comment for kaons in CaloParticleSelectionForEfficiency
ebrondol Mar 25, 2021
6245bea
Refactorise PostProcessorHGCAL_cfi
ebrondol Mar 23, 2021
08503d8
Add TrkEM iteration to validation
lecriste Nov 3, 2020
8fedf08
Rename variable for better understanding
ebrondol Mar 25, 2021
12bf8d6
Include kaons0 in makeHGCalValidationPlots
ebrondol Mar 25, 2021
51ed53a
Use CMS_USE_AVX2 instead of CMS_USE_AVX.
smuzaffar Mar 25, 2021
667fcee
Merge pull request #33260 from missirol/devel_1130pre4_esConsumesHLTr…
cmsbuild Mar 25, 2021
f646cb6
fix memory management and race condition
Mar 25, 2021
d1a585e
Next step for V15 Geometry for HGCal
Mar 25, 2021
6ea63a3
Code check
Mar 25, 2021
c055629
Merge pull request #33262 from mmusich/addressStaticAnalyzerWarnings_…
cmsbuild Mar 25, 2021
b3d43f2
Avoid updating LHERunInfoProduct at end Run in ExternalLHEProducer
Dr15Jones Mar 25, 2021
72b9481
Call putOrMerge for LHERunInfoProduct in LHESource
Dr15Jones Mar 25, 2021
42ee880
Remove overlap
Mar 26, 2021
cb5e140
simplify; skip helix computation for zero field or bad parameters
slava77devel Mar 26, 2021
c497e4a
Merge pull request #33257 from ghugo83/ddd_vs_dd4hep_materials
cmsbuild Mar 26, 2021
d738e33
Merge pull request #33269 from bsunanda/Run4-hgx279
cmsbuild Mar 26, 2021
a1d140d
Merge pull request #33221 from bsunanda/Run4-hgx278X
cmsbuild Mar 26, 2021
e74d4d4
Merge pull request #33274 from Dr15Jones/updateExternalLHEProducer
cmsbuild Mar 26, 2021
60eb51c
Remove some overlap and modify debug statements for quick comparison
Mar 26, 2021
6946fc6
Code check
Mar 26, 2021
64658ee
Merge pull request #33261 from dan131riley/fasttimer-tbb-task-group-2
cmsbuild Mar 26, 2021
3fe8adf
Merge pull request #33277 from slava77/CMSSW_11_3_X_2021-03-23-2300/g…
cmsbuild Mar 26, 2021
65147b9
Update with Fabio's comments and additional MEs
gsorrentino18 Mar 26, 2021
fa617ab
Merge pull request #33213 from makortel/edLooperFillDescriptions
cmsbuild Mar 26, 2021
945a3b8
Merge pull request #33212 from sroychow/gencustomWmass
cmsbuild Mar 26, 2021
dcb4798
Merge pull request #33263 from gartung/gartung-SA-esrget-warn
cmsbuild Mar 26, 2021
a9cd560
Merge pull request #33191 from snwebb/SW-RotationClass-BugFix
cmsbuild Mar 27, 2021
ffe2963
Merge pull request #33279 from bsunanda/Phase2-hgx279x
cmsbuild Mar 27, 2021
057154b
Merge pull request #33268 from smuzaffar/fix-avx-avx2-issue
cmsbuild Mar 27, 2021
65b3d04
Merge pull request #33230 from Dr15Jones/refactorProductRetrievers
cmsbuild Mar 28, 2021
d22e3eb
remove unused parameters in BeamSpot clients
francescobrivio Mar 28, 2021
16233a7
properly set OmsUrlService for DQM replay in BeamSpot clients
francescobrivio Mar 28, 2021
cc160cf
Merge pull request #33276 from bsunanda/Run4-hgx279x
cmsbuild Mar 29, 2021
ea19fe6
Merge pull request #33252 from gsorrentino18/gs-mtdresol2
cmsbuild Mar 29, 2021
0787f8a
Merge pull request #33240 from abdoulline/HcalDumpConditions_fix
cmsbuild Mar 29, 2021
37a6fc0
Merge pull request #33220 from CMS-ECAL-Trigger-Group/ecal_double_wei…
cmsbuild Mar 29, 2021
f3c690b
Merge pull request #33078 from Tyler-Lam/kmtf-fixed-propagation-11_3_X
cmsbuild Mar 29, 2021
655b983
Merge pull request #32683 from b-fontana/SplitModules
cmsbuild Mar 29, 2021
2e998e2
Merge pull request #33254 from dildick/from-CMSSW_11_3_X_2021-03-21-2…
cmsbuild Mar 29, 2021
393780c
Merge pull request #32966 from sscruz/from-CMSSW_11_2_0_pre10_electro…
cmsbuild Mar 29, 2021
704a42e
Make DbsUrl configurable via runTheMatrix argument and env variable
justinasr Mar 29, 2021
172badc
Merge pull request #33271 from ebrondol/hgcal_smallfixes
cmsbuild Mar 29, 2021
6a42283
Merge pull request #33284 from MilanoBicocca-pix/PR4_cleanup
cmsbuild Mar 29, 2021
e84f5e9
Fix range of pull profiles
fabiocos Mar 29, 2021
b9e7c0d
Merge pull request #33291 from fabiocos/fc-mtdvalid
cmsbuild Mar 30, 2021
9c73b95
Merge pull request #33273 from borzari/borzari
cmsbuild Mar 30, 2021
cf12d2a
Merge pull request #33226 from fabiocos/fc-etltime
cmsbuild Mar 30, 2021
b4193ae
Merge pull request #33209 from justinasr/cmsweb-prod
cmsbuild Mar 30, 2021
1c56402
Merge pull request #33253 from akhukhun/addWeightToOutLutsAndModTK1
cmsbuild Mar 30, 2021
e437a0c
Associator only
lecriste Apr 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 3 additions & 2 deletions Alignment/CommonAlignment/interface/AlignableObjectId.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
class TrackerGeometry;
class DTGeometry;
class CSCGeometry;
class GEMGeometry;

/// Allows conversion between type and name, and vice-versa
class AlignableObjectId {
Expand All @@ -15,7 +16,7 @@ class AlignableObjectId {
enum class Geometry { RunI, PhaseI, PhaseII, General, Unspecified };

AlignableObjectId(Geometry);
AlignableObjectId(const TrackerGeometry*, const DTGeometry*, const CSCGeometry*);
AlignableObjectId(const TrackerGeometry*, const DTGeometry*, const CSCGeometry*, const GEMGeometry*);
AlignableObjectId(const AlignableObjectId&) = default;
AlignableObjectId& operator=(const AlignableObjectId&) = default;
AlignableObjectId(AlignableObjectId&&) = default;
Expand Down Expand Up @@ -43,7 +44,7 @@ class AlignableObjectId {

private:
static Geometry trackerGeometry(const TrackerGeometry*);
static Geometry muonGeometry(const DTGeometry*, const CSCGeometry*);
static Geometry muonGeometry(const DTGeometry*, const CSCGeometry*, const GEMGeometry*);

const entry* entries_{nullptr};
Geometry geometry_{Geometry::Unspecified};
Expand Down
6 changes: 6 additions & 0 deletions Alignment/CommonAlignment/interface/StructureType.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ namespace align {
AlignableCSCRing,
AlignableCSCChamber,
AlignableCSCLayer, // = 110
AlignableGEMEndcap,
AlignableGEMStation,
AlignableGEMRing,
AlignableGEMSuperChamber,
AlignableGEMChamber,
AlignableGEMEtaPartition,
AlignableMuon,

Detector, // = 112 (what for?)
Expand Down
2 changes: 1 addition & 1 deletion Alignment/CommonAlignment/src/AlignableCompositeBuilder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ AlignableCompositeBuilder ::AlignableCompositeBuilder(const TrackerTopology* tra
const TrackerGeometry* trackerGeometry,
const AlignableIndexer& alignableIndexer)
: trackerTopology_(trackerTopology),
alignableObjectId_(trackerGeometry, nullptr, nullptr),
alignableObjectId_(trackerGeometry, nullptr, nullptr, nullptr),
alignableIndexer_(alignableIndexer) {}

//_____________________________________________________________________________
Expand Down
21 changes: 18 additions & 3 deletions Alignment/CommonAlignment/src/AlignableObjectId.cc
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ namespace {
{align::AlignableCSCRing, "CSCRing"},
{align::AlignableCSCChamber, "CSCChamber"},
{align::AlignableCSCLayer, "CSCLayer"},
{align::AlignableGEMEndcap, "GEMEndcap"},
{align::AlignableGEMStation, "GEMStation"},
{align::AlignableGEMRing, "GEMRing"},
{align::AlignableGEMSuperChamber, "GEMSuperChamber"},
{align::AlignableGEMChamber, "GEMChamber"},
{align::AlignableGEMEtaPartition, "GEMEtaPartition"},
{align::AlignableMuon, "Muon"},

{align::BeamSpot, "BeamSpot"},
Expand Down Expand Up @@ -201,6 +207,12 @@ namespace {
{align::AlignableCSCRing, "CSCRing"},
{align::AlignableCSCChamber, "CSCChamber"},
{align::AlignableCSCLayer, "CSCLayer"},
{align::AlignableGEMEndcap, "GEMEndcap"},
{align::AlignableGEMStation, "GEMStation"},
{align::AlignableGEMRing, "GEMRing"},
{align::AlignableGEMSuperChamber, "GEMSuperChamber"},
{align::AlignableGEMChamber, "GEMChamber"},
{align::AlignableGEMEtaPartition, "GEMEtaPartition"},
{align::AlignableMuon, "Muon"},

{align::BeamSpot, "BeamSpot"},
Expand Down Expand Up @@ -246,8 +258,9 @@ AlignableObjectId ::AlignableObjectId(AlignableObjectId::Geometry geometry) : ge
//_____________________________________________________________________________
AlignableObjectId ::AlignableObjectId(const TrackerGeometry *tracker,
const DTGeometry *muonDt,
const CSCGeometry *muonCsc)
: AlignableObjectId(commonGeometry(trackerGeometry(tracker), muonGeometry(muonDt, muonCsc))) {}
const CSCGeometry *muonCsc,
const GEMGeometry *muonGem)
: AlignableObjectId(commonGeometry(trackerGeometry(tracker), muonGeometry(muonDt, muonCsc, muonGem))) {}

//_____________________________________________________________________________
align::StructureType AlignableObjectId::nameToType(const std::string &name) const { return stringToId(name.c_str()); }
Expand Down Expand Up @@ -299,7 +312,9 @@ AlignableObjectId::Geometry AlignableObjectId ::trackerGeometry(const TrackerGeo
}
}

AlignableObjectId::Geometry AlignableObjectId ::muonGeometry(const DTGeometry *, const CSCGeometry *) {
AlignableObjectId::Geometry AlignableObjectId ::muonGeometry(const DTGeometry *,
const CSCGeometry *,
const GEMGeometry *) {
// muon alignment structure types are identical for all kinds of geometries
return Geometry::General;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include "Geometry/TrackerGeometryBuilder/interface/TrackerGeomBuilderFromGeometricDet.h"
#include "Geometry/DTGeometry/interface/DTGeometry.h"
#include "Geometry/CSCGeometry/interface/CSCGeometry.h"
#include "Geometry/GEMGeometry/interface/GEMGeometry.h"
#include "Geometry/Records/interface/TrackerTopologyRcd.h"
#include "Geometry/CommonTopologies/interface/GeometryAligner.h"
#include "CondFormats/GeometryObjects/interface/PTrackerParameters.h"
Expand All @@ -50,6 +51,8 @@
#include "CondFormats/AlignmentRecord/interface/DTAlignmentErrorExtendedRcd.h"
#include "CondFormats/AlignmentRecord/interface/CSCAlignmentRcd.h"
#include "CondFormats/AlignmentRecord/interface/CSCAlignmentErrorExtendedRcd.h"
#include "CondFormats/AlignmentRecord/interface/GEMAlignmentRcd.h"
#include "CondFormats/AlignmentRecord/interface/GEMAlignmentErrorExtendedRcd.h"
#include "CondFormats/AlignmentRecord/interface/GlobalPositionRcd.h"
#include "CondFormats/Alignment/interface/DetectorGlobalPosition.h"

Expand Down Expand Up @@ -81,7 +84,16 @@ class AlignmentMonitorAsAnalyzer : public edm::EDAnalyzer {
std::unique_ptr<AlignmentParameterStore> m_alignmentParameterStore;

std::vector<std::unique_ptr<AlignmentMonitorBase>> m_monitors;
std::string idealGeometryLabel;
edm::ESGetToken<DTGeometry, MuonGeometryRecord> esTokenDT_;
edm::ESGetToken<CSCGeometry, MuonGeometryRecord> esTokenCSC_;
edm::ESGetToken<GEMGeometry, MuonGeometryRecord> esTokenGEM_;
edm::ESGetToken<Alignments, GlobalPositionRcd> esTokenGPR_;
edm::ESGetToken<Alignments, DTAlignmentRcd> esTokenDTAl_;
edm::ESGetToken<AlignmentErrorsExtended, DTAlignmentErrorExtendedRcd> esTokenDTAPE_;
edm::ESGetToken<Alignments, CSCAlignmentRcd> esTokenCSCAl_;
edm::ESGetToken<AlignmentErrorsExtended, CSCAlignmentErrorExtendedRcd> esTokenCSCAPE_;
edm::ESGetToken<Alignments, GEMAlignmentRcd> esTokenGEMAl_;
edm::ESGetToken<AlignmentErrorsExtended, GEMAlignmentErrorExtendedRcd> esTokenGEMAPE_;
bool m_firstEvent;
};

Expand All @@ -99,7 +111,9 @@ class AlignmentMonitorAsAnalyzer : public edm::EDAnalyzer {
AlignmentMonitorAsAnalyzer::AlignmentMonitorAsAnalyzer(const edm::ParameterSet& iConfig)
: m_tjTag(iConfig.getParameter<edm::InputTag>("tjTkAssociationMapTag")),
m_aliParamStoreCfg(iConfig.getParameter<edm::ParameterSet>("ParameterStore")),
idealGeometryLabel("idealForAlignmentMonitorAsAnalyzer") {
esTokenDT_(esConsumes(edm::ESInputTag("", "idealForAlignmentMonitorAsAnalyzer"))),
esTokenCSC_(esConsumes(edm::ESInputTag("", "idealForAlignmentMonitorAsAnalyzer"))),
esTokenGEM_(esConsumes(edm::ESInputTag("", "idealForAlignmentMonitorAsAnalyzer"))) {
std::vector<std::string> monitors = iConfig.getUntrackedParameter<std::vector<std::string>>("monitors");

for (auto const& mon : monitors) {
Expand Down Expand Up @@ -129,13 +143,11 @@ void AlignmentMonitorAsAnalyzer::analyze(const edm::Event& iEvent, const edm::Ev
TrackerGeomBuilderFromGeometricDet trackerBuilder;
std::shared_ptr<TrackerGeometry> theTracker(trackerBuilder.build(&(*theGeometricDet), *ptp, tTopo));

edm::ESHandle<DTGeometry> theMuonDT;
edm::ESHandle<CSCGeometry> theMuonCSC;
iSetup.get<MuonGeometryRecord>().get(idealGeometryLabel, theMuonDT);
iSetup.get<MuonGeometryRecord>().get(idealGeometryLabel, theMuonCSC);
edm::ESHandle<DTGeometry> theMuonDT = iSetup.getHandle(esTokenDT_);
edm::ESHandle<CSCGeometry> theMuonCSC = iSetup.getHandle(esTokenCSC_);
edm::ESHandle<GEMGeometry> theMuonGEM = iSetup.getHandle(esTokenGEM_);

edm::ESHandle<Alignments> globalPositionRcd;
iSetup.get<GlobalPositionRcd>().get(globalPositionRcd);
edm::ESHandle<Alignments> globalPositionRcd = iSetup.getHandle(esTokenGPR_);

edm::ESHandle<Alignments> alignments;
iSetup.get<TrackerAlignmentRcd>().get(alignments);
Expand All @@ -146,29 +158,33 @@ void AlignmentMonitorAsAnalyzer::analyze(const edm::Event& iEvent, const edm::Ev
&(*alignmentErrors),
align::DetectorGlobalPosition(*globalPositionRcd, DetId(DetId::Tracker)));

edm::ESHandle<Alignments> dtAlignments;
iSetup.get<DTAlignmentRcd>().get(dtAlignments);
edm::ESHandle<AlignmentErrorsExtended> dtAlignmentErrorsExtended;
iSetup.get<DTAlignmentErrorExtendedRcd>().get(dtAlignmentErrorsExtended);
edm::ESHandle<Alignments> dtAlignments = iSetup.getHandle(esTokenDTAl_);
;
edm::ESHandle<AlignmentErrorsExtended> dtAlignmentErrorsExtended = iSetup.getHandle(esTokenDTAPE_);
aligner.applyAlignments<DTGeometry>(&(*theMuonDT),
&(*dtAlignments),
&(*dtAlignmentErrorsExtended),
align::DetectorGlobalPosition(*globalPositionRcd, DetId(DetId::Muon)));

edm::ESHandle<Alignments> cscAlignments;
iSetup.get<CSCAlignmentRcd>().get(cscAlignments);
edm::ESHandle<AlignmentErrorsExtended> cscAlignmentErrorsExtended;
iSetup.get<CSCAlignmentErrorExtendedRcd>().get(cscAlignmentErrorsExtended);
edm::ESHandle<Alignments> cscAlignments = iSetup.getHandle(esTokenCSCAl_);
edm::ESHandle<AlignmentErrorsExtended> cscAlignmentErrorsExtended = iSetup.getHandle(esTokenCSCAPE_);
aligner.applyAlignments<CSCGeometry>(&(*theMuonCSC),
&(*cscAlignments),
&(*cscAlignmentErrorsExtended),
align::DetectorGlobalPosition(*globalPositionRcd, DetId(DetId::Muon)));

edm::ESHandle<Alignments> gemAlignments = iSetup.getHandle(esTokenGEMAl_);
edm::ESHandle<AlignmentErrorsExtended> gemAlignmentErrorsExtended = iSetup.getHandle(esTokenGEMAPE_);
aligner.applyAlignments<GEMGeometry>(&(*theMuonGEM),
&(*gemAlignments),
&(*gemAlignmentErrorsExtended),
align::DetectorGlobalPosition(*globalPositionRcd, DetId(DetId::Muon)));

// within an analyzer, modules can't expect to see any selected alignables!
align::Alignables empty_alignables;

m_alignableTracker = std::make_unique<AlignableTracker>(&(*theTracker), tTopo);
m_alignableMuon = std::make_unique<AlignableMuon>(&(*theMuonDT), &(*theMuonCSC));
m_alignableMuon = std::make_unique<AlignableMuon>(&(*theMuonDT), &(*theMuonCSC), &(*theMuonGEM));
m_alignmentParameterStore = std::make_unique<AlignmentParameterStore>(empty_alignables, m_aliParamStoreCfg);

for (auto const& monitor : m_monitors) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@

#include "Geometry/DTGeometry/interface/DTGeometry.h"
#include "Geometry/CSCGeometry/interface/CSCGeometry.h"
#include "Geometry/GEMGeometry/interface/GEMGeometry.h"
#include "Geometry/CommonTopologies/interface/GeometryAligner.h"
#include "Geometry/TrackerGeometryBuilder/interface/TrackerGeometry.h"
#include "Geometry/Records/interface/IdealGeometryRecord.h"
Expand Down Expand Up @@ -114,6 +115,7 @@ class AlignmentProducerBase {
std::shared_ptr<TrackerGeometry> trackerGeometry_;
edm::ESHandle<DTGeometry> muonDTGeometry_;
edm::ESHandle<CSCGeometry> muonCSCGeometry_;
edm::ESHandle<GEMGeometry> muonGEMGeometry_;
const bool doTracker_, doMuon_, useExtras_;

/// Map with tracks/trajectories
Expand Down
11 changes: 9 additions & 2 deletions Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ void AlignmentProducerBase::createGeometries(const edm::EventSetup& iSetup, cons
if (doMuon_) {
iSetup.get<MuonGeometryRecord>().get(idealGeometryLabel, muonDTGeometry_);
iSetup.get<MuonGeometryRecord>().get(idealGeometryLabel, muonCSCGeometry_);
iSetup.get<MuonGeometryRecord>().get(idealGeometryLabel, muonGEMGeometry_);
}
}

Expand Down Expand Up @@ -452,6 +453,9 @@ void AlignmentProducerBase::applyAlignmentsToDB(const edm::EventSetup& setup) {

applyDB<CSCGeometry, CSCAlignmentRcd, CSCAlignmentErrorExtendedRcd>(
&*muonCSCGeometry_, setup, align::DetectorGlobalPosition(*globalPositions_, DetId(DetId::Muon)));

applyDB<GEMGeometry, GEMAlignmentRcd, GEMAlignmentErrorExtendedRcd>(
&*muonGEMGeometry_, setup, align::DetectorGlobalPosition(*globalPositions_, DetId(DetId::Muon)));
}
}
}
Expand All @@ -468,9 +472,9 @@ void AlignmentProducerBase::createAlignables(const TrackerTopology* tTopo, bool

if (doMuon_) {
if (update) {
alignableMuon_->update(&*muonDTGeometry_, &*muonCSCGeometry_);
alignableMuon_->update(&*muonDTGeometry_, &*muonCSCGeometry_, &*muonGEMGeometry_);
} else {
alignableMuon_ = std::make_unique<AlignableMuon>(&*muonDTGeometry_, &*muonCSCGeometry_);
alignableMuon_ = std::make_unique<AlignableMuon>(&*muonDTGeometry_, &*muonCSCGeometry_, &*muonGEMGeometry_);
}
}

Expand Down Expand Up @@ -646,12 +650,15 @@ void AlignmentProducerBase::applyAlignmentsToGeometry() {

std::unique_ptr<Alignments> dtAlignments{alignableMuon_->dtAlignments()};
std::unique_ptr<Alignments> cscAlignments{alignableMuon_->cscAlignments()};
std::unique_ptr<Alignments> gemAlignments{alignableMuon_->gemAlignments()};

std::unique_ptr<AlignmentErrorsExtended> dtAlignmentErrExt{alignableMuon_->dtAlignmentErrorsExtended()};
std::unique_ptr<AlignmentErrorsExtended> cscAlignmentErrExt{alignableMuon_->cscAlignmentErrorsExtended()};
std::unique_ptr<AlignmentErrorsExtended> gemAlignmentErrExt{alignableMuon_->gemAlignmentErrorsExtended()};

aligner.applyAlignments(&*muonDTGeometry_, dtAlignments.get(), dtAlignmentErrExt.get(), AlignTransform());
aligner.applyAlignments(&*muonCSCGeometry_, cscAlignments.get(), cscAlignmentErrExt.get(), AlignTransform());
aligner.applyAlignments(&*muonGEMGeometry_, gemAlignments.get(), gemAlignmentErrExt.get(), AlignTransform());
}
}

Expand Down
28 changes: 15 additions & 13 deletions Alignment/LaserAlignment/plugins/LaserAlignment.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,13 @@
///
///
LaserAlignment::LaserAlignment(edm::ParameterSet const& theConf)
: theEvents(0),
: topoToken_(esConsumes()),
geomToken_(esConsumes()),
geomDetToken_(esConsumes()),
ptpToken_(esConsumes()),
gprToken_(esConsumes()),
stripPedestalsToken_(esConsumes()),
theEvents(0),
theDoPedestalSubtraction(theConf.getUntrackedParameter<bool>("SubtractPedestals", true)),
theUseMinuitAlgorithm(theConf.getUntrackedParameter<bool>("RunMinuitAlignmentTubeAlgorithm", false)),
theApplyBeamKinkCorrections(theConf.getUntrackedParameter<bool>("ApplyBeamKinkCorrections", true)),
Expand Down Expand Up @@ -271,32 +277,28 @@ void LaserAlignment::beginJob() {
void LaserAlignment::produce(edm::Event& theEvent, edm::EventSetup const& theSetup) {
if (firstEvent_) {
//Retrieve tracker topology from geometry
edm::ESHandle<TrackerTopology> tTopoHandle;
theSetup.get<TrackerTopologyRcd>().get(tTopoHandle);
const TrackerTopology* const tTopo = tTopoHandle.product();
const TrackerTopology* const tTopo = &theSetup.getData(topoToken_);

// access the tracker
theSetup.get<TrackerDigiGeometryRecord>().get(theTrackerGeometry);
theSetup.get<IdealGeometryRecord>().get(gD);
gD = theSetup.getHandle(geomDetToken_);
theTrackerGeometry = theSetup.getHandle(geomToken_);

// access pedestals (from db..) if desired
edm::ESHandle<SiStripPedestals> pedestalsHandle;
if (theDoPedestalSubtraction) {
theSetup.get<SiStripPedestalsRcd>().get(pedestalsHandle);
pedestalsHandle = theSetup.getHandle(stripPedestalsToken_);
fillPedestalProfiles(pedestalsHandle);
}

// global positions
// edm::ESHandle<Alignments> theGlobalPositionRcd;
theSetup.get<TrackerDigiGeometryRecord>().getRecord<GlobalPositionRcd>().get(theGlobalPositionRcd);
theGlobalPositionRcd = &theSetup.getData(gprToken_);

// select the reference geometry
if (!updateFromInputGeometry) {
// the AlignableTracker object is initialized with the ideal geometry
edm::ESHandle<GeometricDet> theGeometricDet;
theSetup.get<IdealGeometryRecord>().get(theGeometricDet);
edm::ESHandle<PTrackerParameters> ptp;
theSetup.get<PTrackerParametersRcd>().get(ptp);
const GeometricDet* theGeometricDet = &theSetup.getData(geomDetToken_);
const PTrackerParameters* ptp = &theSetup.getData(ptpToken_);

TrackerGeomBuilderFromGeometricDet trackerBuilder;
TrackerGeometry* theRefTracker = trackerBuilder.build(&*theGeometricDet, *ptp, tTopo);

Expand Down
8 changes: 8 additions & 0 deletions Alignment/LaserAlignment/plugins/LaserAlignment.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,14 @@ class LaserAlignment : public edm::one::EDProducer<edm::EndRunProducer> {
LASGlobalData<LASCoordinateSet>&,
LASBarrelAlignmentParameterSet&);

/// Tokens for ESconsumes
const edm::ESGetToken<TrackerTopology, TrackerTopologyRcd> topoToken_;
const edm::ESGetToken<TrackerGeometry, TrackerDigiGeometryRecord> geomToken_;
const edm::ESGetToken<GeometricDet, IdealGeometryRecord> geomDetToken_;
const edm::ESGetToken<PTrackerParameters, PTrackerParametersRcd> ptpToken_;
const edm::ESGetToken<Alignments, GlobalPositionRcd> gprToken_;
const edm::ESGetToken<SiStripPedestals, SiStripPedestalsRcd> stripPedestalsToken_;

/// counter for the total number of events processed
int theEvents;

Expand Down
Loading