Set all member data in SiPixelGenError constructor

[Dr15Jones]

PR description:

This solves a UBSAN compiler warning related to SiPixelGenErrorDBObjectReader. The member data was being read before it was ever set.

PR validation:

Compiled in UBSAN release and the warning no longer appears.

[Dr15Jones]

Here is the code with the problem

cmssw/CondTools/SiPixel/test/SiPixelGenErrorDBObjectReader.cc

Lines 161 to 163 in b1eb848

	SiPixelGenError genError(thePixelGenError);
	// these are all 0 because qbin() was not run.
	cout << " some values " << genError.lorxwidth() << " " << genError.lorywidth() << " " << endl;

the constructor was not setting the values so the were undefined at the time of the printout.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32600/20636

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/SiPixelTransient

@ggovi, @perrotta, @cmsbuild, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @seemasharmafnal, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/11955/summary.html
CMSSW: CMSSW_11_3_X_2021-01-04-1100/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• MLPF: first integration of EDProducer and training code #32048 @jpata: MLPF: first integration of EDProducer and training code

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/11955/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/11955/git-merge-result

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-04-1100/src/CondFormats/SiPixelTransient/src/SiPixelGenError.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-04-1100/src/CondFormats/SiPixelTransient/src/SiPixelTemplate2D.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-04-1100/src/CondFormats/SiPixelTransient/src/SiPixelTemplate.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-04-1100/src/CondFormats/SiPixelTransient/src/SiPixelUtils.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-04-1100/src/CondFormats/SiPixelTransient/src/SiPixelGenError.cc:32:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-01-04-1100/src/CondFormats/SiPixelTransient/interface/SiPixelGenError.h:122:15: error: excess elements in scalar initializer
        fbin_{{0, 0, 0}},
              ^ ~~~~~~~
1 error generated.
gmake: *** [tmp/slc7_amd64_gcc900/src/CondFormats/SiPixelTransient/src/CondFormatsSiPixelTransient/SiPixelGenError.cc.o] Error 1
>> Entering Package RecoParticleFlow/Configuration


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32600/20637

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #32600 was updated. @ggovi, @perrotta, @cmsbuild, @jpata, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/11956/summary.html
CMSSW: CMSSW_11_3_X_2021-01-04-1100/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• MLPF: first integration of EDProducer and training code #32048 @jpata: MLPF: first integration of EDProducer and training code

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/11956/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54febf/11956/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716944
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[slava77]

+1

for #32600 76133f8

• technical, in line with the description
• jenkins tests pass

[Dr15Jones]

ping @cms-sw/db-l2

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1