Set default value for jets w/o SV info in HI CSV tagger #32326

mandrenguyen · 2020-11-29T16:55:36Z

PR description:

The heavy-ion version of the CSV tagger was introduced into 11_2 in #31660
A peak is observed at a discriminator value of 0.30755
This was tracked down to change made during the review of #31660 which changed the way jets with no secondary vertex are identified.
This PR reverts to the original logic, and these jets now take a value of -1, as they should.
11_2_X backport is #32331

PR validation:

Validated with wfs 140.5611 and 158.01

cmsbuild · 2020-11-29T17:02:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32326/20157

This PR adds an extra 12KB to repository

cmsbuild · 2020-11-29T17:03:06Z

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

RecoBTag/Combined

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @JyothsnaKomaragiri, @emilbols, @andrzejnovak, @smoortga this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-11-29T17:53:28Z

please test with workflow 140.5611

perrotta · 2020-11-29T21:32:18Z

please test workflow 140.5611

cmsbuild · 2020-11-29T21:32:42Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 140.5611
CMSSW_11_3_X_2020-11-29-0000/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11145/console Started: 2020/11/29 22:35

cmsbuild · 2020-11-29T22:49:16Z

+1
Tested at: 075599b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a93ba/11145/summary.html
CMSSW: CMSSW_11_3_X_2020-11-29-0000
SCRAM_ARCH: slc7_amd64_gcc900

cmsbuild · 2020-11-29T22:49:18Z

Comparison job queued.

cmsbuild · 2020-11-30T00:09:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a93ba/11145/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 11 differences found in the comparisons
Reco comparison had 1 failed jobs
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529593
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2529561
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 148 log files, 34 edm output root files, 35 DQM output files

RecoBTag/Combined/src/HeavyIonCSVTagger.cc

mandrenguyen · 2020-12-01T09:10:27Z

@mandrenguyen, I think that the following image taken from the jenkins comparisons for wf 158.01 actually shows the effect of the bug (in the baseline) and the fix provided by this PR:

Out of curiosity: what does the value 0.30755 represent for the discriminator (i.e. why did it end up as being the "default" value)?

Thanks for the comparison (and also the suggestions). It would appear that if we send the xml file a negative mass value it will always return the same value for the discriminator. I haven't dug into the file to understand why that happens, but at least it gives the same value every time, and not something random, which would have been harder to spot.

perrotta · 2020-12-01T09:29:31Z

@mandrenguyen (just in case you forgot it): if you apply here the last commit as you did for the 10_2 backport of this PR, I can launch the tests

cmsbuild · 2020-12-01T09:40:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32326/20189

This PR adds an extra 12KB to repository

perrotta · 2020-12-01T09:41:54Z

please test

cmsbuild · 2020-12-01T09:42:13Z

The tests are being triggered in jenkins.

CMSSW_11_3_X_2020-11-30-1100/slc7_amd64_gcc900: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11203/console Started: 2020/12/01 10:44

cmsbuild · 2020-12-01T09:42:14Z

Pull request #32326 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

cmsbuild · 2020-12-01T11:08:22Z

+1
Tested at: f727ad8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a93ba/11203/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

cmsbuild · 2020-12-01T11:08:25Z

Comparison job queued.

cmsbuild · 2020-12-01T12:25:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8a93ba/11203/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529593
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2529557
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 148 log files, 34 edm output root files, 35 DQM output files

perrotta · 2020-12-01T17:43:21Z

+1

It fixes the default value for the disciminator as intended
Jenkins tests pass and show the effect of the fix in the HI miniAOD

cmsbuild · 2020-12-01T17:43:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-12-02T00:15:28Z

+1

Revert to original method of filtering out events w/o SV info

075599b

cmsbuild added this to the CMSSW_11_3_X milestone Nov 29, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 29, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 29, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 30, 2020

mandrenguyen mentioned this pull request Nov 30, 2020

Set default value for jets w/o SV info in HI CSV tagger (112X) #32331

Merged

guitargeek mentioned this pull request Nov 30, 2020

Clean some more BuildFiles #32324

Merged

kpedro88 mentioned this pull request Nov 30, 2020

recoConversion comparison instability in WF 23234.0 #32338

Open

perrotta reviewed Nov 30, 2020

View reviewed changes

RecoBTag/Combined/src/HeavyIonCSVTagger.cc Outdated Show resolved Hide resolved

Reduce frequency of string comparison

ad1e40e

cmsbuild removed the code-checks-approved label Dec 1, 2020

Still less string comp

f727ad8

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 1, 2020

cmsbuild added tests-started and removed tests-pending labels Dec 1, 2020

cmsbuild added tests-approved and removed tests-started labels Dec 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Dec 1, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Dec 1, 2020

cmsbuild added orp-approved and removed orp-pending labels Dec 2, 2020

cmsbuild merged commit 0838466 into cms-sw:master Dec 2, 2020

Set default value for jets w/o SV info in HI CSV tagger #32326

Set default value for jets w/o SV info in HI CSV tagger #32326

Uh oh!

Conversation

mandrenguyen commented Nov 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Nov 29, 2020

Uh oh!

cmsbuild commented Nov 29, 2020

Uh oh!

slava77 commented Nov 29, 2020

Uh oh!

perrotta commented Nov 29, 2020

Uh oh!

cmsbuild commented Nov 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 29, 2020

Uh oh!

cmsbuild commented Nov 29, 2020

Uh oh!

cmsbuild commented Nov 30, 2020

Uh oh!

Uh oh!

mandrenguyen commented Dec 1, 2020

Uh oh!

perrotta commented Dec 1, 2020

Uh oh!

cmsbuild commented Dec 1, 2020

Uh oh!

perrotta commented Dec 1, 2020

Uh oh!

cmsbuild commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 1, 2020

Uh oh!

cmsbuild commented Dec 1, 2020

Uh oh!

cmsbuild commented Dec 1, 2020

Uh oh!

cmsbuild commented Dec 1, 2020

Uh oh!

perrotta commented Dec 1, 2020

Uh oh!

cmsbuild commented Dec 1, 2020

Uh oh!

qliphy commented Dec 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mandrenguyen commented Nov 29, 2020 •

edited

Loading

cmsbuild commented Nov 29, 2020 •

edited

Loading

cmsbuild commented Dec 1, 2020 •

edited

Loading