Skip to content

Conversation

@felicepantaleo
Copy link
Contributor

@felicepantaleo felicepantaleo commented Nov 9, 2020

PR description:

As pointed out by @perrotta in #31906 (comment) this line a code is not used and can create some confusion.
Only technical change. Code compiles and runs.
@rovere please include this in the backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The code-checks are being triggered in jenkins.

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32061/19657

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

RecoHGCal/TICL

@perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@riga, @rovere, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+1
Tested at: ad46bf1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73aaa6/10584/summary.html
CMSSW: CMSSW_11_2_X_2020-11-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-73aaa6/10584/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Nov 9, 2020

+1

  • Just removed one dead line of code in TrackstersMergeProducer
  • Jenkins tests pass

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 9, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 01ca7cd into cms-sw:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants