Skip to content

Tracking Validation: fix some more warnings (Tracking/TrackBHadron) #31785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 4 commits into from
Oct 16, 2020
Merged

Tracking Validation: fix some more warnings (Tracking/TrackBHadron) #31785

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a757806
fix more warnings in Tracking Validation
mmusich Oct 9, 2020
0f96a9f
remove some more warnings due to fast simulation era modifiers
mmusich Oct 14, 2020
eb6dd4c
address comment during review: actually increase the list of subDirs …
mmusich Oct 14, 2020
f54df66
use mother folder for summary harvesting
mmusich Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 33 additions & 5 deletions Validation/RecoTrack/python/PostProcessorTracker_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import FWCore.ParameterSet.Config as cms
from DQMServices.Core.DQMEDHarvester import DQMEDHarvester
from Configuration.Eras.Modifier_fastSim_cff import fastSim

def _addNoFlow(module):
_noflowSeen = set()
Expand All @@ -15,8 +16,11 @@ def _addNoFlow(module):
if not tmp[ind-1] in _noflowSeen:
module.noFlowDists.append(tmp[ind-1])

_defaultSubdirs = ["Tracking/Track/*", "Tracking/TrackTPPtLess09/*", "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackBuilding/*","Tracking/TrackConversion/*", "Tracking/TrackGsf/*"]
_defaultSubdirsSummary = [e.replace("/*","") for e in _defaultSubdirs]

postProcessorTrack = DQMEDHarvester("DQMGenericClient",
subDirs = cms.untracked.vstring("Tracking/Track/*", "Tracking/TrackTPPtLess09/*", "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackBuilding/*", "Tracking/TrackConversion/*", "Tracking/TrackGsf/*", "Tracking/TrackBHadron/*"),
subDirs = cms.untracked.vstring(_defaultSubdirs),
efficiency = cms.vstring(
"effic 'Efficiency vs #eta' num_assoc(simToReco)_eta num_simul_eta",
"efficPt 'Efficiency vs p_{T}' num_assoc(simToReco)_pT num_simul_pT",
Expand Down Expand Up @@ -252,7 +256,7 @@ def _addNoFlow(module):

postProcessorTrack2D = DQMEDHarvester("DQMGenericClient",
makeGlobalEffienciesPlot = cms.untracked.bool(False),
subDirs = cms.untracked.vstring("Tracking/Track/*", "Tracking/TrackTPPtLess09/*", "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackBuilding/*", "Tracking/TrackConversion/*", "Tracking/TrackGsf/*", "Tracking/TrackBHadron/*"),
subDirs = cms.untracked.vstring(_defaultSubdirs),
efficiency = cms.vstring(
"efficPtvseta 'Efficiency in p_{T}-#eta plane' num_assoc(simToReco)_pTvseta num_simul_pTvseta",
"duplicatesRate_Ptvseta 'Duplicates Rate in (p_{T}-#eta) plane' num_duplicate_pTvseta num_reco_pTvseta",
Expand Down Expand Up @@ -294,7 +298,7 @@ def _addNoFlow(module):


postProcessorTrackSummary = DQMEDHarvester("DQMGenericClient",
subDirs = cms.untracked.vstring("Tracking/Track", "Tracking/TrackTPPtLess09", "Tracking/TrackFromPV", "Tracking/TrackFromPVAllTP", "Tracking/TrackAllTPEffic", "Tracking/TrackBuilding", "Tracking/TrackConversion", "Tracking/TrackGsf", "Tracking/TrackBHadron"),
subDirs = cms.untracked.vstring(_defaultSubdirsSummary),
efficiency = cms.vstring(
"effic_vs_coll 'Efficiency vs track collection' num_assoc(simToReco)_coll num_simul_coll",
"effic_vs_coll_allPt 'Efficiency vs track collection' num_assoc(simToReco)_coll_allPt num_simul_coll_allPt",
Expand All @@ -313,6 +317,27 @@ def _addNoFlow(module):
postProcessorTrackSummary
)

fastSim.toModify(postProcessorTrack, subDirs = [e for e in _defaultSubdirs if e not in ["Tracking/TrackGsf/*","Tracking/TrackConversion/*"]])
fastSim.toModify(postProcessorTrackSummary, subDirs = [e for e in _defaultSubdirsSummary if e not in ["Tracking/TrackGsf","Tracking/TrackConversion"]])

#######
# Define a standalone seuquence to support the Standalone harvesting mode
# see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMultiTrackValidator#cmsDriver_MTV_alone_i_e_standalone for more information
########

postProcessorTrackStandalone = postProcessorTrack.clone(
subDirs = _defaultSubdirs+["Tracking/TrackBHadron/*"]
)
postProcessorTrackSummaryStandalone = postProcessorTrackSummary.clone(
subDirs = _defaultSubdirs+["Tracking/TrackBHadron"]
)

postProcessorTrackSequenceStandalone = cms.Sequence(
postProcessorTrackStandalone+
postProcessorTrackNrecVsNsim+
postProcessorTrackSummaryStandalone
)

postProcessorTrackPhase2 = postProcessorTrack.clone()
postProcessorTrackPhase2.subDirs.extend(["Tracking/TrackTPEtaGreater2p7/*"])
postProcessorTrackSummaryPhase2 = postProcessorTrackSummary.clone()
Expand All @@ -323,12 +348,15 @@ def _addNoFlow(module):
phase2_tracker.toReplaceWith(postProcessorTrackSummary,postProcessorTrackSummaryPhase2)

postProcessorTrackTrackingOnly = postProcessorTrack.clone()
postProcessorTrackTrackingOnly.subDirs.extend(["Tracking/TrackSeeding/*", "Tracking/PixelTrack/*"])
postProcessorTrackTrackingOnly.subDirs.extend(["Tracking/TrackBHadron/*","Tracking/TrackSeeding/*", "Tracking/PixelTrack/*"])
postProcessorTrackSummaryTrackingOnly = postProcessorTrackSummary.clone()
postProcessorTrackSummaryTrackingOnly.subDirs.extend(["Tracking/TrackSeeding", "Tracking/PixelTrack"])
postProcessorTrackSummaryTrackingOnly.subDirs.extend(["Tracking/TrackBHadron","Tracking/TrackSeeding", "Tracking/PixelTrack"])

postProcessorTrackSequenceTrackingOnly = cms.Sequence(
postProcessorTrackTrackingOnly+
postProcessorTrackNrecVsNsim+
postProcessorTrackSummaryTrackingOnly
)

fastSim.toModify(postProcessorTrackTrackingOnly,subDirs = [e for e in _defaultSubdirs if e not in ["Tracking/TrackGsf/*","Tracking/TrackConversion/*","Tracking/TrackBHadron/*"]])
fastSim.toModify(postProcessorTrackSummaryTrackingOnly,subDirs = [e for e in _defaultSubdirsSummary if e not in ["Tracking/TrackGsf","Tracking/TrackConversion","Tracking/TrackBHadron"]])